New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 602436 link

Starred by 1 user
Status: Fixed
Owner:
█ w...@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
sande...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Disable idle suspend in fullscreen

Project Member Reported by w...@chromium.org, Apr 11 2016 
On Android it seems like we shouldn't idle suspend because it doesn't really buy us anything and the resume takes a bit of time. Note: if the screen goes off we leave fullscreen.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81727bf6228c98a1a7886d9997c53d018b08ffc8

commit 81727bf6228c98a1a7886d9997c53d018b08ffc8
Author: watk <watk@chromium.org>
Date: Tue Apr 12 00:25:13 2016

media: Don't idle suspend the pipeline when in fullscreen

There's no need to suspend in fullscreen, so by avoiding it we can
save a bit of time when playback is resumed.

BUG= 602436 

Review URL: https://codereview.chromium.org/1880713002

Cr-Commit-Position: refs/heads/master@{#386530}

[modify] https://crrev.com/81727bf6228c98a1a7886d9997c53d018b08ffc8/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/81727bf6228c98a1a7886d9997c53d018b08ffc8/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/81727bf6228c98a1a7886d9997c53d018b08ffc8/media/blink/webmediaplayer_impl_unittest.cc

Comment 2 by w...@chromium.org, Apr 12 2016

Status: Fixed (was: Available)

Comment 3 by w...@chromium.org, Apr 12 2016

Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 12 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4ee63a65a483e538cdde2366a7a891d5de3885

commit 1c4ee63a65a483e538cdde2366a7a891d5de3885
Author: Chris Watkins <watk@chromium.org>
Date: Tue Apr 12 23:46:56 2016

media: Don't idle suspend the pipeline when in fullscreen

There's no need to suspend in fullscreen, so by avoiding it we can
save a bit of time when playback is resumed.

BUG= 602436 

Review URL: https://codereview.chromium.org/1880713002

Cr-Commit-Position: refs/heads/master@{#386530}
(cherry picked from commit 81727bf6228c98a1a7886d9997c53d018b08ffc8)

Review URL: https://codereview.chromium.org/1882663003 .

Cr-Commit-Position: refs/branch-heads/2704@{#19}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/1c4ee63a65a483e538cdde2366a7a891d5de3885/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/1c4ee63a65a483e538cdde2366a7a891d5de3885/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/1c4ee63a65a483e538cdde2366a7a891d5de3885/media/blink/webmediaplayer_impl_unittest.cc
►

Sign in to add a comment