New issue
Advanced search Search tips

Issue 602403 link

Starred by 1 user
Status: Fixed
Owner:
asanka@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 7648



Sign in to add a comment

Store and restore tab URL and tab referrer URLs for downloads

Project Member Reported by asanka@chromium.org, Apr 11 2016 
The tab URL and tab referrer URLs are describe the state associated with the tab that initiated a download. This state is only known when the download is first initiated. These values should be stored in the downloads history so that cross-session resumption can pass these values along to Safe Browsing.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4

commit 038d58d3b114c6bd1d9712f78c23eefb50b9b3d4
Author: asanka <asanka@chromium.org>
Date: Thu Apr 14 00:29:28 2016

[Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Also add a README.md file to components/test/data/history explaining how
to generate a history.NN.sql file.

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG= 602403 

Review URL: https://codereview.chromium.org/1875033005

Cr-Commit-Position: refs/heads/master@{#387169}

[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/chrome/browser/download/download_history.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/history/core/browser/download_database.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/history/core/browser/download_database.h
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/history/core/browser/download_row.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/history/core/browser/download_row.h
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/history/core/browser/history_backend_db_unittest.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/history/core/browser/history_database.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/history/core/test/history_backend_db_base_test.cc
[add] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/test/data/history/README.md
[add] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/components/test/data/history/history.30.sql
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/browser/download/download_item_factory.h
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/browser/download/download_item_impl.h
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/public/browser/download_manager.h
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/public/test/mock_download_manager.cc
[modify] https://crrev.com/038d58d3b114c6bd1d9712f78c23eefb50b9b3d4/content/public/test/mock_download_manager.h

Comment 2 by asanka@chromium.org, Apr 14 2016

Status: Fixed (was: Assigned)

Comment 3 by asanka@chromium.org, May 5 2016

Labels: Merge-Request-51
Requesting merge to M-51. The change has baked on Canary/Dev for two weeks. The change is necessary for ensuring that the SafeBrowsing content check is complete for resumed downloads.

Comment 4 by tin...@google.com, May 5 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 5 by gov...@chromium.org, May 6 2016 

Please merge your change to M51 branch 2704 by 5:00 PM PST Monday(05/09) so we can take it for next week beta release.Thank you.
Project Member

Comment 6 by sheriffbot@chromium.org, May 9 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, May 10 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a7f22877f83aca6844991cfb17db3edd6f0947

commit 77a7f22877f83aca6844991cfb17db3edd6f0947
Author: Asanka Herath <asanka@chromium.org>
Date: Tue May 10 01:54:11 2016

[Merge-M51][Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Also add a README.md file to components/test/data/history explaining how
to generate a history.NN.sql file.

R=sky@chromium.org, jam@chromium.org, svaldez@chromium.org
BUG= 602403 

Review URL: https://codereview.chromium.org/1875033005

Cr-Commit-Position: refs/heads/master@{#387169}
(cherry picked from commit 038d58d3b114c6bd1d9712f78c23eefb50b9b3d4)

Review URL: https://codereview.chromium.org/1967433002 .

Cr-Commit-Position: refs/branch-heads/2704@{#459}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/chrome/browser/download/download_history.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/history/core/browser/download_database.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/history/core/browser/download_database.h
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/history/core/browser/download_row.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/history/core/browser/download_row.h
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/history/core/browser/history_backend_db_unittest.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/history/core/browser/history_database.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/history/core/test/history_backend_db_base_test.cc
[add] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/test/data/history/README.md
[add] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/components/test/data/history/history.30.sql
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/browser/download/download_item_factory.h
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/browser/download/download_item_impl.h
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/public/browser/download_manager.h
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/public/test/mock_download_manager.cc
[modify] https://crrev.com/77a7f22877f83aca6844991cfb17db3edd6f0947/content/public/test/mock_download_manager.h

Comment 8 by asanka@chromium.org, May 10 2016

Labels: -Hotlist-Merge-Approved
►

Sign in to add a comment