Issue metadata
Sign in to add a comment
|
[MaterialDesign] [Mac] Regression: Omnibox and buttons are no longer vertically centered |
||||||||||||||||||||
Issue descriptionVersion: Chromium Build 386406 OS: OSX 10.11.4 What steps will reproduce the problem? (1) Enable material Design (2) Take a look at the Toolbar buttons and Omnibox What is the expected output? What do you see instead? They are no longer vertically centered. Please use labels and text to provide additional information. Screenshots are attached. Probably caused by https://codereview.chromium.org/1870333002 Thanks and regards Mehmet
,
Apr 11 2016
Yes, I was a little bit curious, so that I tested the change in latest Chromium Build. Then I noticed the glitch. Thanks for fixing it in advance.
,
Apr 11 2016
I see. Let me work on a fix.
,
Apr 11 2016
Great, thanks :-)
,
Apr 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a9a39e0a0e2bd60e1ebd81b0dcac4a3525f64e3 commit 4a9a39e0a0e2bd60e1ebd81b0dcac4a3525f64e3 Author: shrike <shrike@chromium.org> Date: Mon Apr 11 23:47:11 2016 [Mac][Material Design] Center elements within the toolbar. This cl fixes a regression in https://codereview.chromium.org/187033300 that leaves the toolbar's elements no longer vertically centered within the toolbar. R=avi@chromium.org BUG= 602393 Review URL: https://codereview.chromium.org/1876293002 Cr-Commit-Position: refs/heads/master@{#386519} [modify] https://crrev.com/4a9a39e0a0e2bd60e1ebd81b0dcac4a3525f64e3/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
,
Apr 11 2016
mehmet@ - thank you for catching this one.
,
Apr 12 2016
You are welcome! It looks good and centered again in latest Chromium 386680. But I noticed another bug now: 1.) There is no space any more between the icon and its menu. 2.) The Menu is no longer aligned with its icon on the right side. It seems there are 2px missing. I don't think that it is intentional. It looks very squeezed. Should I file a new report for it? Thanks and regards Mehmet
,
Apr 12 2016
I need to look at the spec to see where the menu should be placed. Please file a new bug for this issue. Thank you.
,
Apr 12 2016
Done: Issue 602672 . (Adding M-52 to this issue since https://codereview.chromium.org/1870333002 was also M-52). |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Apr 11 2016Labels: -Pri-3 Pri-2