New issue
Advanced search Search tips

Issue 602383 link

Starred by 2 users
Status: WontFix
Owner:
w...@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace #if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON) with #if DCHECK_IS_ON()

Project Member Reported by w...@chromium.org, Apr 11 2016 
base/logging.h now defines DCHECK_IS_ON() if DCHECK is on, so use that rather than checking both NDEBUG and DCHECK_ALWAYS_ON at each condition-site.

Comment 1 by w...@chromium.org, Apr 27 2016

Status: WontFix (was: Assigned)
Making this change requires either:

1. Adding loads of additional base/logging.h includes all over the place.
or
2. Having the build system define DCHECK_IS_ON rather than generating it in logging.h.

Both seem overkill given how rarely this logic will change => WontFix.
►

Sign in to add a comment