New issue
Advanced search Search tips

Issue 602382 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Fixing-touch


Sign in to add a comment

Mac lookup cannot be disabled in Chrome

Project Member Reported by msiegen@google.com, Apr 11 2016

Issue description

Chrome Version       : 48.0.2564.103
OS Version: OS X 10.11.3
Other browsers tested:
     Safari 9.0.3: OK

What steps will reproduce the problem?
1. Go to System Preferences -> Trackpad.
2. Uncheck "Lookup & data detectors".
3. Open Chrome, create a presentation in Google Docs, and insert some text and an image.
4. Select the text using a force click and drag motion with one finger.
5. Move the image using a force click and drag motion with one finger.

What is the expected result?
Text can be selected. The image can be moved.

What happens instead of that?
Text gets highlighted in yellow and a dictionary window pops up. The image cannot be moved and a dictionary window pops up. This makes it difficult to select text on any web site and impossible to move images in Google Docs.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.103 Safari/537.36
 
Components: UI>Input>Touch
Labels: -Pri-3 Pri-2
Owner: tapted@chromium.org
Status: Available (was: Unconfirmed)
tapted@, can you take a look at this?

Comment 2 by tapted@chromium.org, Apr 15 2016

Status: Started (was: Available)
https://codereview.chromium.org/1888343002
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc03c43bcc3d9635d9203685538231c11eec5b8

commit fbc03c43bcc3d9635d9203685538231c11eec5b8
Author: tapted <tapted@chromium.org>
Date: Mon Apr 18 00:38:42 2016

Mac: Honour the user preference for triggering QuickLook with Force Click

Chrome maps force click to Quick Look in the content area since r368481
but a user preference should override that.

Dumping out +[NSUserDefaults standardUserDefaults] after toggling the
setting in the Touchpad System Preferences pane reveals that this info
is stored in "com.apple.trackpad.forceClick". Obey.

BUG= 602382 

Review URL: https://codereview.chromium.org/1888343002

Cr-Commit-Position: refs/heads/master@{#387838}

[modify] https://crrev.com/fbc03c43bcc3d9635d9203685538231c11eec5b8/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/fbc03c43bcc3d9635d9203685538231c11eec5b8/ui/base/cocoa/appkit_utils.h
[modify] https://crrev.com/fbc03c43bcc3d9635d9203685538231c11eec5b8/ui/base/cocoa/appkit_utils.mm

Comment 4 by tapted@chromium.org, Apr 18 2016

Status: Fixed (was: Started)

Sign in to add a comment