New issue
Advanced search Search tips

Issue 602355 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

[remoting android] Implement view-only host prototype

Project Member Reported by lambroslambrou@chromium.org, Apr 11 2016

Issue description

Enable an Android device to be configured as a Chromoting host.
Client can connect in and view the display, but cannot inject input events.

 
Labels: M-52
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51e19b9baa78d3eef889319ba6c49d18d1c22fd7

commit 51e19b9baa78d3eef889319ba6c49d18d1c22fd7
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Wed Apr 13 21:30:41 2016

[remoting android] Add and build host code.

BUG= 602355 

Review URL: https://codereview.chromium.org/1863933002

Cr-Commit-Position: refs/heads/master@{#387103}

[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/BUILD.gn
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/android/BUILD.gn
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/BUILD.gn
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/android/remoting_host_jni_onload.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/audio_capturer_android.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/continue_window_android.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/curtain_mode_android.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/desktop_resizer_android.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/disconnect_window_android.cc
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/host_details.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/input_injector_android.cc
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/it2me/BUILD.gn
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/local_input_monitor_android.cc
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/me2me_desktop_environment.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/pairing_registry_delegate_android.cc
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/policy_watcher.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/resources_android.cc
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/resources_unittest.cc
[add] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/security_key/gnubby_auth_handler_android.cc
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/host/username.cc
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/remoting_enable.gni
[modify] https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7/remoting/remoting_host_srcs.gypi

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8563372f7ba26f49ea5b4f9fcff0ef4a5a5ac68

commit f8563372f7ba26f49ea5b4f9fcff0ef4a5a5ac68
Author: gabadie <gabadie@chromium.org>
Date: Thu Apr 14 16:54:52 2016

Fixes clank down-stream compilation failures of input_injector_android.cc

BUG= 602355 

TBR=lambroslambrou@chromium.org, sergeyu@chromium.org,

Review URL: https://codereview.chromium.org/1883153002

Cr-Commit-Position: refs/heads/master@{#387340}

[modify] https://crrev.com/f8563372f7ba26f49ea5b4f9fcff0ef4a5a5ac68/remoting/host/input_injector_android.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdcec667a89dd09237ceec8df301dc1ca5f88ae9

commit fdcec667a89dd09237ceec8df301dc1ca5f88ae9
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Wed Apr 20 01:16:55 2016

[remoting android] Refactor OAuthTokenFetcher for reusability

This allows the class to be used in host code.
* Token scope is passed in.
* Removed hardcoded error-resources.
* Moved into 'base' package, so it is separated from other client code.

BUG= 602355 

Review URL: https://codereview.chromium.org/1902923002

Cr-Commit-Position: refs/heads/master@{#388395}

[modify] https://crrev.com/fdcec667a89dd09237ceec8df301dc1ca5f88ae9/remoting/android/client_java_tmpl.gni
[modify] https://crrev.com/fdcec667a89dd09237ceec8df301dc1ca5f88ae9/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
[rename] https://crrev.com/fdcec667a89dd09237ceec8df301dc1ca5f88ae9/remoting/android/java/src/org/chromium/chromoting/base/OAuthTokenFetcher.java

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b5df9eece16617116bc4fdbcf79198288ad2844

commit 2b5df9eece16617116bc4fdbcf79198288ad2844
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Fri Apr 22 01:57:48 2016

[remoting android] Initialize It2Me host and implement Connect()

This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG= 602355 

Review URL: https://codereview.chromium.org/1888653002

Cr-Commit-Position: refs/heads/master@{#388999}

[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/android/BUILD.gn
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/android/host/AndroidManifest.xml
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/android/host/res/layout/main.xml
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/android/host/src/org/chromium/chromoting/host/MainActivity.java
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/host/BUILD.gn
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/host/android/jni_host.cc
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/host/android/jni_host.h
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/host/it2me/BUILD.gn
[modify] https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844/remoting/host/policy_watcher.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58294a735594816eb0110d0248c8282d9c1a4ae8

commit 58294a735594816eb0110d0248c8282d9c1a4ae8
Author: jbudorick <jbudorick@chromium.org>
Date: Fri Apr 22 02:44:19 2016

Revert of [remoting android] Initialize It2Me host and implement Connect() (patchset #4 id:60001 of https://codereview.chromium.org/1888653002/ )

Reason for revert:
breaks downstream compilation

Original issue's description:
> [remoting android] Initialize It2Me host and implement Connect()
>
> This adds a "Share" button. Clicking it brings up an account-chooser
> dialog for selecting the account to use for XMPP.
> Then it connects to the Directory server, and gets back an It2Me access
> code.
>
> BUG= 602355 

TBR=sergeyu@chromium.org,lambroslambrou@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 602355 

Review URL: https://codereview.chromium.org/1913023002

Cr-Commit-Position: refs/heads/master@{#389001}

[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/android/BUILD.gn
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/android/host/AndroidManifest.xml
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/android/host/res/layout/main.xml
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/android/host/src/org/chromium/chromoting/host/MainActivity.java
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/host/BUILD.gn
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/host/android/jni_host.cc
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/host/android/jni_host.h
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/host/it2me/BUILD.gn
[modify] https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8/remoting/host/policy_watcher.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/709327e18fc43a9a0f492f15936c2e157f7b9add

commit 709327e18fc43a9a0f492f15936c2e157f7b9add
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Tue Apr 26 19:07:34 2016

Reland: [remoting android] Initialize It2Me host and implement Connect()

Add dependency on google_play_resources.

Original description:
This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG= 602355 

Review URL: https://codereview.chromium.org/1888653002

Cr-Commit-Position: refs/heads/master@{#389835}

[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/android/BUILD.gn
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/android/host/AndroidManifest.xml
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/android/host/res/layout/main.xml
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/android/host/src/org/chromium/chromoting/host/MainActivity.java
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/host/BUILD.gn
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/host/android/jni_host.cc
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/host/android/jni_host.h
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/host/it2me/BUILD.gn
[modify] https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add/remoting/host/policy_watcher.cc

Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/516216ffc55324e899702cee0892f6f99e71d982

commit 516216ffc55324e899702cee0892f6f99e71d982
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Mon May 02 21:51:59 2016

[remoting android] Display IT2Me host state and access-code.

This adds a basic UI to view the notifications and access-code
sent from native code.

BUG= 602355 

Review-Url: https://codereview.chromium.org/1896293002
Cr-Commit-Position: refs/heads/master@{#391062}

[modify] https://crrev.com/516216ffc55324e899702cee0892f6f99e71d982/remoting/android/host/res/layout/main.xml
[modify] https://crrev.com/516216ffc55324e899702cee0892f6f99e71d982/remoting/android/host/src/org/chromium/chromoting/host/MainActivity.java
[modify] https://crrev.com/516216ffc55324e899702cee0892f6f99e71d982/remoting/host/android/jni_host.cc

Owner: ----
Status: Untriaged (was: Started)
Status: WontFix (was: Untriaged)
Closing this for now. We will revisit if conditions change.

Sign in to add a comment