Clean up Chromium-specific patches. |
||||||||||
Issue descriptionThis issue tracks the progress of reducing Chromium-specific patches to make it synchronized with BlueZ upstream. The following comments comes from comment#4 in issue 600655 : [1] https://chromium.googlesource.com/chromiumos/third_party/bluez/+/e3b137d8374c40c8a7cfde4e1b99b71f32884fb6: It might be possible to use AutoEnable in main.conf to do that, anyway I don't see a problem to incorporate that in the policy plugin so we could do for example AutoEnable=auto. [2] https://chromium.googlesource.com/chromiumos/third_party/bluez/+/ce415a42dcfe87e3d4cd678980c477505744abb2: Is this a chromium or actually chrome OS specific? In case of the later I would recommend it to be renamed chromeos. If it indeed used by chromium in Linux I would like to have it upstream, but there are a few things that needs rework like how it enumerates devices is very inefficient since it uses D-Bus to receives signal while it could just register a driver directly with no IPC involved. I actually manage to use the web bluetooth with chromium + bluez without this plugin so I assume it is chrome OS specific thus we can ignore upstream. Btw, pooling connection info is not very efficient but we could in theory do that when reading the RSSI/TX power property for example so the code can check if connected and then issue the HCI command to read the connection info and then update the RSSI/TX power property. [3] https://chromium.googlesource.com/chromiumos/third_party/bluez/+/87773b0e0c433a760aab5712381c3b8ded04a6e0: This could actually be reported upstream since it seems to be fixing a real bug where the old storage was not converted. [4] https://chromium.googlesource.com/chromiumos/third_party/bluez/+/1ec8b33f0763070096e34e1abca2f24943ccd4be: This could be removed if the following options are set properly for HFP/HSP UUID: #[Policy] # # The ReconnectUUIDs defines the set of remote services that should try # to be reconnected to in case of a link loss (link supervision # timeout). The policy plugin should contain a sane set of values by # default, but this list can be overridden here. By setting the list to # empty the reconnection feature gets disabled. #ReconnectUUIDs=00001112-0000-1000-8000-00805f9b34fb, 0000111f-0000-1000-8000-00805f9b34fb, 0000110a-0000-1000-8000-00805f9b34fb # ReconnectAttempts define the number of attempts to reconnect after a link # lost. Setting the value to 0 disables reconnecting feature. #ReconnectAttempts=7 # ReconnectIntervals define the set of intervals in seconds to use in between # attempts. # If the number of attempts defined in ReconnectAttempts is bigger than the # set of intervals the last interval is repeated until the last attempt. #ReconnectIntervals=1, 2, 4, 8, 16, 32, 64 [5] https://chromium.googlesource.com/chromiumos/third_party/bluez/+/dac51d02485dd5d9c0634887397340b41c37860c: We could consider this upstream but the SDP local socket is considered a deprecated interface, instead we recommend to use the Profile API: https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc/profile-api.txt For the remaining patches marked with CHROMIUM: I considered either Chrome OS specific or subject to change upstream like in case of making some API stable which in case of GATT we will be doing quite soon.
,
Apr 21 2016
Hello Luiz, Sorry for the late update, it took a while to go through the code. Here are some following questions and comments. Thanks. [1] https://chromium.googlesource.com/chromiumos/third_party/bluez/+/e3b137d8374c40c8a7cfde4e1b99b71f32884fb6: It seems that AutoEnable in policy is a global policy that apply auto-enalbe/auto-disable to all adapters, but this patch provides more fine-grained powered state policy for individual adapter. Does it this like a feature(fine-grained powered policy) in upstream? If so, do you have any suggestion on the approach? [2] https://chromium.googlesource.com/chromiumos/third_party/bluez/+/ce415a42dcfe87e3d4cd678980c477505744abb2 It is actually a Chromium OS specific. :) It looks like web Bluetooth does not use this interface currently, but some other components using this, e.g. https://code.google.com/p/chromium/codesearch#chromium/src/components/proximity_auth/proximity_monitor_impl.cc. And thanks for the suggestion on the rework, I will address this afterward. [5] https://chromium.googlesource.com/chromiumos/third_party/bluez/+/dac51d02485dd5d9c0634887397340b41c37860c: After looking into the usage, I am not quite sure if we need this or not. As for the profile API, we have adopted this interface. :) Pelase see the following link for the full list of Chromium OS patches: https://docs.google.com/a/google.com/spreadsheets/d/1o4ZRm83lzH-FwZBjiid5bsLzpcAjOMI0snauBUA-JWg/edit?usp=sharing
,
Apr 25 2016
,
Apr 25 2016
,
Apr 27 2016
,
May 16 2016
3 days from branch. Please remove M-52 label from issues, or schedule for 53, as appropriate.
,
May 18 2016
,
Jul 14 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 20 2016
,
Oct 20 2016
,
Apr 20 2017
Issues not modified in last 50 days aren't on track to ship in next release.
,
Apr 19 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by fbeaufort@chromium.org
, Apr 12 2016