mash: ash_sysui crashes on startup due to missing delegate in GetAppListTargetVisibility |
||
Issue descriptionAt HEAD this morning: [9861:9861:0411/094438:260538934677:ERROR:shell_delegate_mus.cc(168)] Not implemented reached in virtual app_list::AppListShower *ash::sysui::ShellDelegateMus::GetAppListShower() Received signal 11 SEGV_MAPERR 000000000000 #0 0x7f90c882a8fe base::debug::StackTrace::StackTrace() #1 0x7f90c882a43f base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f90c6a24340 <unknown> #3 0x7f90c49ae4e0 ash::Shell::GetAppListTargetVisibility() #4 0x7f90c4967261 ash::AppListButton::OnPaint() #5 0x7f90c1b99959 views::View::Paint() #6 0x7f90c1b9d1ed views::View::OnPaintLayer() #7 0x7f90c189ce54 ui::Layer::PaintContentsToDisplayList() #8 0x7f90c189cfc6 ui::Layer::PaintContentsToDisplayList() #9 0x7f90c4320fa3 cc::RecordingSource::UpdateAndExpandInvalidation() #10 0x7f90c426b28b cc::PictureLayer::Update() #11 0x7f90c4435a0a cc::LayerTreeHost::DoUpdateLayers() #12 0x7f90c4435014 cc::LayerTreeHost::UpdateLayers() #13 0x7f90c44f8ea0 cc::SingleThreadProxy::DoBeginMainFrame() #14 0x7f90c44fa0e2 cc::SingleThreadProxy::BeginMainFrame() #15 0x7f90c44fc291 _ZN4base8internal15RunnableAdapterIMN2cc17SingleThreadProxyEFvRKNS2_14BeginFrameArgsEEE3RunIJS6_EEEvPS3_DpOT_ #16 0x7f90c44fc1c5 _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN2cc17SingleThreadProxyEFvRKNS3_14BeginFrameArgsEEEEE8MakeItSoINS_7WeakPtrIS4_EEJS7_EEEvSA_T_DpOT0_ #17 0x7f90c44fc158 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN2cc17SingleThreadProxyEFvRKNS6_14BeginFrameArgsEEEEFvPS7_SA_EJNS_7WeakPtrIS7_EESA_EEENS0_12InvokeHelperILb1EvSD_EEFvvEE3RunEPNS0_13BindStateBaseE #18 0x7f90c880e86e base::Callback<>::Run() #19 0x7f90c88300ae base::debug::TaskAnnotator::RunTask()
,
Apr 11 2016
Landed https://codereview.chromium.org/1879603002/ as a workaround. mash: Fix ash_sysui crash on startup due to missing AppListShower ShellDelegateMus needs to provide a stub implementation. BUG=none TEST=ash_sysui starts under mash without crashing TBR=mfomitchev@chromium.org Committed: https://crrev.com/a6adaac598e4241c09892fa4e2e95ddd70c5a0b0 Cr-Commit-Position: refs/heads/master@{#386431}
,
Apr 11 2016
I think we can mark this Fixed. The real implementation can be tracked separately. Thanks for taking care of this James! |
||
►
Sign in to add a comment |
||
Comment 1 by msw@chromium.org
, Apr 11 2016