New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 602256 link

Starred by 3 users
Status: Fixed
Owner:
█ joh...@chromium.org
no longer working on chrome
Closed: Jul 2016
Cc:
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 525817



Sign in to add a comment

GN build omits PepperToVideoTrackAdapterTest & VideoTrackToPepperAdapterTest

Project Member Reported by joh...@chromium.org, Apr 11 2016 
https://codereview.chromium.org/1335033003[1] put the following two tests:
    pepper_to_video_track_adapter_unittest.cc
    video_track_to_pepper_adapter_unittest.cc
into a new gypi section, 'content_unittests_plugin_webrtc_sources'.

But it forgot to update the GN build accordingly, so PepperToVideoTrackAdapterTest & VideoTrackToPepperAdapterTest aren't currently build (or run) when using GN.

[1]: fc3c2df218caee93a913612a6ad6ef84f6169d0c, master@{#348232}
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ff48068c9df7a6877dab8ba05b2a3f201972410

commit 3ff48068c9df7a6877dab8ba05b2a3f201972410
Author: johnme <johnme@chromium.org>
Date: Mon Apr 11 15:51:08 2016

Re-add webrtc+plugins tests omitted from GN build

https://codereview.chromium.org/1335033003 put the following 2 tests:
    pepper_to_video_track_adapter_unittest.cc
    video_track_to_pepper_adapter_unittest.cc
into a new gypi section, 'content_unittests_plugin_webrtc_sources'.

But it forgot to update the GN build accordingly, so
PepperToVideoTrackAdapterTest & VideoTrackToPepperAdapterTest aren't
currently built (or run) when using GN.

This patch fixes that, putting the GN build back in sync with GYP.

BUG= 602256 ,  525817 

Review URL: https://codereview.chromium.org/1880483002

Cr-Commit-Position: refs/heads/master@{#386394}

[modify] https://crrev.com/3ff48068c9df7a6877dab8ba05b2a3f201972410/content/test/BUILD.gn
►

Sign in to add a comment