Visual polish of the notice about other forms of browsing history |
|||||
Issue descriptionThis is the implementation bug to collect the visual polishing CLs of the footers added in issue 595332 . The CLs are extracted into a separate issue to make it easier to request a merge for them.
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5301cfa576d36e6d84acd6e2ca33f74047140ed9 commit 5301cfa576d36e6d84acd6e2ca33f74047140ed9 Author: msramek <msramek@chromium.org> Date: Wed Apr 13 09:45:37 2016 Adjust the footer layout in ClearBrowsingDataPreferences 1. According to the material design specification, the icon in the footer should be aligned with the top of the footer text. However, this does not look correctly, as there is still empty space between the top of the TextView and the actual top of the tallest letter. Therefore, we lower the icon a few pixels to match the ascender line of the font. 2. The default padding of preferences is 16dp. This means that the spacing around the two footer paragraphs is 16dp-32dp-16dp. Our mocks require 16dp-16dp-24dp. We therefore define the default bottom padding to be 24dp, leading to 16dp-40dp-24dp, then remove the bottom padding of the first paragraph, leading to the correct 16dp-16dp-24dp. BUG= 602253 Review URL: https://codereview.chromium.org/1872363002 Cr-Commit-Position: refs/heads/master@{#386951} [modify] https://crrev.com/5301cfa576d36e6d84acd6e2ca33f74047140ed9/chrome/android/java/res/layout/text_message_with_link_and_icon_preference.xml [modify] https://crrev.com/5301cfa576d36e6d84acd6e2ca33f74047140ed9/chrome/android/java/res/values/attrs.xml [modify] https://crrev.com/5301cfa576d36e6d84acd6e2ca33f74047140ed9/chrome/android/java/res/xml/clear_browsing_data_preferences.xml [modify] https://crrev.com/5301cfa576d36e6d84acd6e2ca33f74047140ed9/chrome/android/java/src/org/chromium/chrome/browser/preferences/TextMessageWithLinkAndIconPreference.java
,
Apr 13 2016
Requesting the merge of the above two CLs to M51. They only polish the UI by adjusting paddings and replacing a button, but don't change any of the logic of the feature in issue 595332 .
,
Apr 14 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa1a6d9a6f2def001bee954d3559471ddbe20d5b commit fa1a6d9a6f2def001bee954d3559471ddbe20d5b Author: Martin Sramek <msramek@chromium.org> Date: Thu Apr 14 09:40:42 2016 Replace the "OK" button with "Ok, got it" in the Clear Browsing Data dialog BUG= 602253 Review URL: https://codereview.chromium.org/1880503002 Cr-Commit-Position: refs/heads/master@{#386632} (cherry picked from commit 9eadaadadad919da17f2f954d63f1c522d434f28) Review URL: https://codereview.chromium.org/1882953003 . Cr-Commit-Position: refs/branch-heads/2704@{#49} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/fa1a6d9a6f2def001bee954d3559471ddbe20d5b/chrome/browser/resources/options/clear_browser_data_history_notice_overlay.html [modify] https://crrev.com/fa1a6d9a6f2def001bee954d3559471ddbe20d5b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79865a7346184c429005aba0355262951e1f0d3b commit 79865a7346184c429005aba0355262951e1f0d3b Author: Martin Sramek <msramek@chromium.org> Date: Thu Apr 14 09:47:41 2016 Adjust the footer layout in ClearBrowsingDataPreferences 1. According to the material design specification, the icon in the footer should be aligned with the top of the footer text. However, this does not look correctly, as there is still empty space between the top of the TextView and the actual top of the tallest letter. Therefore, we lower the icon a few pixels to match the ascender line of the font. 2. The default padding of preferences is 16dp. This means that the spacing around the two footer paragraphs is 16dp-32dp-16dp. Our mocks require 16dp-16dp-24dp. We therefore define the default bottom padding to be 24dp, leading to 16dp-40dp-24dp, then remove the bottom padding of the first paragraph, leading to the correct 16dp-16dp-24dp. BUG= 602253 Review URL: https://codereview.chromium.org/1872363002 Cr-Commit-Position: refs/heads/master@{#386951} (cherry picked from commit 5301cfa576d36e6d84acd6e2ca33f74047140ed9) Review URL: https://codereview.chromium.org/1885343002 . Cr-Commit-Position: refs/branch-heads/2704@{#50} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/79865a7346184c429005aba0355262951e1f0d3b/chrome/android/java/res/layout/text_message_with_link_and_icon_preference.xml [modify] https://crrev.com/79865a7346184c429005aba0355262951e1f0d3b/chrome/android/java/res/values/attrs.xml [modify] https://crrev.com/79865a7346184c429005aba0355262951e1f0d3b/chrome/android/java/res/xml/clear_browsing_data_preferences.xml [modify] https://crrev.com/79865a7346184c429005aba0355262951e1f0d3b/chrome/android/java/src/org/chromium/chrome/browser/preferences/TextMessageWithLinkAndIconPreference.java
,
Apr 14 2016
Both CLs have now been merged. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 12 2016