New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602250 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Track loading behavior from Blink and expose to //content and consumers

Project Member Reported by csharrison@chromium.org, Apr 11 2016

Issue description

There are many useful loading signals that Blink is aware of that would be useful to expose to the page_load_metrics system.

One example of such a signal would be "did Blink use a codepath pertinent to some experiment X?"

This approach will allow us to separate histograms by very fine grained details. The first step would be to thread a loading behavior enum into RenderFrameObserver. Then, we can integrate it into the page_load_metrics RenderFrameObserver and send a packed flag up via IPC.

The first part of this work landed here:
https://codereview.chromium.org/1846143003
 

Comment 1 by sshru...@google.com, Apr 11 2016

Is this a new feature? It looks like there are two patches that landed, are we only requesting a merge on the first one?
This CL just exposes data for metrics collection. We also plan on merging the related CL https://codereview.chromium.org/1857443002/.

These metrics will be very useful for experiments we are running in M51.

Comment 3 by tin...@google.com, Apr 12 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Hi tinazh@, this change exposed a flaky layout test. I've since added an expectation of failure temporarily for the test. Does that need to be merged as well before this one?
https://codereview.chromium.org/1880893002/


Cc: tinazh@chromium.org
actually ccing tinazh@.
Cc: -tinazh@chromium.org
Status: Fixed (was: Started)
Going to merge this in now.
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 29 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-51 Merge-Merged

Sign in to add a comment