Issue metadata
Sign in to add a comment
|
A zero-to-nonzero to 50% regression in webrtc_perf_tests at 12258:12259 |
||||||||||||||||||
Issue descriptionThis degradation seems to be caused by https://chromium.googlesource.com/external/webrtc/+log/fc3ef3e5c114117005dbaf030f95bc9e5a6a2cc5..0bf612b3ec2fc1d419e3967ce4afd97a28f4786d It could be intended. But please take a look.
,
Apr 15 2016
This change is so small so it is expected that the changes in the code being done could have caused it. Therefore I'd say it is fine and expected.
,
Apr 15 2016
Closing this bug.
,
Apr 15 2016
I cannot agree that the change is so small, it is 50%. But you know better.
,
Apr 15 2016
Sorry, I probably should have been more verbose. What I meant was that the absolute value of the changes was so small. You are definitely right that in percent it is high. But you should take into account that the failing tests are the worst case call duration of the render side in the audio processing module when no processing at all is done. The code in the CL that caused this degradation reintroduces the resampling of a 48 kHz render signal to 16 kHz that was present before March 17 so the call duration increase is not an increase if you look longer back in time. And regardless of that, the increase is very small compared to the complexity in the module when actual processing is done. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by minyue@chromium.org
, Apr 11 2016