New issue
Advanced search Search tips

Issue 602211 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Browser gets crashed after navigating to chrome://md-settings page in incognito mode.

Reported by rk...@etouch.net, Apr 11 2016

Issue description

Chrome Version : 52.0.2705.0 Revision fefaf92686d3786bd74fbda74d7dff3ca2f49e3e-refs/heads/master@{#386318}(32/64 bit)
OS: All(Win-7 Aero Enabled)

Precondition: Enable 'Material design in the browser's top chrome' by selecting 'Material' option.

What steps will reproduce the problem?
(1) Launch chrome, open New incognito window and navigate to chrome://md-settings observe.  

Browser gets crashed after navigating to chrome://md-settings page in incognito mode.

Crash ID eab85b4c00000000 (d1e84c1a-e6c7-4a84-9073-c4943fc269d1)

Browser should not crash after navigating to chrome://md-settings page in incognito window.

This is a regression issue,broken in 'M-47' ,below is bisect info:

Good Build: 47.0.2509.0
Bad Build: 47.0.2510.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/2b98b2a34b2b6f1816e8cb14dc5e2d145bc03cdc..a0024363c84aa48ee098374463a1e6a66ec8280b?pretty=fuller&n=100

Suspecting: r348826 ?


 
Actual_Crash.mp4
740 KB Download
Labels: -Proj-MaterialDesign-NativeUI Proj-MaterialDesign-WebUI

Comment 2 by dbeam@chromium.org, Apr 11 2016

Owner: tommycli@chromium.org
I assume there's no SigninManager for |profile_| while incognito?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/webui/settings/people_handler.cc&q=peoplehandler&sq=package:chromium&type=cs&l=842

Comment 3 by dbeam@chromium.org, Apr 11 2016

Cc: dbeam@chromium.org
Labels: -Pri-1 -Type-Bug-Regression OS-Chrome Pri-2 Type-Bug
Issue 602342 has been merged into this issue.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: tommycli@chromium.org
Owner: mahmadi@chromium.org
Moe: Sending this to you since it's somewhat similar to Guest Mode.

The existing behavior for Options is to redirect to the non-incognito Profile and open Settings.
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 14 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: mahmadi@chromium.org
 Issue 607775  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f06f92925b46c21ea7ef8ccbb57618e3b697336

commit 7f06f92925b46c21ea7ef8ccbb57618e3b697336
Author: mahmadi <mahmadi@chromium.org>
Date: Wed Jul 20 09:08:35 2016

Makes chrome://md-settings an invalid URL in incognito mode

BUG= 602211 

Review-Url: https://codereview.chromium.org/2158353002
Cr-Commit-Position: refs/heads/master@{#406522}

[modify] https://crrev.com/7f06f92925b46c21ea7ef8ccbb57618e3b697336/chrome/browser/ui/browser_navigator.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 8697.0.0, 54.0.2826.0

Sign in to add a comment