bluetooth: Crash when scanning for Bluetooth devices |
||||||||
Issue descriptionIMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it. Chrome Version: 51.0.2700.2 Operating System: Android 6.0.1 URL (if applicable) where crash occurred: https://beaufortfrancois.github.io/sandbox/web-bluetooth/ihealth-edge/ Can you reproduce this crash? 100% What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?) 1. Click on the "Click" button 2. Wait... 3. Chrome Dev crashes. ****DO NOT CHANGE BELOW THIS LINE**** Crash ID: crash/d6ebbb4c00000000
,
Apr 11 2016
Argh. This is probably http://crrev.com/1828193002 I'll fix it.
,
Apr 12 2016
WIP at https://codereview.chromium.org/1876753004/ Thank you Giovanni!
,
Apr 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baefa2c7c7188832268e60b063103673edf8a34f commit baefa2c7c7188832268e60b063103673edf8a34f Author: ortuno <ortuno@chromium.org> Date: Tue Apr 12 17:34:13 2016 bluetooth: Check if device name is null before trying to convert Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes when passed in null. To avoid that we first check if the name returned by android is null and if so return an empty string. BUG= 602189 Review URL: https://codereview.chromium.org/1876753004 Cr-Commit-Position: refs/heads/master@{#386733} [modify] https://crrev.com/baefa2c7c7188832268e60b063103673edf8a34f/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/baefa2c7c7188832268e60b063103673edf8a34f/device/bluetooth/bluetooth_device_android.cc [modify] https://crrev.com/baefa2c7c7188832268e60b063103673edf8a34f/device/bluetooth/bluetooth_device_unittest.cc [modify] https://crrev.com/baefa2c7c7188832268e60b063103673edf8a34f/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java [modify] https://crrev.com/baefa2c7c7188832268e60b063103673edf8a34f/device/bluetooth/test/bluetooth_test.h
,
Apr 13 2016
Giovanni, should we request a merge for M51?
,
Apr 13 2016
Yes. I wanted to wait a week before asking for a merge request.
,
Apr 14 2016
You only need to wait for a canary release, rather than a whole week: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/sSpOLg4qVD0/discussion
,
Apr 14 2016
There is no canary for Android though.
,
Apr 18 2016
,
Apr 19 2016
,
Apr 19 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da2f05663a306485d1a846267c6d65519387c5af commit da2f05663a306485d1a846267c6d65519387c5af Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Apr 19 16:16:20 2016 bluetooth: Check if device name is null before trying to convert Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes when passed in null. To avoid that we first check if the name returned by android is null and if so return an empty string. BUG= 602189 Review URL: https://codereview.chromium.org/1876753004 Cr-Commit-Position: refs/heads/master@{#386733} (cherry picked from commit baefa2c7c7188832268e60b063103673edf8a34f) Review URL: https://codereview.chromium.org/1897873003 . Cr-Commit-Position: refs/branch-heads/2704@{#124} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/da2f05663a306485d1a846267c6d65519387c5af/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/da2f05663a306485d1a846267c6d65519387c5af/device/bluetooth/bluetooth_device_android.cc [modify] https://crrev.com/da2f05663a306485d1a846267c6d65519387c5af/device/bluetooth/bluetooth_device_unittest.cc [modify] https://crrev.com/da2f05663a306485d1a846267c6d65519387c5af/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java [modify] https://crrev.com/da2f05663a306485d1a846267c6d65519387c5af/device/bluetooth/test/bluetooth_test.h
,
Apr 19 2016
,
Apr 23 2016
Issue 602015 has been merged into this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by fbeaufort@chromium.org
, Apr 11 2016