Issue 602183 link

Starred by 4 users

Issue metadata

Status:	Fixed
Merged:	issue 603405
Owner:	est...@chromium.org
Closed:	Apr 2016
Cc:	ajha@chromium.org █ kavvaru@chromium.org nyerramilli@chromium.org est...@chromium.org █ rnimmagadda@chromium.org █ durga.behera@chromium.org
Components:	Internals>Plugins UI>Input>KeyboardShortcuts
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows
Pri:	1
Type:	Bug-Regression
hasbisect Hotlist-Merge-Approved ReleaseBlock-Stable M-51 merge-merged-2704 merge-merged-2716

Regression:Plugins block bubble doesn't open after hitting spacebar key from keyboard.

Reported by vku...@etouch.net, Apr 11 2016

Issue description

Chrome Version:52.0.2705.0 (Official Build)Revision fefaf92686d3786bd74fbda74d7dff3ca2f49e3e-refs/heads/master@{#386318}(32/64-bit)
OS:Windows

What steps will reproduce the problem?
1.Launch chrome and navigate to chrome://settings/content , click on "let me choose when to run.." option under Plugin section.
2.Navigate to vudu.com click on any video such that plugin block bubble appears in omnibox,close the video.
3.Press 'F6' key such that focus(black highlight) appears on omnibox, hit tab key and press 'space-bar' key to open plugins block bubble,observe

Actual: Plugins block bubble doesn't open after hitting spacebar key from keyboard.

Expected: Plugins block bubble should open after hitting spacebar key from keyboard.

This is a regression issue broken in 'M51' and will soon update other info.

Comment 1 by vku...@etouch.net, Apr 11 2016

Components: -IO>Keyboard UI>Input>KeyboardShortcuts
Labels: hasbisect OS-Linux
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)

Manual regression range:
Good build: 51.0.2702.0 
Bad Build: 51.0.2703.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/9d1960a45d22938a3deb641657d8e21f5ff7b76b..0c6faeb81f1461952b5c63ad33e9fccc021a0c95?pretty=fuller&n=30

Suspecting: 385829 ?
Kindly help to re-assign, if your changes are not cause for this issue.

Note: Issue not seen on Mac OS.

Actual_Plugins.mp4
666 KB Download

Expected_Plugins.mp4
546 KB Download

Comment 2 by nyerramilli@chromium.org, Apr 11 2016

Labels: ReleaseBlock-Stable

adding RB-label, please change if required.

Comment 3 by est...@chromium.org, Apr 14 2016

Status: Started (was: Assigned)

Comment 4 by kavvaru@chromium.org, Apr 22 2016

Just to update, still able to reproduce the issue on windows 7 using chrome latest canary 52.0.2715.0.

Comment 5 by est...@chromium.org, Apr 24 2016

Mergedinto: 603405
Status: Duplicate (was: Started)

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad2c35565eebbe4318c7a2ed950200b63599edf0

commit ad2c35565eebbe4318c7a2ed950200b63599edf0
Author: estade <estade@chromium.org>
Date: Sun Apr 24 18:39:01 2016

Change ContentSettingImageView activation to key release

And standardize all BubbleIconViews as well: instead of activating on key down, activate on key up. This matches buttons (such as the toolbar buttons) and the ev cert icon.

Showing the bubble on key down means that the key up activates the newly-focused
"done" button.

BUG= 602183 

Review URL: https://codereview.chromium.org/1886943002

Cr-Commit-Position: refs/heads/master@{#389406}

[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/location_icon_view.h

Comment 7 by est...@chromium.org, Apr 25 2016

Labels: Merge-Request-51
Status: Fixed (was: Duplicate)

Comment 8 by est...@chromium.org, Apr 25 2016

Cc: est...@chromium.org durga.behera@chromium.org rnimmagadda@chromium.org ajha@chromium.org kavvaru@chromium.org

 Issue 603405  has been merged into this issue.

Comment 9 by tin...@google.com, Apr 25 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M51 (branch: 2704)

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad2c35565eebbe4318c7a2ed950200b63599edf0

commit ad2c35565eebbe4318c7a2ed950200b63599edf0
Author: estade <estade@chromium.org>
Date: Sun Apr 24 18:39:01 2016

Change ContentSettingImageView activation to key release

And standardize all BubbleIconViews as well: instead of activating on key down, activate on key up. This matches buttons (such as the toolbar buttons) and the ev cert icon.

Showing the bubble on key down means that the key up activates the newly-focused
"done" button.

BUG= 602183 

Review URL: https://codereview.chromium.org/1886943002

Cr-Commit-Position: refs/heads/master@{#389406}

[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/ad2c35565eebbe4318c7a2ed950200b63599edf0/chrome/browser/ui/views/location_bar/location_icon_view.h

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 25 2016

Labels: -merge-approved-51 merge-merged-2704

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9889f315910943a9f224d9499738b2c0f1fa9417

commit 9889f315910943a9f224d9499738b2c0f1fa9417
Author: Evan Stade <estade@chromium.org>
Date: Mon Apr 25 20:53:25 2016

Change ContentSettingImageView activation to key release

And standardize all BubbleIconViews as well: instead of activating on key down, activate on key up. This matches buttons (such as the toolbar buttons) and the ev cert icon.

Showing the bubble on key down means that the key up activates the newly-focused
"done" button.

BUG= 602183 

Review URL: https://codereview.chromium.org/1886943002

Cr-Commit-Position: refs/heads/master@{#389406}
(cherry picked from commit ad2c35565eebbe4318c7a2ed950200b63599edf0)

Review URL: https://codereview.chromium.org/1915063003 .

Cr-Commit-Position: refs/branch-heads/2704@{#226}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/9889f315910943a9f224d9499738b2c0f1fa9417/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/9889f315910943a9f224d9499738b2c0f1fa9417/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/9889f315910943a9f224d9499738b2c0f1fa9417/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/9889f315910943a9f224d9499738b2c0f1fa9417/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/9889f315910943a9f224d9499738b2c0f1fa9417/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/9889f315910943a9f224d9499738b2c0f1fa9417/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/9889f315910943a9f224d9499738b2c0f1fa9417/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/9889f315910943a9f224d9499738b2c0f1fa9417/chrome/browser/ui/views/location_bar/location_icon_view.h

►

Issue 602183 link

Issue metadata

Regression:Plugins block bubble doesn't open after hitting spacebar key from keyboard.

Issue description

Comment 1 by vku...@etouch.net, Apr 11 2016

Comment 1 Deleted

Comment 2 by nyerramilli@chromium.org, Apr 11 2016

Comment 2 Deleted

Comment 3 by est...@chromium.org, Apr 14 2016

Comment 3 Deleted

Comment 4 by kavvaru@chromium.org, Apr 22 2016

Comment 4 Deleted

Comment 5 by est...@chromium.org, Apr 24 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Apr 24 2016

Comment 6 Deleted

Comment 7 by est...@chromium.org, Apr 25 2016

Comment 7 Deleted

Comment 8 by est...@chromium.org, Apr 25 2016

Comment 8 Deleted

Comment 9 by tin...@google.com, Apr 25 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Apr 25 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Apr 25 2016

Comment 11 Deleted

Sign in to add a comment