New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 602166 link

Starred by 2 users
Status: Duplicate
Merged: issue 600911
Owner:
msw@chromium.org
Closed: Apr 2016
Cc:
drinkcat@chromium.org
oak-mtk@chromium.org
msw@chromium.org
sky@chromium.org
█ zelidrag@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

UI: At login screen, clock/battery/keyboard are at top left corner of screen instead of on shelf

Project Member Reported by djkurtz@chromium.org, Apr 11 2016 
Chrome Version: 51.0.2701.0
Chrome OS Version: 8157.0.0
Chrome OS Platform: samus (also oak)

Steps To Reproduce:
(1) Boot machine to login screen
(2) Look at the time
(3)

Expected Result:

clock/battery/keyboard status should be in the shelf at bottom right.

Actual Result:

clock/battery/keyboard status are at upper left of login screen.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

Always.

What is the impact to the user, and is there a workaround? If so, what is
it?

Clock/battery/keyboard are at wrong position.

Please provide any additional information below. Attach a screen shot or
log if possible.

Also, the clock appears to move around sometimes; I think it followed the pointer when logging in.

After login, the clock did return to its proper place.

This bug is forked from crosbug.com/p/52195, which also contains a picture and logs for those with access.

Comment 1 by djkurtz@chromium.org, Apr 11 2016 

I did a Chrome OS bisect, and the issue appears between
8156.0.0 and 8157.0.0
https://crosland.corp.google.com/log/8156.0.0..8157.0.0

This corresponds to Chrome versions:
51.0.2700.0 and 51.0.2701.0
https://chromium.googlesource.com/chromium/src/+log/51.0.2700.0..51.0.2701.0?pretty=fuller&n=10000

Comment 2 by djkurtz@chromium.org, Apr 11 2016

Cc: msw@chromium.org sky@chromium.org
$ git bisect bad
174379b507800b1fd819bb8907644682e9a6302a is the first bad commit
commit 174379b507800b1fd819bb8907644682e9a6302a
Author: msw <msw@chromium.org>
Date:   Mon Apr 4 17:25:11 2016 -0700

    Cleanup shelf initialization and observation.
    
    Add ShelfDelegate::OnShelf[Alignment|AutoHideBehavior]Changed.
    (needed for mus: https://codereview.chromium.org/1839223003)
    (simplifies ChromeLauncherController shelf observation)
    
    Remove ShelfLayoutManagerObserver::OnAutoHideBehaviorChanged.
    Add Shell[Observer]::OnShelfAutoHideBehaviorChanged
    (similar to alignment calls, used for ShelfLayoutManager)
    
    Move alignment and auto-hide properties to Shelf class.
    (lets us better encapsulate ShelfLayoutManager)
    
    Simplify Shell functions that access shelf properties.
    Init Shell's ShelfModel earlier (removes ordering constraint).
    Call OnShelfCreated after ShelfWidget::shelf_ is actually set.
    
    Make ChromeLauncherController set properties in OnShelfCreated.
    (not before the actual shelf exists; update tests similarly)
    Skip redundant *FromPrefs init; see SetShelfBehaviorsFromPrefs.
    Inline SetShelfAutoHideBehaviorPrefs (like alignment).
    
    BUG= 557406 
    TEST=No regressions
    R=sky@chromium.org
    
    Review URL: https://codereview.chromium.org/1851883002
    
    Cr-Commit-Position: refs/heads/master@{#385060}

:040000 040000 1d1d70c2272bd428fbd2c2a5adfeb8e7888e857a faa1caca2b7aaf8d63ade830e88e728732f28cb2 M	ash
:040000 040000 a888635b63cb84e1a213b4ab95046ea3c91b777e 7cfe042d17f5a16ee97bcda9142f374536305289 M	chrome

Comment 3 by djkurtz@chromium.org, Apr 11 2016

Owner: msw@chromium.org

Comment 4 by msw@chromium.org, Apr 11 2016

Mergedinto: 600911
Status: Duplicate (was: Assigned)
►

Sign in to add a comment