New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 602158 link

Starred by 3 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Apr 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
nyerramilli@chromium.org
█ brajkumar@chromium.org
est...@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Outline of download bar is not displayed properly.

Reported by vku...@etouch.net, Apr 11 2016 
Chrome Version:51.0.2704.2 (Official Build)Revision 489770a09a889f83c47c5e4b7df7a8865e5d4070-refs/branch-heads/2704@{#2} (32/64-bit)
OS:Windows

Precondition: Select 'Material' option for 'Material design in the browser's top chrome'.

What steps will reproduce the problem?
1.Launch chrome and navigate to http://mirror.internode.on.net/pub/test/
2.Click on any file to download and observe the download bar at bottom of page.

Actual: Outline of download bar is not displayed properly.

Expected: Outline of download bar should be completely visible.

This is a regression issue broken in 'M51' and will soon update other info,

Comment 1 by vku...@etouch.net, Apr 11 2016

Labels: hasbisect OS-Linux
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good build: 51.0.2702.0 
Bad Build: 51.0.2703.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/c3074fbaf4ed55a4ebae511cb2bc943d0af532f9..7aa721b7686190cafdf7e4441c0224fea3c40516?pretty=fuller&n=30

Suspecting: r385877 

Note: Issue not seen on Mac OS.
Actual_Download.png
143 KB View Download
Expected_Download.png
174 KB View Download

Comment 2 by nyerramilli@chromium.org, Apr 11 2016

Cc: est...@chromium.org durga.behera@chromium.org ajha@chromium.org kavvaru@chromium.org brajkumar@chromium.org
 Issue 602160  has been merged into this issue.

Comment 3 by est...@chromium.org, Apr 11 2016

Status: Started (was: Assigned)
should be fixed by https://codereview.chromium.org/1860163003/, which I forgot about till now.

Comment 4 by est...@chromium.org, Apr 11 2016

Labels: -OS-Windows ReleaseBlock-Stable
only affects linux in default config (i.e. without special flags)

Comment 5 by tdander...@chromium.org, Apr 11 2016

Labels: Proj-MaterialDesign-NativeUI

Comment 7 by est...@chromium.org, Apr 12 2016

Labels: Merge-Request-51

Comment 8 by tin...@google.com, Apr 12 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 13 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6398b318bf448c02977a29346a5baf6dc0f0036

commit a6398b318bf448c02977a29346a5baf6dc0f0036
Author: Evan Stade <estade@chromium.org>
Date: Wed Apr 13 20:13:31 2016

Use MD-style focus indicator on DL shelf items.

TEST=Press F6 until a download item is focused.
BUG= 538172 , 602158 

Review URL: https://codereview.chromium.org/1860163003

Cr-Commit-Position: refs/heads/master@{#386509}
(cherry picked from commit c61557028637fa564d3fb64eb91d019e98f3982b)

Review URL: https://codereview.chromium.org/1885143002 .

Cr-Commit-Position: refs/branch-heads/2704@{#34}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/a6398b318bf448c02977a29346a5baf6dc0f0036/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/a6398b318bf448c02977a29346a5baf6dc0f0036/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/a6398b318bf448c02977a29346a5baf6dc0f0036/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/a6398b318bf448c02977a29346a5baf6dc0f0036/ui/views/controls/button/custom_button.h

Comment 10 by est...@chromium.org, Apr 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment