Several people have requested that we add about:flags support so they can try out the experimental feature to block the load of doc.written scripts.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed75dc7053dc072bdd0e72f64a869d59ec587f4b commit ed75dc7053dc072bdd0e72f64a869d59ec587f4b Author: bmcquade <bmcquade@chromium.org> Date: Tue Apr 12 19:41:23 2016 Add about:flags support for doc.write script blocking. This patch introduces an additional blink setting which allows us to enable blocking only on slow (2G) connections, or on all connections. This is consistent with the 2G web font intervention, which has a feature for enabling on 2G, and an additional feature to force the intervention on in all connection types. We then add support for enabling the setting that enables blocking on all connection types from about:flags. This change also removes about:flags support from the now discontinued low priority iframe experiment, since it's nontrivial to add support for multiple blink settings in about:flags. BUG= 602137 Review URL: https://codereview.chromium.org/1868413002 Cr-Commit-Position: refs/heads/master@{#386769} [modify] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/chrome/app/generated_resources.grd [modify] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/chrome/browser/about_flags.cc [modify] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html [add] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types-expected.txt [add] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types.html [modify] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html [modify] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html [modify] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/third_party/WebKit/Source/core/frame/Settings.in [modify] https://crrev.com/ed75dc7053dc072bdd0e72f64a869d59ec587f4b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
Your change meets the bar and is auto-approved for M51 (branch: 2704)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afcacf06e0bf288ec36b567c454b52764b681fed commit afcacf06e0bf288ec36b567c454b52764b681fed Author: Josh Karlin <jkarlin@chromium.org> Date: Wed Apr 13 19:14:59 2016 This is a merge into M51 branch 2704. Add about:flags support for doc.write script blocking. This patch introduces an additional blink setting which allows us to enable blocking only on slow (2G) connections, or on all connections. This is consistent with the 2G web font intervention, which has a feature for enabling on 2G, and an additional feature to force the intervention on in all connection types. We then add support for enabling the setting that enables blocking on all connection types from about:flags. This change also removes about:flags support from the now discontinued low priority iframe experiment, since it's nontrivial to add support for multiple blink settings in about:flags. BUG= 602137 TBR=japhet@chromium.org Review URL: https://codereview.chromium.org/1868413002 Cr-Commit-Position: refs/heads/master@{#386769} (cherry picked from commit ed75dc7053dc072bdd0e72f64a869d59ec587f4b) Review URL: https://codereview.chromium.org/1890573002 . Cr-Commit-Position: refs/branch-heads/2704@{#33} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/chrome/app/generated_resources.grd [modify] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/chrome/browser/about_flags.cc [modify] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html [add] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types-expected.txt [add] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types.html [modify] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html [modify] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html [modify] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/third_party/WebKit/Source/core/frame/Settings.in [modify] https://crrev.com/afcacf06e0bf288ec36b567c454b52764b681fed/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
Comment 1 by bmcquade@chromium.org
, Apr 11 2016