New issue
Advanced search Search tips

Issue 602134 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Domain with Reader Mode usage should be anonymously collected

Project Member Reported by wychen@chromium.org, Apr 11 2016

Issue description

We should anonymously collect domain names where Reader Mode is used.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/388989c6665e2e46749eead442ffc942562d6e7b

commit 388989c6665e2e46749eead442ffc942562d6e7b
Author: wychen <wychen@chromium.org>
Date: Sun Apr 17 09:01:14 2016

Record domains where Reader Mode is prompted or opened

Use RAPPOR to anonymously record the domains in two cases:
1. Reader Mode panel is prompted
   In AdaBoost heuristic, this means the page is distillable.
2. Reader Mode panel is opened by the user

BUG= 602134 

Review URL: https://codereview.chromium.org/1873073002

Cr-Commit-Position: refs/heads/master@{#387830}

[modify] https://crrev.com/388989c6665e2e46749eead442ffc942562d6e7b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
[modify] https://crrev.com/388989c6665e2e46749eead442ffc942562d6e7b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/388989c6665e2e46749eead442ffc942562d6e7b/tools/metrics/rappor/rappor.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dd3c54659c4e99b4ba31254fed0094defd4ffd1

commit 8dd3c54659c4e99b4ba31254fed0094defd4ffd1
Author: wychen <wychen@chromium.org>
Date: Sun Apr 17 09:01:49 2016

Record domains where Reader Mode is prompted or opened

Use RAPPOR to anonymously record the domains in two cases:
1. Reader Mode panel is prompted
   In AdaBoost heuristic, this means the page is distillable.
2. Reader Mode panel is opened by the user

BUG= 602134 

Review URL: https://codereview.chromium.org/1873073002

Cr-Commit-Position: refs/heads/master@{#387831}

[modify] https://crrev.com/8dd3c54659c4e99b4ba31254fed0094defd4ffd1/tools/metrics/rappor/rappor.xml

Comment 3 by wychen@chromium.org, Apr 20 2016

Labels: Merge-Request-51
Status: Verified (was: Untriaged)

Comment 4 by wychen@chromium.org, Apr 20 2016

Cc: mdjones@chromium.org

Comment 5 by tin...@google.com, Apr 20 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Owner: wychen@chromium.org
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 6 by gov...@chromium.org, Apr 20 2016

Please merge your change to M51 branch 2704 before 5:00 PM PST today so we can take it for today's M51 Beta candidate cut. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c20fb9c0e07606b4667c60762cfcbcf9273602bb

commit c20fb9c0e07606b4667c60762cfcbcf9273602bb
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Wed Apr 20 19:24:23 2016

Record domains where Reader Mode is prompted or opened

Use RAPPOR to anonymously record the domains in two cases:
1. Reader Mode panel is prompted
   In AdaBoost heuristic, this means the page is distillable.
2. Reader Mode panel is opened by the user

BUG= 602134 

Review URL: https://codereview.chromium.org/1873073002

Cr-Commit-Position: refs/heads/master@{#387831}
(cherry picked from commit 8dd3c54659c4e99b4ba31254fed0094defd4ffd1)

Review URL: https://codereview.chromium.org/1897153006 .

Cr-Commit-Position: refs/branch-heads/2704@{#151}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/c20fb9c0e07606b4667c60762cfcbcf9273602bb/tools/metrics/rappor/rappor.xml

Comment 8 by wychen@chromium.org, Apr 20 2016

There was an incident. The commit bot landed the original CL twice (388989c6665e2e46749eead442ffc942562d6e7b correctly, and then 8dd3c54659c4e99b4ba31254fed0094defd4ffd1 again, making the xml file malformed). I didn't noticed this until cherry-picking the CL to 2704 and found that only the xml file is modified.

I'll land a reversion of 8dd3c54659c4e99b4ba31254fed0094defd4ffd1 in master, revert c20fb9c0e07606b4667c60762cfcbcf9273602bb as well, and cherry-pick 388989c6665e2e46749eead442ffc942562d6e7b.

Comment 9 by wychen@chromium.org, Apr 20 2016

When cherry-picking 388989c6665e2e46749eead442ffc942562d6e7b, c20fb9c0e07606b4667c60762cfcbcf9273602bb is absorbed correctly, so no need to revert c20fb9c0e07606b4667c60762cfcbcf9273602bb on the branch.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a968ab314538464420465fa8dfdfaacedaa30b47

commit a968ab314538464420465fa8dfdfaacedaa30b47
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Wed Apr 20 21:15:51 2016

Record domains where Reader Mode is prompted or opened

Use RAPPOR to anonymously record the domains in two cases:
1. Reader Mode panel is prompted
   In AdaBoost heuristic, this means the page is distillable.
2. Reader Mode panel is opened by the user

BUG= 602134 

Review URL: https://codereview.chromium.org/1873073002

Cr-Commit-Position: refs/heads/master@{#387830}
(cherry picked from commit 388989c6665e2e46749eead442ffc942562d6e7b)

Review URL: https://codereview.chromium.org/1911593002 .

Cr-Commit-Position: refs/branch-heads/2704@{#153}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/a968ab314538464420465fa8dfdfaacedaa30b47/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
[modify] https://crrev.com/a968ab314538464420465fa8dfdfaacedaa30b47/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df24db2cac5d2a6d861beb266b5509cc9565edb7

commit df24db2cac5d2a6d861beb266b5509cc9565edb7
Author: wychen <wychen@chromium.org>
Date: Thu Apr 21 19:32:58 2016

Revert duplication of "Record domains where Reader Mode is prompted or opened"

This reverts commit 8dd3c54659c4e99b4ba31254fed0094defd4ffd1.

The commit bot wrongly landed https://codereview.chromium.org/1873073002/
twice, but only partially for the second time. This is fixed here.

BUG= 602134 

Review URL: https://codereview.chromium.org/1905533004

Cr-Commit-Position: refs/heads/master@{#388849}

[modify] https://crrev.com/df24db2cac5d2a6d861beb266b5509cc9565edb7/tools/metrics/rappor/rappor.xml

Sign in to add a comment