Domain with Reader Mode usage should be anonymously collected |
|||||
Issue descriptionWe should anonymously collect domain names where Reader Mode is used.
,
Apr 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8dd3c54659c4e99b4ba31254fed0094defd4ffd1 commit 8dd3c54659c4e99b4ba31254fed0094defd4ffd1 Author: wychen <wychen@chromium.org> Date: Sun Apr 17 09:01:49 2016 Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG= 602134 Review URL: https://codereview.chromium.org/1873073002 Cr-Commit-Position: refs/heads/master@{#387831} [modify] https://crrev.com/8dd3c54659c4e99b4ba31254fed0094defd4ffd1/tools/metrics/rappor/rappor.xml
,
Apr 20 2016
,
Apr 20 2016
,
Apr 20 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 20 2016
Please merge your change to M51 branch 2704 before 5:00 PM PST today so we can take it for today's M51 Beta candidate cut. Thank you.
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c20fb9c0e07606b4667c60762cfcbcf9273602bb commit c20fb9c0e07606b4667c60762cfcbcf9273602bb Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Wed Apr 20 19:24:23 2016 Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG= 602134 Review URL: https://codereview.chromium.org/1873073002 Cr-Commit-Position: refs/heads/master@{#387831} (cherry picked from commit 8dd3c54659c4e99b4ba31254fed0094defd4ffd1) Review URL: https://codereview.chromium.org/1897153006 . Cr-Commit-Position: refs/branch-heads/2704@{#151} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/c20fb9c0e07606b4667c60762cfcbcf9273602bb/tools/metrics/rappor/rappor.xml
,
Apr 20 2016
There was an incident. The commit bot landed the original CL twice (388989c6665e2e46749eead442ffc942562d6e7b correctly, and then 8dd3c54659c4e99b4ba31254fed0094defd4ffd1 again, making the xml file malformed). I didn't noticed this until cherry-picking the CL to 2704 and found that only the xml file is modified. I'll land a reversion of 8dd3c54659c4e99b4ba31254fed0094defd4ffd1 in master, revert c20fb9c0e07606b4667c60762cfcbcf9273602bb as well, and cherry-pick 388989c6665e2e46749eead442ffc942562d6e7b.
,
Apr 20 2016
When cherry-picking 388989c6665e2e46749eead442ffc942562d6e7b, c20fb9c0e07606b4667c60762cfcbcf9273602bb is absorbed correctly, so no need to revert c20fb9c0e07606b4667c60762cfcbcf9273602bb on the branch.
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a968ab314538464420465fa8dfdfaacedaa30b47 commit a968ab314538464420465fa8dfdfaacedaa30b47 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Wed Apr 20 21:15:51 2016 Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG= 602134 Review URL: https://codereview.chromium.org/1873073002 Cr-Commit-Position: refs/heads/master@{#387830} (cherry picked from commit 388989c6665e2e46749eead442ffc942562d6e7b) Review URL: https://codereview.chromium.org/1911593002 . Cr-Commit-Position: refs/branch-heads/2704@{#153} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/a968ab314538464420465fa8dfdfaacedaa30b47/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java [modify] https://crrev.com/a968ab314538464420465fa8dfdfaacedaa30b47/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df24db2cac5d2a6d861beb266b5509cc9565edb7 commit df24db2cac5d2a6d861beb266b5509cc9565edb7 Author: wychen <wychen@chromium.org> Date: Thu Apr 21 19:32:58 2016 Revert duplication of "Record domains where Reader Mode is prompted or opened" This reverts commit 8dd3c54659c4e99b4ba31254fed0094defd4ffd1. The commit bot wrongly landed https://codereview.chromium.org/1873073002/ twice, but only partially for the second time. This is fixed here. BUG= 602134 Review URL: https://codereview.chromium.org/1905533004 Cr-Commit-Position: refs/heads/master@{#388849} [modify] https://crrev.com/df24db2cac5d2a6d861beb266b5509cc9565edb7/tools/metrics/rappor/rappor.xml |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 17 2016