Issue metadata
Sign in to add a comment
|
HitTesting should account for border-radius on images |
||||||||||||||||||||
Issue descriptionWe should do hitTest the element under the rounded border of the missed image when hitting it. According to #36 comment at https://codereview.chromium.org/1657483003, we reverted a just inherit part. And hittesting/border-hittest-with-image-fallback.html is broken after reverting it. We will solve this issue without the border radius's inherit and remove the TC's failure expectation in TestExpectations.
,
Oct 12 2016
myid.shin@, are you planning on fixing this? If not, make it Available.
,
Jan 31 2017
,
Feb 21 2017
schenney@, I'm so sorry for my late response. I could hardly find extra time for myself. I just tested this with the latest chromium-dev, it still has the problem. I think someone who knows well layout takes a look better. If I take time back and this is the same status, I will dig out this deeply.
,
Mar 31 2017
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/858bfb659e50d2d2debebd92847c59b884848ae4 commit 858bfb659e50d2d2debebd92847c59b884848ae4 Author: schenney <schenney@chromium.org> Date: Wed Apr 05 21:52:46 2017 Move Paint Team TestExpectations lines into appropriate sections This completes a review of all the Paint Team owned layout test failures. With this patch tests are grouped so we know which ones might be worth investigating in the future and so we can more easily incorporate new failures. There is one outstanding patch to be comnitted rebasing one set of tests. TBR=chrishtr@chromium.org BUG=309675,504613, 517449 , 549742 , 602110 , 606302 ,614910, 676561 Review-Url: https://codereview.chromium.org/2803633005 Cr-Commit-Position: refs/heads/master@{#462231} [modify] https://crrev.com/858bfb659e50d2d2debebd92847c59b884848ae4/third_party/WebKit/LayoutTests/NeverFixTests [modify] https://crrev.com/858bfb659e50d2d2debebd92847c59b884848ae4/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 15 2017
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ea62164a55064489614aa0a038743b8419c2312 commit 8ea62164a55064489614aa0a038743b8419c2312 Author: Stephen Chenney <schenney@chromium.org> Date: Thu Aug 17 19:37:00 2017 Add PointerEvents:None for fallback image shadow tree Hit testing on the shadow tree for a missing image does not respect the border radius style on the image. But in practice you should not be able to hit internal details of the image fallback shadow DOM - the hit testing code returns the owning image anyway.So make the image fallback container ignore pointer events. R=pdr@chromium.org BUG= 602110 Change-Id: Iec4d5488b8c2ff31125939f83340bc842e66155a Reviewed-on: https://chromium-review.googlesource.com/618849 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#495282} [modify] https://crrev.com/8ea62164a55064489614aa0a038743b8419c2312/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/8ea62164a55064489614aa0a038743b8419c2312/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp
,
Aug 17 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by myid.shin@chromium.org
, Apr 10 2016