New issue
Advanced search Search tips

Issue 602056 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Chromevox does not read web application menus

Reported by nimerjaber1@gmail.com, Apr 10 2016

Issue description

Chromevox Next does not read the menus found in web applications. To reproduce, please do the following:
1. Navigate to docs.google.com
2. Press alt+f to access the file menu.
3. Press down arrow to access the menu.
Expected behavior: Chromevox reads out the contents of the file menu
Actual Behavior: Chromevox reads out options from the toolbar I believe however it does not read out the contents of the menu.Mode: force_next
Version: 51.0.2701.0
Reproduction Steps: 
1.
2.
3.


 
Cc: lpalmaro@chromium.org dtseng@chromium.org
Status: Untriaged (was: Unconfirmed)
Happens on 51.0.2704.0 version

Comment 2 by dtseng@chromium.org, Apr 14 2016

Cc: dmazz...@chromium.org
Status: available (was: Untriaged)
This one's known.

Dominic, any thoughts about the live region support in Next? This issue  is due to subtree changes triggering live region updates. When arrowing through the options, one hears "you are online...<menu name>".

Comment 3 by dtseng@chromium.org, May 13 2016

Owner: dtseng@chromium.org
Status: started (was: Available)

Comment 4 by dtseng@chromium.org, May 13 2016

 Issue 597897  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54e747470a4de1c2437556581c3a1abd63e6a423

commit 54e747470a4de1c2437556581c3a1abd63e6a423
Author: dtseng <dtseng@chromium.org>
Date: Tue May 17 23:20:29 2016

Correctly ignore AXTree event creation change state for reparented nodes

When updating an AXTree with a node_id_to_clear, we were adding a node created change for nodes that were removed, then created (a "recreation"). In the source tree though, however, the node was simply reparented (see test).

During deserialization, we first destroyed the node subtree; then, we updated nodes; finally, we sent node created/changed/subtree created based on the update node calls.

In order to detect this case at the unserialized tree phase of the update, introduce a vector to keep track of all nodes removed. A created node is then a new node that is not also a removed node.

Furthermore, a onNodeDataWillChange should not be called for newly created or reparented nodes. This is because during node updates, a node and its *children* are built. The children are not yet populated with data. As a result, we often called onNodeDataWillChange on nodes whose previous data is simply not yet initialized. This caused erroneous tree text change events.

TEST=accessibility_unittest, read Google Docs menus in ChromeVox
BUG= 602056 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1978373002
Cr-Commit-Position: refs/heads/master@{#394267}

[modify] https://crrev.com/54e747470a4de1c2437556581c3a1abd63e6a423/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
[modify] https://crrev.com/54e747470a4de1c2437556581c3a1abd63e6a423/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/54e747470a4de1c2437556581c3a1abd63e6a423/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/54e747470a4de1c2437556581c3a1abd63e6a423/ui/accessibility/ax_tree.h
[modify] https://crrev.com/54e747470a4de1c2437556581c3a1abd63e6a423/ui/accessibility/ax_tree_unittest.cc

Comment 6 by dtseng@chromium.org, May 17 2016

Status: FIXED (was: Started)
Labels: VerifyIn-52
Status: Verified (was: Fixed)
verified on 52.0.2739.0

Comment 9 by chaok@google.com, Jun 25 2016

This regressed in:
Version 53.0.2773.0 dev (64-bit)

Repro Steps:
1. Drive/
2. C for create menu
3. DOWN ARROW

Observed:
SIlence

Expected:
FOcused menu items to be uttered

Comment 10 by chaok@google.com, Jul 8 2016

Drive Create Menu still doesn't read with ChromeVox Next  in:
54.0.2787.0
From what I remember this is a bug in Drive.
I had to investigate the same issue when trying to make that menu work with Windows screen readers in Chrome. Something wrong with the ARIA attributes and HTML markup.
Nah, the bug is in Blink; fixed by:
https://codereview.chromium.org/2072503002/patch/20001/30003

which I haven't been able to land because I don't have a Mac setup (yet) for development and I'm running into layout test failures...
Btw, Kevin, you mixed up the original repro with another repro on this bug. Different repros entirely (even though it may seem the same).


Comment 14 by chaok@google.com, Jul 8 2016

#0 is fixed in: 54.0.2787.0
Docs Menu traverse/utter fine.

Sign in to add a comment