New issue
Advanced search Search tips

Issue 602042 link

Starred by 2 users
Status: Fixed
Owner:
btolsch@chromium.org
Closed: Apr 2016
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] Whitespace below search input not consistent when no devices.

Project Member Reported by apaci...@chromium.org, Apr 9 2016 
51.0.2700.0 canary

1. On a network with no devices, open the MR dialog. Observe the whitespace below the search input.
2. Focus the search input or click on the search button. In the search view, the whitespace disappears.

The whitespace should be consistent if there are no devices; there are no other UI changes and there's no reason to remove the whitespace when the rest of the dialog appears the same.

The whitespace looks fine when there's >=1 device in the list.
Screen Shot 2016-04-09 at 09.50.50.png
31.3 KB View Download
Screen Shot 2016-04-09 at 09.50.36.png
28.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd1c2db6a90b98e180fe138fb9501cf8a1b5d942

commit bd1c2db6a90b98e180fe138fb9501cf8a1b5d942
Author: btolsch <btolsch@chromium.org>
Date: Tue Apr 12 08:36:26 2016

[Media Router WebUI] Fix whitespace in filter when no devices present.

This change adds whitespace below the filter input in the filter view when there
are no devices to show for the current cast mode. In this case, the filter input
is still at the bottom of the dialog and needs to be padded as such. This change
also fixes an incorrect type annotation.

BUG= 602042 
R=apacible@chromium.org

Review URL: https://codereview.chromium.org/1874983005

Cr-Commit-Position: refs/heads/master@{#386627}

[modify] https://crrev.com/bd1c2db6a90b98e180fe138fb9501cf8a1b5d942/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/bd1c2db6a90b98e180fe138fb9501cf8a1b5d942/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Comment 2 by btolsch@chromium.org, Apr 12 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment