New issue
Advanced search Search tips

Issue 602036 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 611601



Sign in to add a comment

mus: Run widget_interactive_uitest.cc under mus

Project Member Reported by jamescook@chromium.org, Apr 9 2016

Issue description

I've tried a couple times to add widget_interactive_uitest.cc to views_mus_unittests. Here are the problems we need to work around:

WidgetTestInteractive, like most uitests, does its own initialization of GL, path provider, and resources. The views_unittests suite already does this initialization, and it can't run twice, so the tests crash. Either the initialization needs to be conditionally skipped or uitests need to run in a different test suite.

https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/widget_interactive_uitest.cc&q=widget_interactive_uitest&sq=package:chromium&l=281
vs.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/run_all_unittests.cc&q=gfx::GLSurfaceTestSupport::InitializeOneOff&sq=package:chromium&type=cs&l=29

Even if you fix the duplicate initialization several tests (around window activation) fail.

[  FAILED  ] WidgetTestInteractive.CanActivateFlagIsHonored (3550 ms)
[  FAILED  ] WidgetTestInteractive.TouchSelectionQuickMenuIsNotActivated (5056 ms)

Others time out:

[ RUN      ] WidgetTestInteractive.DisableViewDoesNotActivateWidget


 
Cc: sadrul@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
I'll take another look at this.

Blockedon: 611601
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94b68793a258e9261d1dc39cc5fdd2de673ec888

commit 94b68793a258e9261d1dc39cc5fdd2de673ec888
Author: jamescook <jamescook@chromium.org>
Date: Tue May 17 02:35:05 2016

mus: Add views_mus_interactive_ui_tests target

* Run widget_interactive_uitests.cc in the new target.
* Added a shared "test_support" target in ui/views/mus.
* Pull ViewsMusTestSuite into its own file so I can share it.
* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG= 602036 
TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere

Review-Url: https://codereview.chromium.org/1972363002
Cr-Commit-Position: refs/heads/master@{#394026}

[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/BUILD.gn
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/testing/buildbot/chromium.mojo.json
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/BUILD.gn
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/mus/BUILD.gn
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/mus/DEPS
[add] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/mus/interactive_ui_tests_manifest.json
[add] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/mus/run_all_unittests_mus.cc
[add] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/mus/views_mus_test_suite.cc
[add] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/mus/views_mus_test_suite.h
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/run_all_unittests.cc
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/run_all_unittests.h
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/test/platform_test_helper.h
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/test/scoped_views_test_helper.cc
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/test/scoped_views_test_helper.h
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/test/views_test_base.cc
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/test/views_test_base.h
[modify] https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888/ui/views/widget/widget_interactive_uitest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc8a6f1f97c20f232396d82396ee4524721c1a69

commit bc8a6f1f97c20f232396d82396ee4524721c1a69
Author: jamescook <jamescook@chromium.org>
Date: Tue May 17 03:04:08 2016

Revert of mus: Add views_mus_interactive_ui_tests target (patchset #9 id:150001 of https://codereview.chromium.org/1972363002/ )

Reason for revert:
Broke Chromium Win on Win x64 Builder (dbg)

[3415/4254] CXX obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj
FAILED: obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj
ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj.rsp /c ../../ui/views/widget/widget_interactive_uitest.cc /Foobj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj /Fd"obj/ui/views/mus/views_mus_interactive_ui_tests_cc.pdb"
c:\b\build\slave\win_x64_builder__dbg_\build\src\ui\views\widget\widget_interactive_uitest.cc(658): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder__dbg_\build\src\ui\views\widget\widget_interactive_uitest.cc(658): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

Original issue's description:
> mus: Add views_mus_interactive_ui_tests target
>
> * Run widget_interactive_uitests.cc in the new target.
> * Added a shared "test_support" target in ui/views/mus.
> * Pull ViewsMusTestSuite into its own file so I can share it.
> * Also make ViewsTestBase::IsMus static so I can call it before the
>   PlatformTestHelper is initialized.
> * Disable a bunch of tests that fail on mus (I filed bugs for them).
>
> BUG= 602036 
> TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere
>
> Committed: https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888
> Cr-Commit-Position: refs/heads/master@{#394026}

TBR=sky@chromium.org,dpranke@chromium.org,sadrul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 602036 

Review-Url: https://codereview.chromium.org/1980283002
Cr-Commit-Position: refs/heads/master@{#394033}

[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/BUILD.gn
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/testing/buildbot/chromium.mojo.json
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/BUILD.gn
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/mus/BUILD.gn
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/mus/DEPS
[delete] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/ui/views/mus/interactive_ui_tests_manifest.json
[delete] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/mus/run_all_unittests_mus.cc
[delete] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/ui/views/mus/views_mus_test_suite.cc
[delete] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/ui/views/mus/views_mus_test_suite.h
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/run_all_unittests.cc
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/run_all_unittests.h
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/test/platform_test_helper.h
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/test/scoped_views_test_helper.cc
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/test/scoped_views_test_helper.h
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/test/views_test_base.cc
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/test/views_test_base.h
[modify] https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69/ui/views/widget/widget_interactive_uitest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77

commit ba13ca8e09763be3d4a93ef3d2d495aa806ddd77
Author: jamescook <jamescook@chromium.org>
Date: Tue May 17 17:21:55 2016

Reland: mus: Add views_mus_interactive_ui_tests target

Previous attempt had a size_t to int warning on Windows, which was suppressed in chrome's interactive_ui_tests but not this new target. See https://codereview.chromium.org/1972363002/

* Run widget_interactive_uitests.cc in the new target.
* Added a shared "test_support" target in ui/views/mus.
* Pull ViewsMusTestSuite into its own file so I can share it.
* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).
* Fix an unnecessary size_t to int conversion

BUG= 602036 
TEST=views_mus_interactive_ui_tests on mus, interactive_ui_tests elsewhere
TBR=sky@chromium.org, dpranke@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/1982963002
Cr-Commit-Position: refs/heads/master@{#394153}

[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/BUILD.gn
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/testing/buildbot/chromium.mojo.json
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/BUILD.gn
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/mus/BUILD.gn
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/mus/DEPS
[add] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/mus/interactive_ui_tests_manifest.json
[add] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/mus/run_all_unittests_mus.cc
[add] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/mus/views_mus_test_suite.cc
[add] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/mus/views_mus_test_suite.h
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/run_all_unittests.cc
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/run_all_unittests.h
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/test/platform_test_helper.h
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/test/scoped_views_test_helper.cc
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/test/scoped_views_test_helper.h
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/test/views_test_base.cc
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/test/views_test_base.h
[modify] https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77/ui/views/widget/widget_interactive_uitest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78edbe6407945f0e2c8d1c7dfc873e398150ad45

commit 78edbe6407945f0e2c8d1c7dfc873e398150ad45
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 17 17:51:37 2016

Revert of Reland: mus: Add views_mus_interactive_ui_tests target (patchset #2 id:20001 of https://codereview.chromium.org/1982963002/ )

Reason for revert:
Speculative revert for compile failure on Win: https://uberchromegw.corp.google.com/i/chromium/builders/Win/builds/43482

Original issue's description:
> Reland: mus: Add views_mus_interactive_ui_tests target
>
> Previous attempt had a size_t to int warning on Windows, which was suppressed in chrome's interactive_ui_tests but not this new target. See https://codereview.chromium.org/1972363002/
>
> * Run widget_interactive_uitests.cc in the new target.
> * Added a shared "test_support" target in ui/views/mus.
> * Pull ViewsMusTestSuite into its own file so I can share it.
> * Also make ViewsTestBase::IsMus static so I can call it before the
>   PlatformTestHelper is initialized.
> * Disable a bunch of tests that fail on mus (I filed bugs for them).
> * Fix an unnecessary size_t to int conversion
>
> BUG= 602036 
> TEST=views_mus_interactive_ui_tests on mus, interactive_ui_tests elsewhere
> TBR=sky@chromium.org, dpranke@chromium.org, sadrul@chromium.org
>
> Committed: https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77
> Cr-Commit-Position: refs/heads/master@{#394153}

TBR=jamescook@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 602036 

Review-Url: https://codereview.chromium.org/1984403002
Cr-Commit-Position: refs/heads/master@{#394158}

[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/BUILD.gn
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/testing/buildbot/chromium.mojo.json
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/BUILD.gn
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/mus/BUILD.gn
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/mus/DEPS
[delete] https://crrev.com/0562edfce0c9521d38c1105f4dc7b15806746c58/ui/views/mus/interactive_ui_tests_manifest.json
[delete] https://crrev.com/0562edfce0c9521d38c1105f4dc7b15806746c58/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/mus/run_all_unittests_mus.cc
[delete] https://crrev.com/0562edfce0c9521d38c1105f4dc7b15806746c58/ui/views/mus/views_mus_test_suite.cc
[delete] https://crrev.com/0562edfce0c9521d38c1105f4dc7b15806746c58/ui/views/mus/views_mus_test_suite.h
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/run_all_unittests.cc
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/run_all_unittests.h
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/test/platform_test_helper.h
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/test/scoped_views_test_helper.cc
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/test/scoped_views_test_helper.h
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/test/views_test_base.cc
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/test/views_test_base.h
[modify] https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45/ui/views/widget/widget_interactive_uitest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d

commit 88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 17 18:02:34 2016

Reland of land: mus: Add views_mus_interactive_ui_tests target (patchset #1 id:1 of https://codereview.chromium.org/1984403002/ )

Reason for revert:
Relanding (this doesn't appear to have caused the compile failure on Win)

Original issue's description:
> Revert of Reland: mus: Add views_mus_interactive_ui_tests target (patchset #2 id:20001 of https://codereview.chromium.org/1982963002/ )
>
> Reason for revert:
> Speculative revert for compile failure on Win: https://uberchromegw.corp.google.com/i/chromium/builders/Win/builds/43482
>
> Original issue's description:
> > Reland: mus: Add views_mus_interactive_ui_tests target
> >
> > Previous attempt had a size_t to int warning on Windows, which was suppressed in chrome's interactive_ui_tests but not this new target. See https://codereview.chromium.org/1972363002/
> >
> > * Run widget_interactive_uitests.cc in the new target.
> > * Added a shared "test_support" target in ui/views/mus.
> > * Pull ViewsMusTestSuite into its own file so I can share it.
> > * Also make ViewsTestBase::IsMus static so I can call it before the
> >   PlatformTestHelper is initialized.
> > * Disable a bunch of tests that fail on mus (I filed bugs for them).
> > * Fix an unnecessary size_t to int conversion
> >
> > BUG= 602036 
> > TEST=views_mus_interactive_ui_tests on mus, interactive_ui_tests elsewhere
> > TBR=sky@chromium.org, dpranke@chromium.org, sadrul@chromium.org
> >
> > Committed: https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77
> > Cr-Commit-Position: refs/heads/master@{#394153}
>
> TBR=jamescook@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 602036 
>
> Committed: https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45
> Cr-Commit-Position: refs/heads/master@{#394158}

TBR=jamescook@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 602036 

Review-Url: https://codereview.chromium.org/1990453003
Cr-Commit-Position: refs/heads/master@{#394161}

[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/BUILD.gn
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/testing/buildbot/chromium.mojo.json
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/BUILD.gn
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/mus/BUILD.gn
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/mus/DEPS
[add] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/mus/interactive_ui_tests_manifest.json
[add] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/mus/run_all_unittests_mus.cc
[add] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/mus/views_mus_test_suite.cc
[add] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/mus/views_mus_test_suite.h
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/run_all_unittests.cc
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/run_all_unittests.h
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/test/platform_test_helper.h
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/test/scoped_views_test_helper.cc
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/test/scoped_views_test_helper.h
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/test/views_test_base.cc
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/test/views_test_base.h
[modify] https://crrev.com/88bc480b9b54298e520c44c3a7a4ea1ea7b0de7d/ui/views/widget/widget_interactive_uitest.cc

Status: Fixed (was: Started)
I've filed other bugs for the individual tests that are failing.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ee317105f488e5c3194d269c296c079b6ce8738

commit 9ee317105f488e5c3194d269c296c079b6ce8738
Author: jonross <jonross@chromium.org>
Date: Wed Feb 07 23:08:57 2018

Remove views_mus_interactive_ui_tests from Mojo Windows FYI

Currently views_mus_interactive_ui_tests are all timing out on the Mojo Windows
FYI bots. However this configuration is currently not supported by the Mus
project.

They are fine on the Chrome OS bots.

This change removes them from Mojo Windows FYI.

TBR=sky@chromium.org

TEST: views_mus_interactive_ui_tests
Bug:  602036 
Change-Id: Iec3f5a4c64b230a77c85abc315d6cf331fffc653
Reviewed-on: https://chromium-review.googlesource.com/907595
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535179}
[modify] https://crrev.com/9ee317105f488e5c3194d269c296c079b6ce8738/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9ee317105f488e5c3194d269c296c079b6ce8738/testing/buildbot/test_suites.pyl

Components: -MUS Internals>Services>WindowService

Sign in to add a comment