New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601983 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

chrome does not launch in mustash

Project Member Reported by sadrul@chromium.org, Apr 9 2016

Issue description

The chrome browsers do not show up inside mustash.
 

Comment 1 by sadrul@chromium.org, Apr 11 2016

Cc: jamescook@chromium.org
Crashes? Times out? Do you have a stack or error message?

Comment 3 by sadrul@chromium.org, Apr 11 2016

There are several issues:

 . the browser process attempts to launch the GPU process, and then crashes (because the GPU process hasn't been initialized): https://codereview.chromium.org/1874813002/

 . chrome can't connect to mus (and other) services because the manifest doesn't get installed: https://codereview.chromium.org/1870393002/

 . aura::Env setup changes breaking some chromeos code that requires a DeviceDataManager instance: https://codereview.chromium.org/1871253002/

 . chromeos code that requires an InputController instance: WIP
Labels: mustash1 pixelmus
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/578205fa70099bc2c93f785e6860ea878e6b7364

commit 578205fa70099bc2c93f785e6860ea878e6b7364
Author: sadrul <sadrul@chromium.org>
Date: Mon Apr 11 22:43:56 2016

aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the aura::Env
  instance, so that there's a clear owner of the instance, and random code can no
  longer destroy it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no longer
  necessary, and always create a PlatformEventSource instance (if one hasn't already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So the
  various BrowserMainParts implementations no longer need to do that.

BUG= 601983 

Review URL: https://codereview.chromium.org/1871253002

Cr-Commit-Position: refs/heads/master@{#386502}

[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ash/test/ash_interactive_ui_test_base.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ash/test/ash_interactive_ui_test_base.h
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ash/test/test_suite.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ash/test/test_suite.h
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/chrome/test/base/view_event_test_platform_part_chromeos.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/chrome/test/base/view_event_test_platform_part_default.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/content/browser/browser_main_loop.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/content/browser/browser_main_loop.h
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/content/public/test/unittest_test_suite.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/content/public/test/unittest_test_suite.h
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/content/shell/browser/shell_aura.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/content/shell/browser/shell_views.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/headless/lib/browser/headless_browser_main_parts.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/aura/demo/demo_main.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/aura/env.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/aura/env.h
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/aura/test/aura_test_helper.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/aura/test/aura_test_helper.h
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/aura/test/run_all_unittests.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/views/examples/examples_main.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/views/mus/BUILD.gn
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/views/mus/aura_init.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/views/mus/aura_init.h
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/views/mus/window_manager_connection.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/views/run_all_unittests.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/views_content_client/views_content_client_main_parts_aura.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/views_content_client/views_content_client_main_parts_desktop_aura.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/wm/test/run_all_unittests.cc
[modify] https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364/ui/wm/test/wm_test_helper.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/789f26c9d398df3f48dc39541f3a8238a96fad4b

commit 789f26c9d398df3f48dc39541f3a8238a96fad4b
Author: sadrul <sadrul@chromium.org>
Date: Tue Apr 12 00:13:57 2016

mash: Make sure the app-manifests for chrome gets built.

BUG= 594419 ,  601983 

Review URL: https://codereview.chromium.org/1870393002

Cr-Commit-Position: refs/heads/master@{#386528}

[modify] https://crrev.com/789f26c9d398df3f48dc39541f3a8238a96fad4b/chrome/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e73b4a46fd9a53eb9bdb0259f2e8b1cdf5363e2b

commit e73b4a46fd9a53eb9bdb0259f2e8b1cdf5363e2b
Author: sadrul <sadrul@chromium.org>
Date: Tue Apr 12 03:20:49 2016

mash: Disable gpu in chrome when running as a mus client.

BUG= 601983 

Review URL: https://codereview.chromium.org/1874813002

Cr-Commit-Position: refs/heads/master@{#386567}

[modify] https://crrev.com/e73b4a46fd9a53eb9bdb0259f2e8b1cdf5363e2b/content/browser/gpu/gpu_data_manager_impl_private.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89e8aa10b94fe0a7fecdda053778be7424f87bb3

commit 89e8aa10b94fe0a7fecdda053778be7424f87bb3
Author: sadrul <sadrul@chromium.org>
Date: Tue Apr 12 17:33:00 2016

mash: Use a stub InputController implementation when running mustash.

BUG= 601981 ,  601983 

Review URL: https://codereview.chromium.org/1883453002

Cr-Commit-Position: refs/heads/master@{#386732}

[modify] https://crrev.com/89e8aa10b94fe0a7fecdda053778be7424f87bb3/chrome/browser/chromeos/system/input_device_settings_impl_ozone.cc

Comment 9 by sadrul@chromium.org, Apr 12 2016

Status: Fixed (was: Started)
This should now be fixed.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd641a00bc5eb5401cfab3f3ae6a92439241424f

commit dd641a00bc5eb5401cfab3f3ae6a92439241424f
Author: sadrul <sadrul@chromium.org>
Date: Thu Apr 14 00:33:18 2016

mash: Fix crashes during chrome teardown.

On ChromeOS, when running as a mus client, the browser does not initialize
AccessibilityManager and MagnificationManager. So avoid trying to shutdown
these systems during tear-down.

Also, MojoShellConnection is initialized before the various impls of
BrowserMainParts::PreMainMessageLoopRun(). There, defer the destruction
of MojoShellConnection until BrowserMainParts::PostMainMessageLoopRun()
impls are run.

BUG= 601983 

Review URL: https://codereview.chromium.org/1877153003

Cr-Commit-Position: refs/heads/master@{#387171}

[modify] https://crrev.com/dd641a00bc5eb5401cfab3f3ae6a92439241424f/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/dd641a00bc5eb5401cfab3f3ae6a92439241424f/content/browser/browser_main_loop.cc

Status: Verified (was: Fixed)
Bulk verified
Components: -MUS Internals>Services>WindowService

Sign in to add a comment