We have a lot of bubbles - let's try to reuse some of them. We already do this on mac.
Om
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8befae922ea2ab1cc82b881dbb6bd91db852f51c commit 8befae922ea2ab1cc82b881dbb6bd91db852f51c Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 12 03:19:30 2016 [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms The ExtensionMessageBubbleBridge is a layer on top of an ExtensionMessageBubbleController that allows us to use it with a ToolbarActionsBarBubble. Use this same interface, which immediately allows us to remove ExtensionMessageBubbleController-specific methods in ToolbarActionsBar and it's platform-specific counterparts and makes both bubble showing flows follow the same path (easier to reason, less likely to conflict). As a next step, we can replace the ExtensionMessageBubbleView with the ToolbarActionsBarBubbleView, similar to what we have on mac, so that there's one less bubble to deal with. BUG= 601975 TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc, reviewed by Finnur) Review URL: https://codereview.chromium.org/1858773006 Cr-Commit-Position: refs/heads/master@{#386565} [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/extensions/blocked_action_bubble_delegate.h [rename] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc [rename] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/extensions/extension_message_bubble_bridge.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/toolbar/toolbar_actions_bar.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/toolbar/toolbar_actions_bar.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/views/extensions/extension_message_bubble_view.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/views/settings_api_bubble_helper_views.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/views/toolbar/browser_actions_container.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/views/toolbar/browser_actions_container.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc [modify] https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c/chrome/chrome_browser_ui.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5251920ddf61989a550ba9e49c8d1663a824a81f commit 5251920ddf61989a550ba9e49c8d1663a824a81f Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 13 20:23:16 2016 [Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles Make ExtensionMessageBubbles use ToolbarActionsBarBubble on Views platforms (we already do this on mac). In addition to meaning one less bubble, the ToolbarActionsBarBubbleViews class is much more suited to unit testing, since it doesn't require the full extensions system to be in place. Also add more unit tests. TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc, reviewed by Finnur) BUG= 601975 Review URL: https://codereview.chromium.org/1881773002 Cr-Commit-Position: refs/heads/master@{#387076} [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/extensions/extension_message_bubble_controller.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/extensions/blocked_action_bubble_delegate.h [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/extensions/extension_message_bubble_bridge.h [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/toolbar/toolbar_actions_bar.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/toolbar/toolbar_actions_bar.h [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h [delete] https://crrev.com/c76950806daa18236d19fbcde56e6c04a0774151/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc [delete] https://crrev.com/c76950806daa18236d19fbcde56e6c04a0774151/chrome/browser/ui/views/extensions/extension_message_bubble_view.h [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/views/settings_api_bubble_helper_views.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/views/toolbar/browser_actions_container.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc [modify] https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f/chrome/chrome_browser_ui.gypi
Comment 1 by ecantik...@gmail.com
, Apr 9 2016