New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601967 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

Change toolbar button size from 28x28 to 24x24 for Material Design

Project Member Reported by shrike@chromium.org, Apr 9 2016

Issue description

The Material Design spec. specified 28x28 buttons that abutted. sgabriel@ changed it to specify 24x24 buttons with 4pts of space between them.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad7c8102d9803e02da41b96071c5d68931772bb3

commit ad7c8102d9803e02da41b96071c5d68931772bb3
Author: shrike <shrike@chromium.org>
Date: Mon Apr 11 16:53:57 2016

[Mac][Material Design] Change toolbar buttons to 24x24 from 28x28.

The Material Design spec called for 28x28 toolbar buttons that touched
each other. sgabriel@ revised the spec to specify 24x24 toolbar buttons
with 4 pts of horizontal padding between them. This cl makes that
change, and incidentally fixes a problem where it was no longer
possible to resize the location bar by dragging it from its right edge.

R=avi@chromium.org, sky@chromium.org
BUG= 601967 

Review URL: https://codereview.chromium.org/1870333002

Cr-Commit-Position: refs/heads/master@{#386404}

[modify] https://crrev.com/ad7c8102d9803e02da41b96071c5d68931772bb3/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/ad7c8102d9803e02da41b96071c5d68931772bb3/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/ad7c8102d9803e02da41b96071c5d68931772bb3/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/ad7c8102d9803e02da41b96071c5d68931772bb3/chrome/browser/ui/toolbar/toolbar_actions_bar.cc

Comment 2 by shrike@chromium.org, Apr 11 2016

Status: Fixed (was: Started)

Sign in to add a comment