New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601952 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Spitzer fullscreen doesn't work with in-process-gpu

Project Member Reported by w...@chromium.org, Apr 8 2016

Issue description

There is no GpuSurfaceLookup::AcquireJavaSurface implementation in the browser.  
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b597036f28ef872717bdfb0c337e43ae11170a7

commit 2b597036f28ef872717bdfb0c337e43ae11170a7
Author: watk <watk@chromium.org>
Date: Tue Apr 12 00:33:46 2016

Android Java Surfaces can now be looked up via GpuSurfaceTracker

AndroidVideoDecodeAccelerator needs to be able to retrieve
registered Surfaces in order to decode to them. Previously this was
only possible to do from the GPU process through
SurfaceTextureManagerImpl, but now it can be done from the browser
through GpuSurfaceTracker. This enables fullscreen video decoding with
AVDA when in-process-gpu is enabled.

BUG= 601952 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1874023002

Cr-Commit-Position: refs/heads/master@{#386531}

[modify] https://crrev.com/2b597036f28ef872717bdfb0c337e43ae11170a7/content/browser/android/child_process_launcher_android.cc
[modify] https://crrev.com/2b597036f28ef872717bdfb0c337e43ae11170a7/content/browser/android/child_process_launcher_android.h
[modify] https://crrev.com/2b597036f28ef872717bdfb0c337e43ae11170a7/content/browser/gpu/gpu_surface_tracker.cc
[modify] https://crrev.com/2b597036f28ef872717bdfb0c337e43ae11170a7/content/browser/gpu/gpu_surface_tracker.h
[modify] https://crrev.com/2b597036f28ef872717bdfb0c337e43ae11170a7/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/2b597036f28ef872717bdfb0c337e43ae11170a7/gpu/ipc/common/gpu_surface_lookup.cc
[modify] https://crrev.com/2b597036f28ef872717bdfb0c337e43ae11170a7/gpu/ipc/common/gpu_surface_lookup.h

Comment 2 by w...@chromium.org, Apr 12 2016

Status: Fixed (was: Started)
Do we need to merge this to m51 to ensure fullscreen works on these devices?

Comment 4 by w...@chromium.org, Apr 13 2016

Labels: Merge-Request-51
Oops, yeah

Comment 5 by tin...@google.com, Apr 13 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4cfccda0714c51f307c0fca0f599b85c36ae9ce

commit d4cfccda0714c51f307c0fca0f599b85c36ae9ce
Author: Chris Watkins <watk@chromium.org>
Date: Wed Apr 13 22:15:58 2016

Android Java Surfaces can now be looked up via GpuSurfaceTracker

AndroidVideoDecodeAccelerator needs to be able to retrieve
registered Surfaces in order to decode to them. Previously this was
only possible to do from the GPU process through
SurfaceTextureManagerImpl, but now it can be done from the browser
through GpuSurfaceTracker. This enables fullscreen video decoding with
AVDA when in-process-gpu is enabled.

BUG= 601952 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1874023002

Cr-Commit-Position: refs/heads/master@{#386531}
(cherry picked from commit 2b597036f28ef872717bdfb0c337e43ae11170a7)

Review URL: https://codereview.chromium.org/1889703002 .

Cr-Commit-Position: refs/branch-heads/2704@{#38}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/d4cfccda0714c51f307c0fca0f599b85c36ae9ce/content/browser/android/child_process_launcher_android.cc
[modify] https://crrev.com/d4cfccda0714c51f307c0fca0f599b85c36ae9ce/content/browser/android/child_process_launcher_android.h
[modify] https://crrev.com/d4cfccda0714c51f307c0fca0f599b85c36ae9ce/content/browser/gpu/gpu_surface_tracker.cc
[modify] https://crrev.com/d4cfccda0714c51f307c0fca0f599b85c36ae9ce/content/browser/gpu/gpu_surface_tracker.h
[modify] https://crrev.com/d4cfccda0714c51f307c0fca0f599b85c36ae9ce/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/d4cfccda0714c51f307c0fca0f599b85c36ae9ce/gpu/ipc/common/gpu_surface_lookup.cc
[modify] https://crrev.com/d4cfccda0714c51f307c0fca0f599b85c36ae9ce/gpu/ipc/common/gpu_surface_lookup.h

Sign in to add a comment