New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601932 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Fix to isolate_tests seems to be crashing Mac bots.

Reported by beaudoin@chromium.org, Apr 8 2016

Issue description

Suspecting this fix:
https://codereview.chromium.org/1875743002

Of crashing the Mac bots.

Working on a fix that moves the target app_list_shower.gyp:app_list_shower_unittests to use_aura=1.

Please use this bug to make sure I did the right thing or fix it if that wasn't correct.

 

Comment 1 by h...@chromium.org, Apr 8 2016

Sorry about that. Can you post a link to crashing Mac bot for reference?
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/736ad8abed54d7393cf672f4dbc2eea26e08bdcf

commit 736ad8abed54d7393cf672f4dbc2eea26e08bdcf
Author: cwallez <cwallez@chromium.org>
Date: Fri Apr 08 21:54:37 2016

Build app_list_shower only if use_aura=1

This was being build on non-Android platforms and broke the Mac build.
Guard the build with use_aura=1 in Gyp, like it is in GN.

BUG= 601932 
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1875833002

Cr-Commit-Position: refs/heads/master@{#386214}

[modify] https://crrev.com/736ad8abed54d7393cf672f4dbc2eea26e08bdcf/build/gn_migration.gypi

This seems to have fixed it. We should still figure out why all the CQ bots were green. Maybe some target is not being built?
Labels: -Sheriff-Chromium
Removing Sheriff-Chromium label. Leaving to you guys to decide if you want to spend more time on investigating the root cause.
Labels: Infra-CommitQueue
+Infra-CommitQueue
I am also curious if it is expected behavior that https://codereview.chromium.org/1875743002 passed through the commit queue and then broke the Mac builder:  
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4852

Shouldn't this have been caught by the trybots?
Cc: h...@chromium.org phajdan.jr@chromium.org
Owner: ----
+phajdan = CQ has allowed bad change to build rules (see fix https://codereview.chromium.org/1875833002). I wonder is this sad WAI or bug in analyze. 

FYI: Please, remove owner before sending to CQ team, as we typically ignore owned bugs.

Comment 7 by thakis@chromium.org, Apr 11 2016

Status: Fixed (was: Untriaged)
I think this is WAI:

* original breakage: 'all' doesn't build everything with gyp (there's an open bug for that somewhere), and the original change didn't add the _run target to gn_migration.gypi. So bots building 'all' didn't build that _run target, and then later the isolate step failed.

* follow-up breakage: The fix for that added the _run target to 'all', which caused it to be built on the clobber bots, but the new target didn't build on OS X. The fix made the _run target not part of 'all', but I'm guessing that explicitly building "app_list_shower" on OS X still causes errors -- the target should be made conditional too.

Anyhoo, this bug is done.
> The fix for that added the _run target to 'all', which caused it to be built on the clobber bots, but the new target didn't build on OS X.

Shouldn't the fact that it didn't build on OSX been detected by CQ?
(app_list_shower target was not supposed to be built on OSX since it uses Aura.)

Comment 9 by aga...@chromium.org, Apr 26 2016

Components: Infra>CQ
Labels: -Infra-CommitQueue
Labels: -Infra

Sign in to add a comment