New issue
Advanced search Search tips

Issue 601921 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

flashrom: Add support for ec ioctl format used in upstream kernel and Chrome OS 4.4

Project Member Reported by groeck@chromium.org, Apr 8 2016

Issue description

The upstream kernel, and with it Chrome OS 4.4, use a different ioctl messaging format than Chrome OS 3.18 and earlier. Add support for mosys to support both the old and the new ioctl format.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/51822fd8be91a643fb733e827db4a9efb020ad32

commit 51822fd8be91a643fb733e827db4a9efb020ad32
Author: Guenter Roeck <groeck@chromium.org>
Date: Fri Apr 08 20:58:11 2016

flashrom: Add support for upstream and cromeos-4.4 ioctl format

Upstream and Chrome OS v4.4 use a modified ioctl message format.
Auto-detect and support both formats.

BUG= chromium:601921 
BRANCH=None
TEST=Work on Samus with kernel 4.4 and 3.8/3.14/3.18

Change-Id: Id884e851dba979c47d1ccc925648cec3a25f5aff
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/338200
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/51822fd8be91a643fb733e827db4a9efb020ad32/cros_ec_dev.c
[modify] https://crrev.com/51822fd8be91a643fb733e827db4a9efb020ad32/cros_ec_dev.h

Comment 2 by groeck@chromium.org, Apr 12 2016

Status: Verified (was: Started)

Sign in to add a comment