New issue
Advanced search Search tips

Issue 601920 link

Starred by 3 users
Status: Fixed
Owner:
tfarina@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Delete references to aura_builder from bot configurations

Project Member Reported by brettw@chromium.org, Apr 8 2016 
The linux_chromium_chromeos_rel_ng and linux_chromium_chromeos_compile_rel_ng bots reference the "aura_builder" target as the thing to build, but all targets for those bots to compile are set up separately and this is unnecessary.

In //BUILD.gn there is a dummy aura_builder group to keep the bots happy in the meantime.

Comment 1 by dpranke@chromium.org, Apr 8 2016

Cc: -dpranke@chromium.org
Labels: -Pri-3 Pri-1
Owner: dpranke@chromium.org
Status: Started (was: Untriaged)

Comment 2 by brettw@chromium.org, Apr 8 2016 

The above comment references a setup being made in this patch: https://codereview.chromium.org/1867983002/
which hasn't been landed at the time of this writing.

Comment 3 by dpranke@chromium.org, Apr 20 2016

Components: Build

Comment 4 by dpranke@chromium.org, Apr 20 2016

Blocking: 354261

Comment 5 by dpranke@chromium.org, Jun 20 2016

Blocking: -354261
Labels: -Pri-1 Pri-3
this doesn't need to block anything ...

Comment 6 by dpranke@chromium.org, Jun 21 2016

Labels: -Proj-GN-Migration

Comment 7 by dpranke@chromium.org, Aug 30 2016

Owner: ----
Status: Available (was: Started)

Comment 8 by tfarina@chromium.org, May 17 2017

Owner: tfarina@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/507727/
Project Member

Comment 9 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1ba4afe62e56408169d479018801c04a2d8335ec

commit 1ba4afe62e56408169d479018801c04a2d8335ec
Author: Thiago Farina <tfarina@chromium.org>
Date: Fri May 26 01:29:59 2017

remove references to aura_builder target

In GN this target is empty and thus do nothing.

https://chromium.googlesource.com/chromium/src/+/75b3b45a4797bd19d3acea459082dd4914b2b07e/BUILD.gn#1032

BUG= 601920 

Change-Id: I1ee3b815af0d26f054488f5d2ff7da13c86af466
Reviewed-on: https://chromium-review.googlesource.com/507727
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_fail.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_gen_compile_fail.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_codesearch.py
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/1ba4afe62e56408169d479018801c04a2d8335ec/scripts/slave/recipes/chromium_trybot.expected/recipe_config_changes_not_retried_without_patch.json
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f94b8c6135dc8fdc663f76946eb109cc9495cd5

commit 9f94b8c6135dc8fdc663f76946eb109cc9495cd5
Author: Thiago Farina <tfarina@chromium.org>
Date: Thu Jun 01 15:53:47 2017

remove aura_builder target

It is an empty target that was there for compatibility with GYP.

Nothing uses it anymore and thus it can be removed now.

The changes to the build side were already done here ->
https://chromium.googlesource.com/chromium/tools/build/+/1ba4afe62e56408169d479018801c04a2d8335ec

BUG= 601920 

Change-Id: I442368cc860dce8778fd0d064ef99bb3a854be11
Reviewed-on: https://chromium-review.googlesource.com/516982
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476307}
[modify] https://crrev.com/9f94b8c6135dc8fdc663f76946eb109cc9495cd5/BUILD.gn
[modify] https://crrev.com/9f94b8c6135dc8fdc663f76946eb109cc9495cd5/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/9f94b8c6135dc8fdc663f76946eb109cc9495cd5/testing/buildbot/manage.py

Comment 11 by tfarina@chromium.org, Jun 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment