New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 601918 link

Starred by 2 users
Status: Fixed
Owner:
finnur@chromium.org
Closed: May 2016
Cc:
█ nsatra...@chromium.org
█ f...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Updating Exceptions strings in Site Settings

Project Member Reported by rolfe@chromium.org, Apr 8 2016 
nsatragno@ launched a change to Site settings, and as a part of that some text edits for the exceptions pieces (e.g. JavaScript) came up.

Owencm - can you triage as available? Or send to security if that's a better fit?

- Change "Add site" to be consistently "Add site exception" whether or not there are exceptions listed.
- Change dialog text to be: "Allow [JavaScript/Permissions] for a specific site."

See UI Review thread for reference:
https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/uoF4gnmPvMA

Comment 1 by owe...@chromium.org, Apr 8 2016 

Sorry, what's the actual action required here?

It's unclear to me if those strings are already updated in production, or you're wondering whether we need launch approval, or to track the eng work to update these strings etc etc?

Comment 2 by rolfe@chromium.org, Apr 8 2016 

They are Ui-Review approved, but nstragno@ did not have time to implement. Small enough not to need a launch review, just a SWE to implement the change.

Comment 3 by owe...@chromium.org, Apr 8 2016

Cc: -peter@chromium.org
Components: Security>UX
Owner: ----
Ah I see. So we're looking to track implementation work to change this text?

In that case I suggest we move to Security > UX for triage. 

Also -peter to save his inbox.

Comment 4 by owe...@chromium.org, Apr 12 2016

Owner: f...@chromium.org
Assigning to felt for triage

Summary: seeking eng resources to implement string changes in settings

Comment 5 by finnur@chromium.org, Apr 26 2016

Cc: f...@chromium.org
Owner: finnur@chromium.org
Status: Started (was: Untriaged)
I'm doing these changes now.

It feels a little weird to be able to add exceptions when the default already is set to Allow. Just want to make sure this is the intent?

Comment 6 by rolfe@chromium.org, Apr 26 2016 

Thank you for taking this on. No changes to add exceptions when the default is set to allow, rather these are string changes to the exception flow:

- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.] for a specific site."
Project Member

Comment 7 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d4101ec17e44ff061d5e65bc52f386d9985e881

commit 2d4101ec17e44ff061d5e65bc52f386d9985e881
Author: finnur <finnur@chromium.org>
Date: Mon May 09 18:04:36 2016

Site Settings Android: A few polish items.

From  issue 601918 :
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.] for a specific site."

From  issue 467788 :
- Update the individual site settings page toggles with verbs that match the permissions bubbles

From  issue 604753  (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG= 601918 ,  467788 ,  604753 

Review-Url: https://codereview.chromium.org/1947493002
Cr-Commit-Position: refs/heads/master@{#392363}

[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-hdpi/permission_protected_media.png
[add] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-hdpi/settings_media.png
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-mdpi/permission_protected_media.png
[add] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-mdpi/settings_media.png
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-xhdpi/permission_protected_media.png
[add] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-xhdpi/settings_media.png
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-xxhdpi/permission_protected_media.png
[add] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-xxhdpi/settings_media.png
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-xxxhdpi/permission_protected_media.png
[add] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/drawable-xxxhdpi/settings_media.png
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/res/xml/site_settings_preferences.xml
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
[add] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
[modify] https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881/chrome/android/java/strings/android_chrome_strings.grd
Project Member

Comment 8 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04e90ff9a7f58302c97fe4a0c14dd12e41f89951

commit 04e90ff9a7f58302c97fe4a0c14dd12e41f89951
Author: finnur <finnur@chromium.org>
Date: Tue May 10 15:25:58 2016

Revert of Site Settings Android: A few polish items. (patchset #6 id:180001 of https://codereview.chromium.org/1947493002/ )

Reason for revert:
Caused crbug.com/610576

Original issue's description:
> Site Settings Android: A few polish items.
>
> From  issue 601918 :
> - Change "+ Add site" blue action link to be "+ Add site exception"
> - Change dialog text to be: "Allow [JavaScript/the permission in question etc.] for a specific site."
>
> From  issue 467788 :
> - Update the individual site settings page toggles with verbs that match the permissions bubbles
>
> From  issue 604753  (partial fix):
> - Improve alignment of Site Settings list a bit (move icon a bit to the right).
> - Color the Site List heading blue.
>
> Also add an updated image for Protected Content (slightly larger) and the Media icon, which is for
> the container menu that will house Protected Content and Autoplay.
>
> BUG= 601918 ,  467788 ,  604753 
>
> Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
> Cr-Commit-Position: refs/heads/master@{#392363}

TBR=twellington@chromium.org,dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 601918 ,  467788 ,  604753 

Review-Url: https://codereview.chromium.org/1968503002
Cr-Commit-Position: refs/heads/master@{#392612}

[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/res/drawable-hdpi/permission_protected_media.png
[delete] https://crrev.com/c3be22bfd9c16f9b6ca288d9737a1df5dde2ee0b/chrome/android/java/res/drawable-hdpi/settings_media.png
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/res/drawable-mdpi/permission_protected_media.png
[delete] https://crrev.com/c3be22bfd9c16f9b6ca288d9737a1df5dde2ee0b/chrome/android/java/res/drawable-mdpi/settings_media.png
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/res/drawable-xhdpi/permission_protected_media.png
[delete] https://crrev.com/c3be22bfd9c16f9b6ca288d9737a1df5dde2ee0b/chrome/android/java/res/drawable-xhdpi/settings_media.png
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/res/drawable-xxhdpi/permission_protected_media.png
[delete] https://crrev.com/c3be22bfd9c16f9b6ca288d9737a1df5dde2ee0b/chrome/android/java/res/drawable-xxhdpi/settings_media.png
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/res/drawable-xxxhdpi/permission_protected_media.png
[delete] https://crrev.com/c3be22bfd9c16f9b6ca288d9737a1df5dde2ee0b/chrome/android/java/res/drawable-xxxhdpi/settings_media.png
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/res/xml/site_settings_preferences.xml
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
[delete] https://crrev.com/c3be22bfd9c16f9b6ca288d9737a1df5dde2ee0b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
[modify] https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951/chrome/android/java/strings/android_chrome_strings.grd
Project Member

Comment 9 by bugdroid1@chromium.org, May 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91faabbb0fd92d636378508b4aa644b11bc4877b

commit 91faabbb0fd92d636378508b4aa644b11bc4877b
Author: finnur <finnur@chromium.org>
Date: Wed May 11 12:01:45 2016

Site Settings Android: A few polish items.

From  issue 601918 :
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.] for a specific site."

From  issue 467788 :
- Update the individual site settings page toggles with verbs that match the permissions bubbles

From  issue 604753  (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG= 601918 ,  467788 ,  604753 

Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}

Review-Url: https://codereview.chromium.org/1947493002
Cr-Commit-Position: refs/heads/master@{#392899}

[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-hdpi/permission_protected_media.png
[add] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-hdpi/settings_media.png
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-mdpi/permission_protected_media.png
[add] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-mdpi/settings_media.png
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-xhdpi/permission_protected_media.png
[add] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-xhdpi/settings_media.png
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-xxhdpi/permission_protected_media.png
[add] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-xxhdpi/settings_media.png
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-xxxhdpi/permission_protected_media.png
[add] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/drawable-xxxhdpi/settings_media.png
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/res/xml/site_settings_preferences.xml
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
[add] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b/chrome/android/java_sources.gni

Comment 10 by finnur@chromium.org, May 11 2016

Status: Fixed (was: Started)

Comment 11 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment