New issue
Advanced search Search tips

Issue 601908 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 601900



Sign in to add a comment

zip_reader.cc doesn't properly handle failures from FromLocalExploded()

Project Member Reported by eroman@chromium.org, Apr 8 2016

Issue description

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/zlib/google/zip_reader.cc&l=169&cl=GROK

  if (exploded_time.HasValidValues()) {
    last_modified_ = base::Time::FromLocalExploded(exploded_time);
  } else {
    // Use Unix time epoch if the time stamp data is invalid.
    last_modified_ = base::Time::UnixEpoch();
  }

However HasValidValues() is not guaranteed to mean that FromLocalExploded() succeeds.
 
Sorry, I used wrong bug number in the cl.

The issue is solved -

https://codereview.chromium.org/2091673002/
Status: Fixed (was: Untriaged)
Closing per comment 1

Sign in to add a comment