New issue
Advanced search Search tips

Issue 601898 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

60.4% regression in blink_perf.bindings at 385750:385788

Project Member Reported by rsch...@chromium.org, Apr 8 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=601898

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgmO7aowoM


Bot(s) for this bug's original alert(s):

android-nexus5X

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@385749         49.22056    22.39116    18          good
chromium@385788         47.560525   21.115419   18          bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 601898

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests blink_perf.bindings
Test Metric: insert-before/insert-before
Relative Change: 9.56%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/65
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9015920049860108960


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=601898

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Kicked off another couple of bisects on different platforms.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Apr 20 2016

Cc: csharrison@chromium.org
Owner: csharrison@chromium.org

=== Auto-CCing suspected CL author csharrison@chromium.org ===

Hi csharrison@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add DocumentWriteEvaluator unit tests
Author  : csharrison
Commit description:
  
This patch adds tests for the DocumentWriteEvaluator in isolation.

BUG=599115

Review URL: https://codereview.chromium.org/1865543002

Cr-Commit-Position: refs/heads/master@{#385750}
Commit  : 732c4ab2db2056f451cb6ee13730a15276de0624
Date    : Thu Apr 07 14:26:08 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@385749         61.429093   3.557703    5           good
chromium@385750         52.881611   1.482613    5           bad         <-

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 601898

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.bindings
Test Metric: get-attribute-rare/get-attribute-rare
Relative Change: 13.91%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/107
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9014848728023789600


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=601898

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
This CL just adds tests, which probably contributed to it now being slower to run the test suite.

I suspect this is WontFix, unless the slowdown is unreasonable and tests should be removed.
Labels: Needs-Feedback
csharrison@ : Could you please update the Issue status accrodingly if there is no work to be done further on this.
Status: WontFix (was: Assigned)
Yeah sorry about that. I was waiting for a resolution for the question raised in #5. I'll mark as WontFix for now.

Sign in to add a comment