New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601891 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
IDB-Stability


Sign in to add a comment

Be able to differentiate different kinds of OOM crashes

Project Member Reported by dk...@chromium.org, Apr 8 2016

Issue description

Currently, when Chrome OOMs there are a few cases that cannot be distinguished, which makes it hard to debug:

- IndexedDB is incorrectly allocating a lot of memory
- IDB is correctly allocating a lot of memory, but we shouldn't be allowing it because it causes a crash
- IDB is allocating normally but we're hitting process memory limits

We should update crash reports to tell us how much each module is allocating so that we can differentiate these cases. 

Assigning to SSID since they seem to have done some work in this area.

 

Comment 1 by ssid@chromium.org, Apr 8 2016

Cc: primiano@chromium.org haraken@chromium.org
+primiano, haraken who are working on slow reports / background tracing and oom crash reports.
This is an ongoing project and will certainly include IndexedDb case as well since it is part of memory-infra. They will be able to provide more context and timeline.
There is a medium term plan to have traces in crash and in the background tracing (slow reports) infrastructure. But this is after Q2.

> We should update crash reports to tell us how much each module is allocating so that we can differentiate these cases. 
The problem of this approach is: when shall we poll these values? we cannot poll at the time of the crash, as it is too late then.

A short term solution while we get there would be updating crash keys setting memory requested by IDB every time it allocates more memory, but that feels to me something that IDB owners should do.

Not sure what do you expect ssid@ to do here.

Comment 3 by dk...@chromium.org, Apr 11 2016

Glad to hear that there's a roadmap to resolving this! No need to prioritize a short term solution if there's a medium term plan in place. I just wanted to file the bug to make sure the work item isn't lost :)
Cc: nduca@chromium.org
Yup, I don't think this problem is specific to IDB. 
There is the general problem of: which component is the culprit for OOM crashes, and we need a more general solution there.

Sign in to add a comment