This is a redundant mechanism for hooking mojo application factories up to an embededded shell. We should remote this and replace all uses with ShellClientFactory.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/963ad3e895f9bd9de01e428893c1423f524181d3 commit 963ad3e895f9bd9de01e428893c1423f524181d3 Author: rockot <rockot@chromium.org> Date: Wed Apr 13 16:33:23 2016 Use ShellClientFactory interface to load mojo:profile - Adds a ShellConnection per BrowserContext so every running profile is a virtual browser application with a unique user ID. - Changes Shell to connect to SCF interfaces as itself while while inheriting the target SCF's user ID. - Adds a SCF to the BrowserContext shell connection - Exposes mojo:profile through BrowserContext's SCF - Exposes a mojo::Connector through BrowserContext and updates DOMStorageWrapper to use this instead of deprecated MojoAppConnection - Removes CurrentThreadLoader and DefaultLoader, which are no longer needed BUG= 601884 TEST=localStorage still works for basic set/get in a tab with --mojo-local-storage on Review URL: https://codereview.chromium.org/1871223003 Cr-Commit-Position: refs/heads/master@{#387004} [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/components/profile_service/BUILD.gn [add] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/components/profile_service/manifest.json [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/components/profile_service/profile_service.gyp [add] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/components/profile_service/public/cpp/BUILD.gn [add] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/components/profile_service/public/cpp/constants.cc [add] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/components/profile_service/public/cpp/constants.h [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/BUILD.gn [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/browser_context.cc [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/browser_main_loop.cc [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/dom_storage/dom_storage_context_wrapper.cc [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/dom_storage/dom_storage_context_wrapper.h [add] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/mojo/browser_shell_connection.cc [add] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/mojo/browser_shell_connection.h [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/mojo/mojo_shell_context.cc [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/mojo/mojo_shell_context.h [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/browser/storage_partition_impl.cc [delete] https://crrev.com/ebb59f161b523e198d86296a69514175dade66da/content/common/mojo/current_thread_loader.cc [delete] https://crrev.com/ebb59f161b523e198d86296a69514175dade66da/content/common/mojo/current_thread_loader.h [add] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/common/mojo/embedded_application_runner.cc [add] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/common/mojo/embedded_application_runner.h [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/content_browser.gypi [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/content_common.gypi [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/content_resources.grd [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/public/app/BUILD.gn [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/content/public/browser/browser_context.h [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/mojo/public/tools/manifest/manifest_collator.py [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/services/shell/shell.cc [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/services/shell/shell.h [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/services/shell/tests/connect/connect_test.mojom [modify] https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3/services/shell/tests/connect/connect_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1 commit 3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1 Author: rockot <rockot@chromium.org> Date: Fri Apr 15 21:46:20 2016 Remove uses of shell::Loader from content Replaces existing uses with the same SCF-based interface used for other shell connections. Adds a manifest for mojo:media (packaged in exe:content_browser) so the shell knows where to route its connections. BUG= 601884 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation TBR=xhwang@chromium.org for addition of the app manifest Review URL: https://codereview.chromium.org/1889253002 Cr-Commit-Position: refs/heads/master@{#387708} [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/browser/frame_host/frame_mojo_shell.cc [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/browser/mojo/browser_shell_connection.cc [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/browser/mojo/browser_shell_connection.h [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/browser/mojo/mojo_shell_context.cc [delete] https://crrev.com/8e9314bcf382b9df7caa3ab331e1b0090c27b62f/content/browser/mojo_shell_browsertest.cc [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/child/process_control_impl.cc [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/child/process_control_impl.h [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/common/mojo/embedded_application_runner.cc [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/common/mojo/embedded_application_runner.h [delete] https://crrev.com/8e9314bcf382b9df7caa3ab331e1b0090c27b62f/content/common/mojo/static_loader.cc [delete] https://crrev.com/8e9314bcf382b9df7caa3ab331e1b0090c27b62f/content/common/mojo/static_loader.h [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/content_common.gypi [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/content_tests.gypi [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/gpu/gpu_process_control_impl.cc [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/gpu/gpu_process_control_impl.h [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/public/app/BUILD.gn [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/shell/utility/shell_content_utility_client.cc [delete] https://crrev.com/8e9314bcf382b9df7caa3ab331e1b0090c27b62f/content/test/data/web_ui_mojo_shell_test.html [delete] https://crrev.com/8e9314bcf382b9df7caa3ab331e1b0090c27b62f/content/test/data/web_ui_mojo_shell_test.js [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/utility/utility_process_control_impl.cc [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/content/utility/utility_process_control_impl.h [modify] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/media/mojo/services/BUILD.gn [add] https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1/media/mojo/services/media_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1de6dacd4e9c59274f2c061accfe3770f696c09b commit 1de6dacd4e9c59274f2c061accfe3770f696c09b Author: rockot <rockot@chromium.org> Date: Sat Apr 16 02:44:24 2016 Remove shell::Loader BUG= 601884 R=ben@chromium.org Review URL: https://codereview.chromium.org/1898433002 Cr-Commit-Position: refs/heads/master@{#387800} [modify] https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b/services/shell/BUILD.gn [modify] https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b/services/shell/background/background_shell.cc [delete] https://crrev.com/e5654af3fec812e02719216a0014698b235cd52f/services/shell/loader.h [modify] https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b/services/shell/shell.cc [modify] https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b/services/shell/shell.gyp [modify] https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b/services/shell/shell.h [modify] https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b/services/shell/tests/BUILD.gn [delete] https://crrev.com/e5654af3fec812e02719216a0014698b235cd52f/services/shell/tests/loader_unittest.cc [add] https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b/services/shell/tests/placeholder_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dee79720763b041a6ee7aa399384bdb64bad291 commit 9dee79720763b041a6ee7aa399384bdb64bad291 Author: rkc <rkc@chromium.org> Date: Sat Apr 16 22:45:10 2016 Revert of Remove shell::Loader (patchset #3 id:40001 of https://codereview.chromium.org/1898433002/ ) Reason for revert: It looks like this CL breaks the Windows bot (https://build.chromium.org/p/chromium/buildstatus?builder=Win&number=42453). Before this CL, mojo_shell_unittests.exe weren't being built, since the target had no source files. This CL starts to build them, which exposes the link error on Windows. Tentatively reverting. Original issue's description: > Remove shell::Loader > > BUG= 601884 > R=ben@chromium.org > > Committed: https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b > Cr-Commit-Position: refs/heads/master@{#387800} TBR=ben@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 601884 Review URL: https://codereview.chromium.org/1899583002 Cr-Commit-Position: refs/heads/master@{#387815} [modify] https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291/services/shell/BUILD.gn [modify] https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291/services/shell/background/background_shell.cc [add] https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291/services/shell/loader.h [modify] https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291/services/shell/shell.cc [modify] https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291/services/shell/shell.gyp [modify] https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291/services/shell/shell.h [modify] https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291/services/shell/tests/BUILD.gn [add] https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291/services/shell/tests/loader_unittest.cc [delete] https://crrev.com/a3a881e0f72ccc2faaacda64169296dc7f731f1d/services/shell/tests/placeholder_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d152ac52434d55bdb39348375df3a87913837888 commit d152ac52434d55bdb39348375df3a87913837888 Author: rockot <rockot@chromium.org> Date: Sun Apr 17 20:53:32 2016 Remove shell::Loader BUG= 601884 R=ben@chromium.org Committed: https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b Cr-Commit-Position: refs/heads/master@{#387800} Review URL: https://codereview.chromium.org/1898433002 Cr-Commit-Position: refs/heads/master@{#387834} [modify] https://crrev.com/d152ac52434d55bdb39348375df3a87913837888/services/shell/BUILD.gn [modify] https://crrev.com/d152ac52434d55bdb39348375df3a87913837888/services/shell/background/background_shell.cc [delete] https://crrev.com/2f8c7fcf0ca7d22c7ef943ea5e3256914bef70f1/services/shell/loader.h [modify] https://crrev.com/d152ac52434d55bdb39348375df3a87913837888/services/shell/shell.cc [modify] https://crrev.com/d152ac52434d55bdb39348375df3a87913837888/services/shell/shell.gyp [modify] https://crrev.com/d152ac52434d55bdb39348375df3a87913837888/services/shell/shell.h [modify] https://crrev.com/d152ac52434d55bdb39348375df3a87913837888/services/shell/tests/BUILD.gn [delete] https://crrev.com/2f8c7fcf0ca7d22c7ef943ea5e3256914bef70f1/services/shell/tests/loader_unittest.cc [add] https://crrev.com/d152ac52434d55bdb39348375df3a87913837888/services/shell/tests/placeholder_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Apr 13 2016