Issue metadata
Sign in to add a comment
|
Tool tip doesn't show up on Shelf |
||||||||||||||||||||||
Issue descriptionChrome Version : 51.0.2701.0 (Official Build) dev (64-bit) Platform : 8165.0.0 (Official Build) expresso, ultima What steps will reproduce the problem? 1. install Chrome 20+ apps and pin them to Shelf 2. mouse hover on subfolder icons and check the tool tips What is the expected result? The tool tip should appear (m50.png) What happens instead? The tool tip doesn't show up (m51.png). Please provide any additional information below. Attach a screenshot if possible. Not reproducible in Chrome 50.0.2661.67 / CrOS 7978.48.0 - candy
,
Apr 11 2016
I have a local fix: https://codereview.chromium.org/1875033004 We'll need to eventually merge the fix to M-51 branch 2704.
,
Apr 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01b843768f112912493d5a2510ecd6e09b0ed7bf commit 01b843768f112912493d5a2510ecd6e09b0ed7bf Author: msw <msw@chromium.org> Date: Mon Apr 11 21:09:48 2016 Fix tooltips for Chrome OS shelf overflow icons. Fixes a regression from https://codereview.chromium.org/1816753002 Add OverflowBubbleView's ShelfView after creating the bubble widget. (ShelfTooltipManager init requires the widget to exist first) BUG= 601880 TEST=Chrome OS shelf overflow bubble shows tooltips. R=sky@chromium.org Review URL: https://codereview.chromium.org/1875033004 Cr-Commit-Position: refs/heads/master@{#386471} [modify] https://crrev.com/01b843768f112912493d5a2510ecd6e09b0ed7bf/ash/shelf/overflow_bubble_view.cc [modify] https://crrev.com/01b843768f112912493d5a2510ecd6e09b0ed7bf/ash/shelf/shelf_view.cc
,
Apr 11 2016
How can I test Chrome OS canary/dev to verify for merge? songsuk@, can you help verify the fix once it's available?
,
Apr 14 2016
I can verify this is fixed on desktop ToT, but don't have a device for testing. Requesting merge to to M-51 branch 2704.
,
Apr 14 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1efceaa570b35862ecec60eaca67090fa3a1ade commit d1efceaa570b35862ecec60eaca67090fa3a1ade Author: Michael Wasserman <msw@chromium.org> Date: Thu Apr 14 18:51:19 2016 Fix tooltips for Chrome OS shelf overflow icons. Fixes a regression from https://codereview.chromium.org/1816753002 Add OverflowBubbleView's ShelfView after creating the bubble widget. (ShelfTooltipManager init requires the widget to exist first) BUG= 601880 TEST=Chrome OS shelf overflow bubble shows tooltips. R=sky@chromium.org Review URL: https://codereview.chromium.org/1875033004 Cr-Commit-Position: refs/heads/master@{#386471} (cherry picked from commit 01b843768f112912493d5a2510ecd6e09b0ed7bf) Review URL: https://codereview.chromium.org/1883233002 . Cr-Commit-Position: refs/branch-heads/2704@{#56} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/d1efceaa570b35862ecec60eaca67090fa3a1ade/ash/shelf/overflow_bubble_view.cc [modify] https://crrev.com/d1efceaa570b35862ecec60eaca67090fa3a1ade/ash/shelf/shelf_view.cc
,
Apr 14 2016
Fixed, please help verify, thanks!
,
Apr 14 2016
Verified on chrome 52.0.2706.0/ CrOS 8190.0.0- Parrot
,
Apr 18 2016
Verified in Chrome 51.0.2704.15/ CrOS 8172.4.0- Candy |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msw@chromium.org
, Apr 8 2016Status: Assigned (was: Untriaged)