New issue
Advanced search Search tips

Issue 601879 link

Starred by 2 users
Status: Fixed
Owner:
sorin@chromium.org
Closed: Apr 2016
Cc:
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Component updater must enforce that the brand length is 4.

Project Member Reported by sorin@chromium.org, Apr 8 2016 
The current implementation of brand validation code allows brand codes of up to 4 chars long. The expected behavior is that only 4-chars long brand codes are valid.

Comment 2 by sorin@chromium.org, Apr 11 2016

Status: Fixed (was: Started)

Comment 3 by sorin@chromium.org, Apr 15 2016

Labels: Merge-Request-51
Low risk change, as a follow up to https://codereview.chromium.org/1823273002/

Comment 4 by tin...@google.com, Apr 15 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 5 Deleted

Comment 6 by gov...@chromium.org, Apr 18 2016 

Please merge your change to M51 branch 2704 ASAP (before 5:00 PM PST, today) so we can take it in for M51 last Dev release tomorrow.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73ebab994224d08a93500fe8dc8e328ca0ac58ec

commit 73ebab994224d08a93500fe8dc8e328ca0ac58ec
Author: Joshua Pawlicki <waffles@google.com>
Date: Mon Apr 18 20:40:49 2016

Component updater must enforce that the brand length is 4.

BUG= 601879 

Review URL: https://codereview.chromium.org/1876573002

Cr-Commit-Position: refs/heads/master@{#386266}
(cherry picked from commit af402ee655981ab3690c6cc00de0a8f3e5071b31)

Review URL: https://codereview.chromium.org/1897823003 .

Cr-Commit-Position: refs/branch-heads/2704@{#107}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/components/update_client/utils.cc
[modify] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/components/update_client/utils.h
[modify] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/components/update_client/utils_unittest.cc
►

Sign in to add a comment