New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601871 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
mus



Sign in to add a comment

Components that depend on LatencyInfo should not also pull in all of ui::Events

Project Member Reported by fsam...@chromium.org, Apr 8 2016

Issue description

LatencyInfo => ui/latency_info and ui/latency_info/ipc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/168cca4ea0abb22aa05575ec94c35d429dc08993

commit 168cca4ea0abb22aa05575ec94c35d429dc08993
Author: fsamuel <fsamuel@chromium.org>
Date: Wed Apr 13 01:40:09 2016

Move LatencyInfo to ui/latency_info

Components such as cc/ and gpu/ that depend on ui::LatencyInfo
should not pull in all of ui/events.

This CL pulls ui::LatencyInfo into a separate component to
simplify this dependency. cc/ and gpu/ no longer depend on
ui/events.

BUG= 601871 
TBR=jam@chromium.org for top level BUILD.gn and build/all.gyp
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1871233002

Cr-Commit-Position: refs/heads/master@{#386889}

[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/build/all.gyp
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/cc/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/cc/DEPS
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/cc/cc.gyp
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/cc/cc_tests.gyp
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/cc/output/compositor_frame_metadata.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/cc/output/latency_info_swap_promise.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/cc/surfaces/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/cc/surfaces/display.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/DEPS
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/android/in_process/synchronous_input_event_filter.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/compositor/image_transport_factory.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/loader/resource_scheduler_unittest.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/input/render_widget_host_latency_tracker.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/input/synthetic_tap_gesture.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/input/touch_action_browsertest.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/input/touch_input_browsertest.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/common/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/common/accelerated_surface_buffers_swapped_params_mac.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/common/gpu_host_messages.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/common/input/input_event.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/common/input/input_event_ack.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/common/input_messages.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/content_browser.gypi
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/content_common.gypi
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/content_tests.gypi
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/gpu/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/renderer/android/synchronous_compositor_proxy.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/renderer/mus/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/content/renderer/render_view_impl.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/gpu_ipc_client.gypi
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/gpu_ipc_common.gypi
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/gpu_ipc_service.gypi
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/client/DEPS
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/client/command_buffer_proxy_impl.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/client/gpu_channel_host.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/common/DEPS
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/common/gpu_messages.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/service/DEPS
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/service/gpu_channel_manager_delegate.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/service/gpu_command_buffer_stub.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/service/image_transport_surface_overlay_mac.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/gpu/ipc/service/pass_through_image_transport_surface.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/BUILD.gn
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/DEPS
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/OWNERS
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/blink/events_blink.gyp
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/event.h
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/events.gyp
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/events/events_unittests.gyp
[delete] https://crrev.com/6d5e4d58e003fa8c977fc4f1ffc177fc868b0c19/ui/events/ipc/OWNERS
[delete] https://crrev.com/6d5e4d58e003fa8c977fc4f1ffc177fc868b0c19/ui/events/ipc/events_ipc_export.h
[delete] https://crrev.com/6d5e4d58e003fa8c977fc4f1ffc177fc868b0c19/ui/events/ipc/latency_info_param_traits.h
[add] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/BUILD.gn
[add] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/OWNERS
[rename] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/ipc/BUILD.gn
[add] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/ipc/OWNERS
[add] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/ipc/latency_info_ipc_export.h
[rename] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/ipc/latency_info_param_traits.cc
[add] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/ipc/latency_info_param_traits.h
[rename] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/ipc/latency_info_param_traits_macros.h
[rename] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/ipc/latency_info_param_traits_unittest.cc
[rename] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/latency_info.cc
[rename] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/latency_info.dot
[add] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/latency_info.gyp
[rename] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/latency_info.h
[add] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/latency_info_export.h
[rename] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/latency_info_unittest.cc
[add] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/latency_info/latency_info_unittests.gyp
[modify] https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993/ui/views/views.gyp

Comment 2 by vabr@chromium.org, Apr 13 2016

Unfortunately, this seems to have broken compilation on Win GN bots:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/20252
and
https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/23543

Sample log attached.
win_gn_compile.html
899 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab57159df92cf956577149ce8d5c482e4c53a01b

commit ab57159df92cf956577149ce8d5c482e4c53a01b
Author: vabr <vabr@chromium.org>
Date: Wed Apr 13 07:27:30 2016

Revert of Move LatencyInfo to ui/latency_info (patchset #14 id:260001 of https://codereview.chromium.org/1871233002/ )

Reason for revert:
Highly suspected of breaking Win GN build. More details in  http://crbug.com/601871#c2 .

Today's sheriff

Original issue's description:
> Move LatencyInfo to ui/latency_info
>
> Components such as cc/ and gpu/ that depend on ui::LatencyInfo
> should not pull in all of ui/events.
>
> This CL pulls ui::LatencyInfo into a separate component to
> simplify this dependency. cc/ and gpu/ no longer depend on
> ui/events.
>
> BUG= 601871 
> TBR=jam@chromium.org for top level BUILD.gn and build/all.gyp
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993
> Cr-Commit-Position: refs/heads/master@{#386889}

TBR=tdresser@chromium.org,sky@chromium.org,piman@chromium.org,dcheng@chromium.org,jam@chromium.org,fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 601871 

Review URL: https://codereview.chromium.org/1883763002

Cr-Commit-Position: refs/heads/master@{#386930}

[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/build/all.gyp
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/cc/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/cc/DEPS
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/cc/cc.gyp
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/cc/cc_tests.gyp
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/cc/output/compositor_frame_metadata.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/cc/output/latency_info_swap_promise.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/cc/surfaces/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/cc/surfaces/display.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/DEPS
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/android/in_process/synchronous_input_event_filter.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/compositor/image_transport_factory.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/loader/resource_scheduler_unittest.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/input/render_widget_host_latency_tracker.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/input/synthetic_tap_gesture.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/input/touch_action_browsertest.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/input/touch_input_browsertest.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/common/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/common/accelerated_surface_buffers_swapped_params_mac.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/common/gpu_host_messages.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/common/input/input_event.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/common/input/input_event_ack.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/common/input_messages.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/content_browser.gypi
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/content_common.gypi
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/content_tests.gypi
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/gpu/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/renderer/android/synchronous_compositor_proxy.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/renderer/mus/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/content/renderer/render_view_impl.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/gpu_ipc_client.gypi
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/gpu_ipc_common.gypi
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/gpu_ipc_service.gypi
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/client/DEPS
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/client/command_buffer_proxy_impl.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/client/gpu_channel_host.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/common/DEPS
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/common/gpu_messages.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/service/DEPS
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/service/gpu_channel_manager_delegate.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/service/gpu_command_buffer_stub.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/service/image_transport_surface_overlay_mac.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/gpu/ipc/service/pass_through_image_transport_surface.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/BUILD.gn
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/DEPS
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/OWNERS
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/blink/events_blink.gyp
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/event.h
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/events.gyp
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/events_unittests.gyp
[rename] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/ipc/BUILD.gn
[add] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/ipc/OWNERS
[add] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/ipc/events_ipc_export.h
[rename] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/ipc/latency_info_param_traits.cc
[add] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/ipc/latency_info_param_traits.h
[rename] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/ipc/latency_info_param_traits_macros.h
[rename] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/ipc/latency_info_param_traits_unittest.cc
[rename] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/latency_info.cc
[rename] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/latency_info.dot
[rename] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/latency_info.h
[rename] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/events/latency_info_unittest.cc
[delete] https://crrev.com/ecc943fa4864fba6fb9974f088a8c96c70810dac/ui/latency_info/BUILD.gn
[delete] https://crrev.com/ecc943fa4864fba6fb9974f088a8c96c70810dac/ui/latency_info/OWNERS
[delete] https://crrev.com/ecc943fa4864fba6fb9974f088a8c96c70810dac/ui/latency_info/ipc/OWNERS
[delete] https://crrev.com/ecc943fa4864fba6fb9974f088a8c96c70810dac/ui/latency_info/ipc/latency_info_ipc_export.h
[delete] https://crrev.com/ecc943fa4864fba6fb9974f088a8c96c70810dac/ui/latency_info/ipc/latency_info_param_traits.h
[delete] https://crrev.com/ecc943fa4864fba6fb9974f088a8c96c70810dac/ui/latency_info/latency_info.gyp
[delete] https://crrev.com/ecc943fa4864fba6fb9974f088a8c96c70810dac/ui/latency_info/latency_info_export.h
[delete] https://crrev.com/ecc943fa4864fba6fb9974f088a8c96c70810dac/ui/latency_info/latency_info_unittests.gyp
[modify] https://crrev.com/ab57159df92cf956577149ce8d5c482e4c53a01b/ui/views/views.gyp

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cc1dcccd28336397a468d1d5caa3be92675b456

commit 7cc1dcccd28336397a468d1d5caa3be92675b456
Author: fsamuel <fsamuel@chromium.org>
Date: Wed Apr 13 15:12:18 2016

Move LatencyInfo to ui/latency_info

Components such as cc/ and gpu/ that depend on ui::LatencyInfo
should not pull in all of ui/events.

This CL pulls ui::LatencyInfo into a separate component to
simplify this dependency. cc/ and gpu/ no longer depend on
ui/events.

BUG= 601871 
TBR=jam@chromium.org for top level BUILD.gn and build/all.gyp
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993
Cr-Commit-Position: refs/heads/master@{#386889}

Review URL: https://codereview.chromium.org/1871233002

Cr-Commit-Position: refs/heads/master@{#386992}

[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/build/all.gyp
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/cc/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/cc/DEPS
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/cc/cc.gyp
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/cc/cc_tests.gyp
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/cc/output/compositor_frame_metadata.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/cc/output/latency_info_swap_promise.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/cc/surfaces/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/cc/surfaces/display.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/DEPS
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/android/in_process/synchronous_input_event_filter.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/compositor/image_transport_factory.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/loader/resource_scheduler_unittest.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/input/render_widget_host_latency_tracker.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/input/synthetic_tap_gesture.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/input/touch_action_browsertest.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/input/touch_input_browsertest.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/common/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/common/accelerated_surface_buffers_swapped_params_mac.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/common/gpu_host_messages.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/common/input/input_event.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/common/input/input_event_ack.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/common/input_messages.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/content_browser.gypi
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/content_common.gypi
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/content_tests.gypi
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/gpu/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/renderer/android/synchronous_compositor_proxy.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/renderer/mus/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/content/renderer/render_view_impl.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/gpu_ipc_client.gypi
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/gpu_ipc_common.gypi
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/gpu_ipc_service.gypi
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/client/DEPS
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/client/command_buffer_proxy_impl.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/client/gpu_channel_host.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/common/DEPS
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/common/gpu_messages.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/service/DEPS
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/service/gpu_channel_manager_delegate.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/service/gpu_command_buffer_stub.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/service/image_transport_surface_overlay_mac.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/gpu/ipc/service/pass_through_image_transport_surface.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/DEPS
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/OWNERS
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/blink/events_blink.gyp
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/event.h
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/events.gyp
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/events/events_unittests.gyp
[delete] https://crrev.com/2dc73f8953c6f555724dcf40df971d690bc4acf8/ui/events/ipc/OWNERS
[delete] https://crrev.com/2dc73f8953c6f555724dcf40df971d690bc4acf8/ui/events/ipc/events_ipc_export.h
[delete] https://crrev.com/2dc73f8953c6f555724dcf40df971d690bc4acf8/ui/events/ipc/latency_info_param_traits.h
[add] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/BUILD.gn
[add] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/OWNERS
[rename] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/ipc/BUILD.gn
[add] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/ipc/OWNERS
[add] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/ipc/latency_info_ipc_export.h
[rename] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/ipc/latency_info_param_traits.cc
[add] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/ipc/latency_info_param_traits.h
[rename] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/ipc/latency_info_param_traits_macros.h
[rename] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/ipc/latency_info_param_traits_unittest.cc
[rename] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/latency_info.cc
[rename] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/latency_info.dot
[add] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/latency_info.gyp
[rename] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/latency_info.h
[add] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/latency_info_export.h
[rename] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/latency_info_unittest.cc
[add] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/latency_info/latency_info_unittests.gyp
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/views/BUILD.gn
[modify] https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456/ui/views/views.gyp

Components: Internals>Input
Labels: -Pri-3 mustash1 mustash mus OS-All Pri-2
Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
This is done but I'll leave it open for a day or two to make sure the patch sticks. I'll close this by Friday evening.
Status: Fixed (was: Assigned)
This has stuck for a while so I'm fairly confident it'll continue to stick. Marking as FIXED.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d6e129498c0bf89ae1461b8930aceb05baaf078

commit 9d6e129498c0bf89ae1461b8930aceb05baaf078
Author: Nico Weber <thakis@chromium.org>
Date: Tue Apr 19 18:51:09 2016

Revert https://codereview.chromium.org/1871233002 -- Move LatencyInfo to ui/latency_info

It broke linking most test binaries in release component
builds on Windows ( http://crbug.com/601871 )

BUG= 601871 
R=fsamuel@chromium.org
TBR=fsamuel
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1898033003 .

Cr-Commit-Position: refs/heads/master@{#388261}

[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/build/all.gyp
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/cc/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/cc/DEPS
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/cc/cc.gyp
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/cc/cc_tests.gyp
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/cc/output/compositor_frame_metadata.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/cc/output/latency_info_swap_promise.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/cc/surfaces/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/cc/surfaces/display.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/DEPS
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/android/in_process/synchronous_input_event_filter.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/compositor/image_transport_factory.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/loader/resource_scheduler_unittest.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/input/render_widget_host_latency_tracker.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/input/synthetic_tap_gesture.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/input/touch_action_browsertest.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/input/touch_input_browsertest.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/common/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/common/accelerated_surface_buffers_swapped_params_mac.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/common/gpu_host_messages.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/common/input/input_event.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/common/input/input_event_ack.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/common/input_messages.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/content_browser.gypi
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/content_common.gypi
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/content_tests.gypi
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/gpu/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/renderer/android/synchronous_compositor_proxy.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/renderer/mus/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/content/renderer/render_view_impl.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/gpu_ipc_client.gypi
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/gpu_ipc_common.gypi
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/gpu_ipc_service.gypi
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/client/DEPS
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/client/command_buffer_proxy_impl.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/client/gpu_channel_host.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/common/DEPS
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/common/gpu_messages.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/service/DEPS
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/service/gpu_channel_manager_delegate.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/service/gpu_command_buffer_stub.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/service/image_transport_surface_overlay_mac.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/gpu/ipc/service/pass_through_image_transport_surface.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/DEPS
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/OWNERS
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/blink/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/blink/events_blink.gyp
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/event.h
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/events.gyp
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/events_unittests.gyp
[rename] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/ipc/BUILD.gn
[add] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/ipc/OWNERS
[add] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/ipc/events_ipc_export.h
[rename] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/ipc/latency_info_param_traits.cc
[add] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/ipc/latency_info_param_traits.h
[rename] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/ipc/latency_info_param_traits_macros.h
[rename] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/ipc/latency_info_param_traits_unittest.cc
[rename] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/latency_info.cc
[rename] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/latency_info.dot
[rename] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/latency_info.h
[rename] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/events/latency_info_unittest.cc
[delete] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/ui/latency_info/BUILD.gn
[delete] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/ui/latency_info/OWNERS
[delete] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/ui/latency_info/ipc/OWNERS
[delete] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/ui/latency_info/ipc/latency_info_ipc_export.h
[delete] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/ui/latency_info/ipc/latency_info_param_traits.h
[delete] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/ui/latency_info/latency_info.gyp
[delete] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/ui/latency_info/latency_info_export.h
[delete] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/ui/latency_info/latency_info_unittests.gyp
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/views/BUILD.gn
[modify] https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078/ui/views/views.gyp

Labels: gpurefactor
Status: Assigned (was: Fixed)
This was reverted a couple of weeks ago. Reopening...

Note that is the blocker for consolidating all gpu traits into a single target.
Labels: -Pri-2 Pri-3
I'm marking this as a P3. I think this is a nice-to-have, and not a Mus+Ash blocker.
Blocking: -601863
T
Status: WontFix (was: Assigned)
This is largely not worth having a bug for at this point. Marking as WontFix. We can revisit if we need to.

Sign in to add a comment