New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 601868 link

Starred by 4 users
Status: Fixed
Owner:
sadrul@chromium.org
Closed: May 2016
Cc:
█ vollick@chromium.org
penghuang@chromium.org
█ markdittmer@chromium.org
rjkroege@chromium.org
vmi...@chromium.org
sadrul@chromium.org
piman@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
mus



Sign in to add a comment

*OverlayCandidateValidator* => components/display_compositor

Project Member Reported by fsam...@chromium.org, Apr 8 2016 
This code is not necessarily browser specific so we can drop the browser prefix. There's a single gpu dependency:

#include "gpu/config/gpu_driver_bug_workaround_type.h"

in browser_compositor_overlay_candidate_validator_mac.mm.

We need to do something about that.

Comment 1 by fsam...@chromium.org, Apr 8 2016

Blocking: 601863
Cc: markdittmer@chromium.org penghuang@chromium.org

Comment 2 by fsam...@chromium.org, Apr 18 2016

Components: MUS
Labels: mustash1 displaycompositor mustash mus OS-All

Comment 3 by fsam...@chromium.org, Apr 22 2016

Owner: rjkroege@chromium.org
Status: Assigned (was: Untriaged)
Summary: *OverlayCandidateValidator* => components/display_compositor (was: *OverlayCandidateValidator* => ui/gfx?)
I think we decided this makes more sense in components/display_compositor. Let's rename it to DisplayCompositorOverlayCandidateValidator*

Comment 4 by fsam...@chromium.org, Apr 27 2016

Owner: sadrul@chromium.org

Comment 5 by fsam...@chromium.org, Apr 27 2016 

Note that components/display_compositor can depend on gpu so gpu/config dependency shouldn't matter.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/799b83d6b29d3069a9fa40d563103e1beeea8ef4

commit 799b83d6b29d3069a9fa40d563103e1beeea8ef4
Author: sadrul <sadrul@chromium.org>
Date: Fri Apr 29 01:41:11 2016

[mac] Remove dependencies from BrowserCompositorOverlayCandidateValidatorMac.

Tell BrowserCompositorOverlayCandidateValidatorMac about CALayer support, so
that it doesn't have to depend on GpuDataManagerImpl or the cmdline switches.

BUG= 601868 

Review-Url: https://codereview.chromium.org/1926973003
Cr-Commit-Position: refs/heads/master@{#390562}

[modify] https://crrev.com/799b83d6b29d3069a9fa40d563103e1beeea8ef4/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.h
[modify] https://crrev.com/799b83d6b29d3069a9fa40d563103e1beeea8ef4/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
[modify] https://crrev.com/799b83d6b29d3069a9fa40d563103e1beeea8ef4/content/browser/compositor/gpu_process_transport_factory.cc

Comment 7 by sadrul@chromium.org, Apr 29 2016

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, May 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883

commit e71355bc5dd3f42af151dc7b7c973fdc8cd1e883
Author: sadrul <sadrul@chromium.org>
Date: Tue May 03 14:48:09 2016

display_compositor: Move CompositorOverlayCandidateValidator from content.

Remove Browser prefix from BrowserCompositorOverlayCandidateValidator,
and move it (and the implementations) into //components/display_compositor/
from //content/browser/compositor/.

BUG= 601868 

Review-Url: https://codereview.chromium.org/1931213002
Cr-Commit-Position: refs/heads/master@{#391233}

[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor.gypi
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/BUILD.gn
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/DEPS
[add] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/compositor_overlay_candidate_validator.h
[rename] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/compositor_overlay_candidate_validator_android.cc
[add] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/compositor_overlay_candidate_validator_android.h
[add] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/compositor_overlay_candidate_validator_mac.h
[add] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/compositor_overlay_candidate_validator_mac.mm
[rename] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/compositor_overlay_candidate_validator_ozone.cc
[add] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/components/display_compositor/compositor_overlay_candidate_validator_ozone.h
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/BUILD.gn
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/browser_compositor_output_surface.cc
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/browser_compositor_output_surface.h
[delete] https://crrev.com/de8272afe52ff8f21b792aebc892ae347e8a7b5b/content/browser/compositor/browser_compositor_overlay_candidate_validator.h
[delete] https://crrev.com/de8272afe52ff8f21b792aebc892ae347e8a7b5b/content/browser/compositor/browser_compositor_overlay_candidate_validator_android.h
[delete] https://crrev.com/de8272afe52ff8f21b792aebc892ae347e8a7b5b/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.h
[delete] https://crrev.com/de8272afe52ff8f21b792aebc892ae347e8a7b5b/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
[delete] https://crrev.com/de8272afe52ff8f21b792aebc892ae347e8a7b5b/content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.h
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/gpu_browser_compositor_output_surface.cc
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/gpu_browser_compositor_output_surface.h
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/offscreen_browser_compositor_output_surface.cc
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/offscreen_browser_compositor_output_surface.h
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883/content/content_browser.gypi
Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0120d89ab36da66b9c04bc8538a6ee83c6c85a09

commit 0120d89ab36da66b9c04bc8538a6ee83c6c85a09
Author: sadrul <sadrul@chromium.org>
Date: Tue May 03 19:46:20 2016

display-compositor: Add missing dependencies for ozone in gyp.

BUG= 608813 ,  601868 

Review-Url: https://codereview.chromium.org/1948573002
Cr-Commit-Position: refs/heads/master@{#391329}

[modify] https://crrev.com/0120d89ab36da66b9c04bc8538a6ee83c6c85a09/components/display_compositor.gypi

Comment 10 by fsam...@chromium.org, May 7 2016 

Mark as Fixed?

Comment 11 by sadrul@chromium.org, May 7 2016

Status: Fixed (was: Started)

Comment 12 by fsam...@chromium.org, Jun 13 2017

Blocking: -601863

Comment 13 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment