This should be a straightforward refactor once GLHelper is diced and placed in gpu/ipc/ and media/gpu/ipc.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39399be2c6a0063520d8d9b289e8f7b31e1eb094 commit 39399be2c6a0063520d8d9b289e8f7b31e1eb094 Author: fsamuel <fsamuel@chromium.org> Date: Mon Apr 11 21:35:59 2016 Fix BufferQueue includes content/browser/compostior/buffer_queue.cc unnecessarily included content/browser/compositor/image_transport_factory.h and content/common/gpu/client/context_provider_command_buffer.h BUG= 601867 Review URL: https://codereview.chromium.org/1872063004 Cr-Commit-Position: refs/heads/master@{#386478} [modify] https://crrev.com/39399be2c6a0063520d8d9b289e8f7b31e1eb094/content/browser/compositor/buffer_queue.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0498c8521eeff1478192f1645d49243acec7ee7e commit 0498c8521eeff1478192f1645d49243acec7ee7e Author: fsamuel <fsamuel@chromium.org> Date: Wed Apr 13 23:39:59 2016 Decouple buffer_queue_unittest from content Remove dependencies on GpuSurfacelessBrowserCompositorOutputSurface and BrowserGpuMemoryBufferManager in buffer_queue_unittest to allow it to be refactored out of content/ BUG= 601867 Review URL: https://codereview.chromium.org/1881033003 Cr-Commit-Position: refs/heads/master@{#387148} [modify] https://crrev.com/0498c8521eeff1478192f1645d49243acec7ee7e/content/browser/compositor/buffer_queue_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/454edd4075bbd3ee64fb1126d04d7e7a493f70d9 commit 454edd4075bbd3ee64fb1126d04d7e7a493f70d9 Author: fsamuel <fsamuel@chromium.org> Date: Mon Apr 18 14:56:47 2016 buffer_queue.cc: Remove unnecessary layer-violating include BUG= 601867 TBR=piman@chromium.org Review URL: https://codereview.chromium.org/1895803002 Cr-Commit-Position: refs/heads/master@{#387907} [modify] https://crrev.com/454edd4075bbd3ee64fb1126d04d7e7a493f70d9/content/browser/compositor/buffer_queue.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea767b706b88fbeb77655c2193d593dfef54660a commit ea767b706b88fbeb77655c2193d593dfef54660a Author: fsamuel <fsamuel@chromium.org> Date: Thu Apr 21 00:39:14 2016 Introduce components/display_compositor We would like to share BufferQueue, GLHelper and later other parts of content/browser/compositor in Mus. This CL introduces a new display_compositor component and moves BufferQueue, GLHelper and friends to components/display_compositor. BUG= 601867 TBR=ben@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1902463002 Cr-Commit-Position: refs/heads/master@{#388641} [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/.gn [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/BUILD.gn [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/build/gn_migration.gypi [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/cc/cc_tests.gyp [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/components.gyp [add] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor.gypi [add] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/BUILD.gn [add] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/DEPS [add] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/OWNERS [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/buffer_queue.cc [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/buffer_queue.h [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/buffer_queue_unittest.cc [add] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/display_compositor_export.h [add] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/display_compositor_test_suite.cc [add] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/display_compositor_test_suite.h [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/gl_helper.cc [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/gl_helper.h [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/gl_helper_benchmark.cc [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/gl_helper_readback_support.cc [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/gl_helper_readback_support.h [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/gl_helper_scaling.cc [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/gl_helper_scaling.h [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/gl_helper_unittest.cc [add] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/run_all_unittests.cc [rename] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/components/display_compositor/yuv_readback_unittest.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/BUILD.gn [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/DEPS [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/gpu_process_transport_factory.h [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/image_transport_factory.h [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/image_transport_factory_browsertest.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/owned_mailbox.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/owned_mailbox.h [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/reflector_texture.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/reflector_texture.h [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/surface_utils.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/test/no_transport_image_transport_factory.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/compositor/test/no_transport_image_transport_factory.h [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/media/capture/DEPS [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/media/capture/aura_window_capture_machine.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/media/capture/aura_window_capture_machine.h [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/DEPS [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/delegated_frame_host.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/delegated_frame_host.h [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/media/video_capture_controller.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/content_browser.gypi [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/content_tests.gypi [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/content/test/BUILD.gn [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0 commit 442ab50b0b4a5ca8d8b634d6b79dea960918f1f0 Author: tkent <tkent@chromium.org> Date: Thu Apr 21 01:50:52 2016 Revert of Introduce components/display_compositor (patchset #21 id:390001 of https://codereview.chromium.org/1902463002/ ) Reason for revert: Broke Windows x64 build. c:\b\build\slave\win_x64_builder__dbg_\build\src\components\display_compositor\buffer_queue_unittest.cc(142): error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win_x64_builder__dbg_\build\src\components\display_compositor\buffer_queue_unittest.cc(142): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/20984/steps/compile/logs/stdio Original issue's description: > Introduce components/display_compositor > > We would like to share BufferQueue, GLHelper and later other parts > of content/browser/compositor in Mus. This CL introduces a new > display_compositor component and moves BufferQueue, GLHelper and > friends to components/display_compositor. > > BUG= 601867 > TBR=ben@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=piman@chromium.org,sky@chromium.org,xhwang@chromium.org,ben@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 601867 Review URL: https://codereview.chromium.org/1905863002 Cr-Commit-Position: refs/heads/master@{#388661} [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/.gn [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/BUILD.gn [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/build/gn_migration.gypi [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/cc/cc_tests.gyp [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/components/components.gyp [delete] https://crrev.com/2243d6d6855a7efb494a6383c3d2482bd05c985c/components/display_compositor.gypi [delete] https://crrev.com/2243d6d6855a7efb494a6383c3d2482bd05c985c/components/display_compositor/BUILD.gn [delete] https://crrev.com/2243d6d6855a7efb494a6383c3d2482bd05c985c/components/display_compositor/DEPS [delete] https://crrev.com/2243d6d6855a7efb494a6383c3d2482bd05c985c/components/display_compositor/OWNERS [delete] https://crrev.com/2243d6d6855a7efb494a6383c3d2482bd05c985c/components/display_compositor/display_compositor_export.h [delete] https://crrev.com/2243d6d6855a7efb494a6383c3d2482bd05c985c/components/display_compositor/display_compositor_test_suite.cc [delete] https://crrev.com/2243d6d6855a7efb494a6383c3d2482bd05c985c/components/display_compositor/display_compositor_test_suite.h [delete] https://crrev.com/2243d6d6855a7efb494a6383c3d2482bd05c985c/components/display_compositor/run_all_unittests.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/BUILD.gn [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/DEPS [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/buffer_queue.cc [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/buffer_queue.h [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/buffer_queue_unittest.cc [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gl_helper.cc [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gl_helper.h [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gl_helper_benchmark.cc [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gl_helper_readback_support.cc [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gl_helper_readback_support.h [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gl_helper_scaling.cc [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gl_helper_scaling.h [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gl_helper_unittest.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gpu_process_transport_factory.h [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/image_transport_factory.h [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/image_transport_factory_browsertest.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/owned_mailbox.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/owned_mailbox.h [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/reflector_texture.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/reflector_texture.h [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/surface_utils.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/test/no_transport_image_transport_factory.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/test/no_transport_image_transport_factory.h [rename] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/compositor/yuv_readback_unittest.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/media/capture/DEPS [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/media/capture/aura_window_capture_machine.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/media/capture/aura_window_capture_machine.h [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/DEPS [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/delegated_frame_host.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/delegated_frame_host.h [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/media/video_capture_controller.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/content_browser.gypi [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/content_tests.gypi [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/content/test/BUILD.gn [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/442ab50b0b4a5ca8d8b634d6b79dea960918f1f0/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec03489356fa45add604aaca28f277a0c9f83dee commit ec03489356fa45add604aaca28f277a0c9f83dee Author: fsamuel <fsamuel@chromium.org> Date: Thu Apr 21 02:44:48 2016 Introduce components/display_compositor We would like to share BufferQueue, GLHelper and later other parts of content/browser/compositor in Mus. This CL introduces a new display_compositor component and moves BufferQueue, GLHelper and friends to components/display_compositor. BUG= 601867 TBR=ben@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1902463002 Cr-Commit-Position: refs/heads/master@{#388662} [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/.gn [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/BUILD.gn [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/build/gn_migration.gypi [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/cc/cc_tests.gyp [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/components.gyp [add] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor.gypi [add] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/BUILD.gn [add] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/DEPS [add] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/OWNERS [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/buffer_queue.cc [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/buffer_queue.h [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/buffer_queue_unittest.cc [add] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/display_compositor_export.h [add] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/display_compositor_test_suite.cc [add] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/display_compositor_test_suite.h [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/gl_helper.cc [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/gl_helper.h [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/gl_helper_benchmark.cc [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/gl_helper_readback_support.cc [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/gl_helper_readback_support.h [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/gl_helper_scaling.cc [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/gl_helper_scaling.h [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/gl_helper_unittest.cc [add] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/run_all_unittests.cc [rename] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/components/display_compositor/yuv_readback_unittest.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/BUILD.gn [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/DEPS [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/gpu_process_transport_factory.h [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/image_transport_factory.h [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/image_transport_factory_browsertest.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/owned_mailbox.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/owned_mailbox.h [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/reflector_texture.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/reflector_texture.h [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/surface_utils.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/test/no_transport_image_transport_factory.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/compositor/test/no_transport_image_transport_factory.h [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/media/capture/DEPS [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/media/capture/aura_window_capture_machine.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/media/capture/aura_window_capture_machine.h [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/DEPS [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/delegated_frame_host.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/delegated_frame_host.h [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/media/video_capture_controller.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/content_browser.gypi [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/content_tests.gypi [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/content/test/BUILD.gn [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b844a929a8e624c6391d5efab8aea49bb883874 commit 3b844a929a8e624c6391d5efab8aea49bb883874 Author: thakis <thakis@chromium.org> Date: Thu Apr 21 13:59:39 2016 Revert of Introduce components/display_compositor (patchset #22 id:410001 of https://codereview.chromium.org/1902463002/ ) Reason for revert: This added the new test to some FYI bots (but nowhere else?) and claimed that the binary can run on swarming but it doesn't add a _run target or an isolate file to actually run it on swarming. As a consequence, the FYI bots this added the test to that still use gyp now all fail their "isolate tests" step. Example: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4976 Original issue's description: > Introduce components/display_compositor > > We would like to share BufferQueue, GLHelper and later other parts > of content/browser/compositor in Mus. This CL introduces a new > display_compositor component and moves BufferQueue, GLHelper and > friends to components/display_compositor. > > BUG= 601867 > TBR=ben@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > NOTRY=true > NOTREECHECKS=true TBR=ben@chromium.org,piman@chromium.org,sky@chromium.org,xhwang@chromium.org,tkent@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 601867 Review URL: https://codereview.chromium.org/1904773004 Cr-Commit-Position: refs/heads/master@{#388760} [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/.gn [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/BUILD.gn [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/build/gn_migration.gypi [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/cc/cc_tests.gyp [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/components/components.gyp [delete] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/components/display_compositor.gypi [delete] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/components/display_compositor/BUILD.gn [delete] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/components/display_compositor/DEPS [delete] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/components/display_compositor/OWNERS [delete] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/components/display_compositor/display_compositor_export.h [delete] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/components/display_compositor/display_compositor_test_suite.cc [delete] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/components/display_compositor/display_compositor_test_suite.h [delete] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/components/display_compositor/run_all_unittests.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/BUILD.gn [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/DEPS [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/buffer_queue.cc [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/buffer_queue.h [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/buffer_queue_unittest.cc [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gl_helper.cc [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gl_helper.h [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gl_helper_benchmark.cc [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gl_helper_readback_support.cc [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gl_helper_readback_support.h [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gl_helper_scaling.cc [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gl_helper_scaling.h [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gl_helper_unittest.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gpu_process_transport_factory.h [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/image_transport_factory.h [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/image_transport_factory_browsertest.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/owned_mailbox.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/owned_mailbox.h [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/reflector_texture.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/reflector_texture.h [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/surface_utils.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/test/no_transport_image_transport_factory.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/test/no_transport_image_transport_factory.h [rename] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/compositor/yuv_readback_unittest.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/media/capture/DEPS [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/media/capture/aura_window_capture_machine.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/media/capture/aura_window_capture_machine.h [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/DEPS [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/delegated_frame_host.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/delegated_frame_host.h [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/media/video_capture_controller.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/content_browser.gypi [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/content_tests.gypi [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/content/test/BUILD.gn [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa commit 540b8c11b0418e42e79fa27b84ac4f3c0f7770fa Author: fsamuel <fsamuel@chromium.org> Date: Thu Apr 21 18:47:10 2016 Introduce components/display_compositor We would like to share BufferQueue, GLHelper and later other parts of content/browser/compositor in Mus. This CL introduces a new display_compositor component and moves BufferQueue, GLHelper and friends to components/display_compositor. BUG= 601867 TBR=ben@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1902463002 Cr-Commit-Position: refs/heads/master@{#388829} [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/.gn [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/BUILD.gn [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/build/gn_migration.gypi [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/cc/cc_tests.gyp [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/components.gyp [add] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor.gypi [add] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/BUILD.gn [add] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/DEPS [add] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/OWNERS [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/buffer_queue.cc [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/buffer_queue.h [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/buffer_queue_unittest.cc [add] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/display_compositor_export.h [add] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/display_compositor_test_suite.cc [add] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/display_compositor_test_suite.h [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/gl_helper.cc [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/gl_helper.h [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/gl_helper_benchmark.cc [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/gl_helper_readback_support.cc [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/gl_helper_readback_support.h [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/gl_helper_scaling.cc [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/gl_helper_scaling.h [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/gl_helper_unittest.cc [add] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/run_all_unittests.cc [rename] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/components/display_compositor/yuv_readback_unittest.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/BUILD.gn [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/DEPS [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/gpu_process_transport_factory.h [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/image_transport_factory.h [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/image_transport_factory_browsertest.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/owned_mailbox.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/owned_mailbox.h [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/reflector_texture.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/reflector_texture.h [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/surface_utils.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/test/no_transport_image_transport_factory.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/compositor/test/no_transport_image_transport_factory.h [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/media/capture/DEPS [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/media/capture/aura_window_capture_machine.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/media/capture/aura_window_capture_machine.h [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/DEPS [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/delegated_frame_host.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/delegated_frame_host.h [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/media/video_capture_controller.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/content_browser.gypi [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/content_tests.gypi [modify] https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa/content/test/BUILD.gn
This has stuck for a while so I'm marking as FIXED.
Comment 1 by fsam...@chromium.org
, Apr 8 2016