New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 601848 link

Starred by 3 users
Status: Assigned
Owner:
ericrk@chromium.org
Cc:
bsalo...@google.com
█ mbarowsky+gpuimage@chromium.org
andrescj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Gpu Image Decode Path Should Support yuv

Project Member Reported by ericrk@chromium.org, Apr 8 2016 
Currently, the GPU image decode path doesn't support yuv. In order to add yuv support the Skia API getDeferredTextureImageData will need to be updated to support decoding yuv.

Due to slight rounding differences in the yuv/non-yuv decode paths, turning on the GPU image decode controller causes slight differences in layout tests which used yuv decode. 

This bug tracks re-enabling yuv and updating the layout tests again.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ff2a13b45d39e39e6f6459a736bd03379543d7

commit d2ff2a13b45d39e39e6f6459a736bd03379543d7
Author: ericrk <ericrk@chromium.org>
Date: Mon Apr 11 22:16:00 2016

Adds a GPU version of the ImageDecodeController to the compositor.

This allows us to pre-decode and upload images before raster work
starts, allowing for more parallelism in the GPU composting path.

BUG:  577372 , 601848
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1832573004

Cr-Commit-Position: refs/heads/master@{#386493}

[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/BUILD.gn
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/cc_tests.gyp
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/playback/draw_image.h
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/raster/tile_task_runner.cc
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/raster/tile_task_runner.h
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/raster/tile_task_worker_pool.cc
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/resources/resource_format.cc
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/resources/resource_format.h
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/tiles/gpu_image_decode_controller.cc
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/tiles/gpu_image_decode_controller.h
[add] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/tiles/gpu_image_decode_controller_unittest.cc
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/tiles/image_decode_controller.h
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/tiles/software_image_decode_controller.cc
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/tiles/software_image_decode_controller.h
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/tiles/tile_manager.cc
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/d2ff2a13b45d39e39e6f6459a736bd03379543d7/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c

commit 3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue Apr 12 02:10:08 2016

Auto-rebaseline for r386493

https://chromium.googlesource.com/chromium/src/+/d2ff2a13b

BUG=601848
TBR=ericrk@chromium.org

Review URL: https://codereview.chromium.org/1877033004 .

Cr-Commit-Position: refs/heads/master@{#386554}

[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/image-css3-content-data-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/jpeg-yuv-image-decoding-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/182-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/2-comp-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-image-profile-match-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/exif-orientation-css-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/exif-orientation-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/exif-orientation-image-document-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/gray-scale-jpeg-with-color-profile-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/jpeg-yuv-image-decoding-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/jpeg-yuv-progressive-image-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/ycbcr-with-cmyk-color-profile-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/jpeg-yuv-image-decoding-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/182-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/2-comp-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/exif-orientation-css-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/exif-orientation-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/exif-orientation-image-document-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/gray-scale-jpeg-with-color-profile-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/jpeg-yuv-image-decoding-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/jpeg-yuv-progressive-image-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/ycbcr-with-cmyk-color-profile-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/182-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/2-comp-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-image-profile-match-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/exif-orientation-css-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/exif-orientation-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/exif-orientation-image-document-expected.png
[delete] https://crrev.com/8cf7e53db7f04fe9de1844954397473711b9ce80/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/gray-scale-jpeg-with-color-profile-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/jpeg-yuv-image-decoding-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/jpeg-yuv-progressive-image-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/ycbcr-with-cmyk-color-profile-expected.png
[rename] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/2-comp-expected.png
[add] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/exif-orientation-height-image-document-expected.png
[add] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/gray-scale-jpeg-with-color-profile-expected.png
[modify] https://crrev.com/3aaafbdf37d46fbe78f2842e8ff84b2efef6ac9c/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/image-css3-content-data-expected.png

Comment 3 by ericrk@chromium.org, Jun 22 2016

Labels: -Type-Bug Type-Feature

Comment 4 by ericrk@chromium.org, Feb 6 2017

Owner: ----
Status: Available (was: Untriaged)
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by sunn...@chromium.org, Apr 13 2018

Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
Eric, can you close this bug if it's obsolete?
►

Sign in to add a comment