New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601824 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15.3%-18.7% regression in blink_perf.canvas at 385082:385099

Project Member Reported by rsch...@chromium.org, Apr 8 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=601824

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgyPvesgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgyJ_StwkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-hdd
chromium-rel-mac10
Cc: ccameron@chromium.org
ccameron, I'm wondering if this is 9d291d2f553cdb813de1d1a089b35740bd21a2a9. Would that make sense?
Owner: ccameron@chromium.org

=== Auto-CCing suspected CL author ccameron@chromium.org ===

Hi ccameron@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Mac h264: Decode h264 to 4:2:0 instead of 4:2:2
Author  : ccameron
Commit description:
  
Also remove the OpenGL compatibility key, because it increases power
usage.

This is a slow re-introduction of the previous patch to enable h264
decode to 4:2:0 IOSurfaces, to see where we started causing instability.

BUG= 594452 

Review URL: https://codereview.chromium.org/1851293004

Cr-Commit-Position: refs/heads/master@{#385092}
Commit  : 9d291d2f553cdb813de1d1a089b35740bd21a2a9
Date    : Tue Apr 05 02:49:06 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@385091         2989.66269  25.047477   5           good
chromium@385092         2518.362922 23.579474   5           bad         <-
chromium@385093         2542.967609 9.68187     5           bad
chromium@385095         2509.343513 22.455465   5           bad
chromium@385098         2501.225917 15.910462   5           bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 601824

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blink_perf.canvas
Test Metric: upload-video-to-texture/upload-video-to-texture
Relative Change: 16.34%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2079
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9015930091417933600


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=601824

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Components:
That would make sense.

There is actually a huge regression in correctness and performance in that CL. I have a fix up, but it is still in review.
Cc: ashej...@chromium.org
@ccameron: Is there any update on CL ?

Appreciate your help.

Thank you!
As of r387986, h264 is as good as I expect it to get. If this is still too much of a regression, we can examine where the time is going. But, this is a conscious effort to improve one use case at the expense of another.
Cc: durga.behera@chromium.org
Labels: TE-Triaged
Owner: junov@chromium.org
junov@ : Could you please take a look into this and update, as the alerts are not recovered so far.
Status: WontFix (was: Assigned)
Marking WontFix, as per comment #6.

Sign in to add a comment