Issue metadata
Sign in to add a comment
|
13.1%-72.4% regression in rasterize_and_record_micro.key_mobile_sites_smooth at 385191:385286 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 8 2016
=== Auto-CCing suspected CL author jaydasika@chromium.org === Hi jaydasika@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : cc : Stop calculating visible rects on main thread Author : jaydasika Commit description: Because they are unused outside tests. This CL also stops skipping layers with empty visible rects in record_and_rasterize benchmark because that is more realistic (cc doesn't skip such layers). BUG= 586268 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1855013002 Cr-Commit-Position: refs/heads/master@{#385247} Commit : 0f02fed2f4a7503c715501f74f32b0654fa15c5d Date : Tue Apr 05 19:08:19 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@385235 0.659593 0.002289 5 good chromium@385242 0.662903 0.002654 5 good chromium@385246 0.659959 0.003602 5 good chromium@385247 1.1414 0.00432 5 bad <- chromium@385248 1.141338 0.001619 5 bad chromium@385249 1.140352 0.003203 5 bad Bisect job ran on: android_nexus5_perf_bisect Bug ID: 601805 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests rasterize_and_record_micro.key_silk_cases Test Metric: record_time/record_time Relative Change: 72.89% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3588 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9015935385191810496 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=601805 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Apr 8 2016
This is expected as my CL removed skipping layers with empty visible rects in the benchmark. ajuma : Can we close this ?
,
Apr 8 2016
Yes, this was a change to make the test more realistic, so there's no actual performance regression. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rsch...@chromium.org
, Apr 8 2016