New issue
Advanced search Search tips

Issue 601764 link

Starred by 1 user
Status: WontFix
Owner:
grt@chromium.org
Closed: Apr 2016
Cc:
ajha@chromium.org
mfo...@chromium.org
wfh@chromium.org
vitalyb...@chromium.org
sko...@chromium.org
btolsch@chromium.org
scottmg@chromium.org
dbbrooks@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

"Windows Security alert" shows up on fresh installation of Chrome canary

Project Member Reported by grt@chromium.org, Apr 8 2016 
This is nearly a dup of  issue 593167 , but only affects canary channel at the moment.

The firewall dialog pops up for the "Chrome Media Router (Canary)" (pkedcjkdefgpdelpbcmbmeomcjbeemfm) extension when its DIAL listener is added (callstack below). Can this case be handled in a similar way to the mDNS case?

0:000:x86> k
 # ChildEBP RetAddr  
00 0033e83c 694273bb chrome_691a0000!extensions::DialAPI::OnListenerAdded [c:\b\build\slave\win\build\src\chrome\browser\extensions\api\dial\dial_api.cc @ 60]
01 0033e910 69426e8d chrome_691a0000!extensions::EventRouter::OnListenerAdded+0x74 [c:\b\build\slave\win\build\src\extensions\browser\event_router.cc @ 256]
02 0033e940 6941f297 chrome_691a0000!extensions::EventListenerMap::AddListener+0xbb [c:\b\build\slave\win\build\src\extensions\browser\event_listener_map.cc @ 111]
03 0033e954 6941f11d chrome_691a0000!extensions::EventListenerMap::LoadUnfilteredLazyListeners+0x37 [c:\b\build\slave\win\build\src\extensions\browser\event_listener_map.cc @ 205]
04 0033e974 6941e421 chrome_691a0000!extensions::EventRouter::OnExtensionLoaded+0x33 [c:\b\build\slave\win\build\src\extensions\browser\event_router.cc @ 847]
05 0033e99c 6941d9f6 chrome_691a0000!extensions::ExtensionRegistry::TriggerOnLoaded+0x40 [c:\b\build\slave\win\build\src\extensions\browser\extension_registry.cc @ 54]
06 0033eb40 6941b27b chrome_691a0000!ExtensionService::NotifyExtensionLoaded+0x271 [c:\b\build\slave\win\build\src\chrome\browser\extensions\extension_service.cc @ 1058]
07 0033eb84 6942f86a chrome_691a0000!ExtensionService::AddExtension+0x2fb [c:\b\build\slave\win\build\src\chrome\browser\extensions\extension_service.cc @ 1521]
08 0033ebd0 6942f2e5 chrome_691a0000!extensions::InstalledLoader::Load+0x1d5 [c:\b\build\slave\win\build\src\chrome\browser\extensions\installed_loader.cc @ 236]
09 0033ecb0 69419587 chrome_691a0000!extensions::InstalledLoader::LoadAllExtensions+0x292 [c:\b\build\slave\win\build\src\chrome\browser\extensions\installed_loader.cc @ 296]
0a 0033ed40 693fda76 chrome_691a0000!ExtensionService::Init+0xbd [c:\b\build\slave\win\build\src\chrome\browser\extensions\extension_service.cc @ 428]
0b 0033ef4c 693fd59b chrome_691a0000!extensions::ExtensionSystemImpl::Shared::Init+0x4c3 [c:\b\build\slave\win\build\src\chrome\browser\extensions\extension_system_impl.cc @ 233]
0c 0033ef7c 693fd3e8 chrome_691a0000!extensions::ExtensionSystemImpl::InitForRegularProfile+0x87 [c:\b\build\slave\win\build\src\chrome\browser\extensions\extension_system_impl.cc @ 346]
0d 0033eff4 693fd27c chrome_691a0000!ProfileManager::DoFinalInitForServices+0xc3 [c:\b\build\slave\win\build\src\chrome\browser\profiles\profile_manager.cc @ 1157]
0e 0033f05c 693fce18 chrome_691a0000!ProfileManager::DoFinalInit+0x93 [c:\b\build\slave\win\build\src\chrome\browser\profiles\profile_manager.cc @ 1115]
0f 0033f0d8 692be376 chrome_691a0000!ProfileManager::AddProfile+0xe4 [c:\b\build\slave\win\build\src\chrome\browser\profiles\profile_manager.cc @ 1309]
10 0033f154 692be0a7 chrome_691a0000!ProfileManager::CreateAndInitializeProfile+0xbb [c:\b\build\slave\win\build\src\chrome\browser\profiles\profile_manager.cc @ 1330]
11 0033f17c 692bddda chrome_691a0000!ProfileManager::GetProfile+0x76 [c:\b\build\slave\win\build\src\chrome\browser\profiles\profile_manager.cc @ 429]
12 0033f290 692a77e2 chrome_691a0000!`anonymous namespace'::CreatePrimaryProfile+0x192 [c:\b\build\slave\win\build\src\chrome\browser\chrome_browser_main.cc @ 401]
13 0033f7c4 692a708b chrome_691a0000!ChromeBrowserMainParts::PreMainMessageLoopRunImpl+0x717 [c:\b\build\slave\win\build\src\chrome\browser\chrome_browser_main.cc @ 1501]

Comment 1 by grt@chromium.org, Apr 8 2016 

Ah, maybe this doesn't repro on a fresh profile. Preliminary testing with one doesn't show the firewall dialog.

Comment 2 by w...@chromium.org, Apr 9 2016

Labels: Needs-Feedback
Owner: grt@chromium.org
The circumstances under which you may get a confusing unsolicited firewall prompt are:
1. You had previously run Chrome with Media Router enabled.
2. You deleted the firewall rule that Windows created when it prompted you, way-back-when.

At this point your profile is configured to automatically register mDNS interest on behalf of Media Router, but you have no firewall rules at all for Chrome, so Windows prompts.

If you hadn't deleted any firewall rules then it's worrying that you'd see this; suggests that there may be some subtlety in the Chrome installation dance, for example, causing a newly-installed chrome.exe loading your existing profile to see the note to start mDNS, but not to have a firewall exception, maybe?

Would also like to know how you grabbed that stack - what was the event that you hooked to break into the process in this case?  Thanks.

Comment 3 by grt@chromium.org, Apr 12 2016

Status: WontFix (was: Assigned)
This must have been with a profile that had previously had MR enabled, so false alarm.

I grabbed the stack by repeatedly running Chrome in windbg, first with a breakpoint on net::UDPSocketWin::Bind, then working my way backward through the various tasks being posted until I found what looked like the initial task that kicked things off.

Comment 4 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment