Be able to show which event listeners are passive or not.
Attached are screenshots of proposed behavior.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33 commit ed3f93d1f6149e0861bd9df3dedabc84f2d28d33 Author: dtapuska <dtapuska@chromium.org> Date: Sat Apr 09 03:28:06 2016 Modify devtools to show passive event listeners. Add the ability to filter out what event listeners based on dispatch type; [All, Passive, Blocking]. Add the listing of passive in the event listener list similar to how useCapture is shown. BUG= 601756 Review URL: https://codereview.chromium.org/1845493004 Cr-Commit-Position: refs/heads/master@{#386281} [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker-expected.txt [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners.html [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-custom-framework-expected.txt [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-custom-framework.html [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery1-expected.txt [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery2-expected.txt [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar.html [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/LayoutTests/inspector/elements/event-listeners-about-blank.html [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/devtools/protocol.json [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/ed3f93d1f6149e0861bd9df3dedabc84f2d28d33/third_party/WebKit/Source/platform/v8_inspector/public/V8EventListenerInfo.h
Your change meets the bar and is auto-approved for M51 (branch: 2704)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8832dde5b6d2334386d584ac0b4fb765fa9e331 commit f8832dde5b6d2334386d584ac0b4fb765fa9e331 Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Apr 13 01:10:51 2016 Modify devtools to show passive event listeners. Add the ability to filter out what event listeners based on dispatch type; [All, Passive, Blocking]. Add the listing of passive in the event listener list similar to how useCapture is shown. BUG= 601756 Review URL: https://codereview.chromium.org/1845493004 Cr-Commit-Position: refs/heads/master@{#386281} (cherry picked from commit ed3f93d1f6149e0861bd9df3dedabc84f2d28d33) Review URL: https://codereview.chromium.org/1879293002 . Cr-Commit-Position: refs/branch-heads/2704@{#22} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker-expected.txt [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners.html [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-custom-framework-expected.txt [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-custom-framework.html [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery1-expected.txt [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery2-expected.txt [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar.html [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/LayoutTests/inspector/elements/event-listeners-about-blank.html [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/devtools/protocol.json [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/f8832dde5b6d2334386d584ac0b4fb765fa9e331/third_party/WebKit/Source/platform/v8_inspector/public/V8EventListenerInfo.h
Comment 1 by dtapu...@chromium.org
, Apr 8 201625.3 KB
25.3 KB View Download
50.1 KB
50.1 KB View Download
37.1 KB
37.1 KB View Download