New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 601738 link

Starred by 10 users
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Apr 2016
Cc:
shuchen@chromium.org
█ sshruthi@chromium.org
tapted@chromium.org
erikc...@chromium.org
█ ashej...@chromium.org
█ shrike@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Can't use any IME on any web page

Reported by m...@kytse.com, Apr 8 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2702.2 Safari/537.36

Steps to reproduce the problem:
1. add some IME to you OS X, such as Sucheng (Chinese)
2. go to google.com
3. switch to Sucheng Input Source
4. press  "c" then press "r"

What is the expected behavior?
 "金口" is added to the search box and a pop up will be shown next to the input box with a list of Chinese characters with Sucheng input code "cr"

What went wrong?
The character list is not shown, only the characters, "金口", is added to the search box.

Did this work before? N/A 

Chrome version: 51.0.2702.2  Channel: n/a
OS Version: OS X 10.11.4
Flash Version: Shockwave Flash 21.0 r0

The address bar has the correct behavior, as you can see in 6.10.46.png; however, the search bar shown in 6.11.19.png has no character list shown, and the Sucheng is not usable at all...

I did try some other IMEs, such as Japanese, and they are affected too
Screen Shot 2016-04-08 at 6.11.19 PM.png
29.6 KB View Download
Screen Shot 2016-04-08 at 6.10.46 PM.png
27.8 KB View Download

Comment 1 by m...@kytse.com, Apr 8 2016 

FYR, Did this work before? Yes, this bug was introduced to Chrome in these two or three days.

Comment 2 by yukawa@chromium.org, Apr 10 2016

Cc: tapted@chromium.org shuchen@chromium.org shrike@chromium.org
Components: -UI UI>Input>Text>IME
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression

Comment 3 by shrike@chromium.org, Apr 11 2016

Labels: Needs-Feedback
me@ - you added two screenshots bug I'm not sure what to make of them. Do either show the problem? I assume not. Please add a screenshot that shows the problem. I have tried in 51.0.2703.0 and 51.0.2704.2 to reproduce the problem but the character list appears for me in both versions.

Comment 4 by tapted@chromium.org, Apr 11 2016

Labels: -Needs-Feedback ReleaseBlock-Dev
Owner: erikc...@chromium.org
Status: Assigned (was: Unconfirmed)
IME is definitely broken in Canary on the content area

I ran a bisect

You are probably looking for a change made after 385001 (known bad), but no later than 385010 (first known good).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/1b0431b9210795cc8518177aca22776740435382..9eb26a392f97d9d324bd6bddd1c0add5b26ab85f

It's likely

4bdf946 mac: Bump the deployment target to OS X 10.7. by erikchen · 6 days ago -> https://codereview.chromium.org/1847533004

I'll try reverting that at HEAD, (along with  https://codereview.chromium.org/1863513002/ which I know will break the compile otherwise - there might be others)

Comment 5 by tapted@chromium.org, Apr 11 2016

Labels: M-51

Comment 6 by tapted@chromium.org, Apr 11 2016 

Repro for me is
 - In System Preferences -> Language and Region add a CJK Language (e.g. Japanese)
 - Change the keyboard to e.g. Katakana
 - In a text field inside Chrome, type some japanese and press enter, e.g. "konpyu-ta-": コンピューター should appear, not "konpyu-ta-"
Screen Shot 2016-04-11 at 10.33.09 AM.png
66.2 KB View Download

Comment 7 by tapted@chromium.org, Apr 11 2016

Cc: erikc...@chromium.org
Owner: ekaramad@chromium.org
Whoops - screwed up the bisect. Here's the real one

You are probably looking for a change made after 385534 (known good), but no later than 385550 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/59a92a51fe90d2ab15d05ed8caaae769b2c2e13a..fe2dda84ac99039a639e6be859ce087474cad166


This is probably r385537

Browser Side Text Input State Tracking for OOPIF.

Currently, the TextInputStateChanged method is not implemented in RenderWidgetHostViewChildFrame. Conequently, the IME
will not work until this feature is fixed.

This CL implements the text input state tracking through refactoring most of the TextInputStateChanged code to the top-level RenderWidgetHostViewBase. The implementation is
based on FrameTree::GetFocusedFrame() and hence does not apply to non-OOPIF <webview> (RenderWidgetHostViewGuest).

This CL should also fix a previously reported race condition in the palindrome  crbug.com/546645  caused by RenderWidgetHostViewGuest's way of handling TextInputStateChanged.

BUG= 578168 ,  546645 

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1652483002

Comment 8 by ekaramad@chromium.org, Apr 11 2016 

I could reproduce this on Canary and now trying a local build. I think I know what I broke. One blatant error I introduced was the removal of some state tracking in RenderWidgetHostViewMac in CL above which happened after patchset 7 probably due to bad merging.

Comment 9 by shrike@chromium.org, Apr 11 2016 

OK - the steps I was following kept taking me back into the top chrome textfield. Thank you for tracking down the cl.

Once this gets fixed we will need to cherry pick the fix to M51.

Comment 10 by ekaramad@chromium.org, Apr 11 2016 

The issue is what I mentioned in comment 8. This CL will be fixing this:
https://codereview.chromium.org/1878523002/.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46248c7ed4872cffc4ebb0b9da458678f7d7e7a3

commit 46248c7ed4872cffc4ebb0b9da458678f7d7e7a3
Author: ekaramad <ekaramad@chromium.org>
Date: Mon Apr 11 22:56:15 2016

Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the Mac related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG= 601738 

Review URL: https://codereview.chromium.org/1878523002

Cr-Commit-Position: refs/heads/master@{#386504}

[modify] https://crrev.com/46248c7ed4872cffc4ebb0b9da458678f7d7e7a3/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/46248c7ed4872cffc4ebb0b9da458678f7d7e7a3/content/browser/renderer_host/render_widget_host_view_mac.mm

Comment 12 by ekaramad@chromium.org, Apr 11 2016

Labels: Merge-Request-51

Comment 13 by tin...@google.com, Apr 11 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 14 by ligim...@chromium.org, Apr 12 2016 

Please merge your change to M51 branch soon, planning to kick a new build soon.

Comment 15 by rsesek@chromium.org, Apr 12 2016 

 Issue 601818  has been merged into this issue.

Comment 16 by creis@chromium.org, Apr 12 2016 

ligimole@: The fix is in 52.0.2706.0, which hasn't gotten to Canary yet.  That means we can't verify the fix works beyond the local build from ekaramad@, since this is a Mac-only bug.

It's a simple enough fix that we could merge it anyway, but I wanted to check since I consider it risky in general to merge without verifying the fix.  Shall we proceed?

Comment 17 by ekaramad@chromium.org, Apr 12 2016 

Yes this is a Mac only bug and a Mac only fix.
I am working on a merge CL and creis@ is reviewing it.

Comment 18 Deleted

Comment 19 by ligim...@chromium.org, Apr 12 2016 

As per creis@ this patch was tested locally so requested for a merge in M51 Branch.
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 12 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73a3921eff94c55d259dac5d1536a6b4bc88345a

commit 73a3921eff94c55d259dac5d1536a6b4bc88345a
Author: ekaramad <ekaramad@chromium.org>
Date: Tue Apr 12 19:33:54 2016

Add the missing text input state tracking code to RenderWidgetHostViewMac.

Following the fix for crbug.com/578167 (CL 1652483002), a small part of
the Mac related code was removed due to bad merging (after Patch 7).
This CL fixes the issue by storing the new values of text input state in
RenderWidgetHostViewMac as reported by the WebContentsImpl.

BUG= 601738 
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1878523002

Cr-Commit-Position: refs/heads/master@{#386504}
(cherry picked from commit 46248c7ed4872cffc4ebb0b9da458678f7d7e7a3)

Review URL: https://codereview.chromium.org/1880223002

Cr-Commit-Position: refs/branch-heads/2704@{#10}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/73a3921eff94c55d259dac5d1536a6b4bc88345a/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/73a3921eff94c55d259dac5d1536a6b4bc88345a/content/browser/renderer_host/render_widget_host_view_mac.mm

Comment 21 by grim...@gmail.com, Apr 13 2016 

Alhough it seemed fixed on the latest Canary binary,  I still have an issue to input Japanese on Hangout window which is provided by Hangout Extension: https://chrome.google.com/webstore/detail/google-hangouts/nckgahadagoaajjgafhacjanaoiihapd.

When I input a character using IME, the candidate window appears somewhere weired and cannot insert the word I choosen.

Thanks
Screenshot 2016-04-13 17.15.26.png
119 KB View Download

Comment 22 by bbergher@google.com, Apr 13 2016 

The issue I described in  Issue 601818  (accented characters) seems to be fixed in 52.0.2707.0 Canary.

Comment 23 by ranjitkan@chromium.org, Apr 14 2016

Labels: TE-Verified-M51 TE-Verified-51.0.2704.7
Rechecked this on chrome version 51.0.2704.7 on MAC 10.11.4. Fix is working as intended.  The pop up is shown next to the input box. Attached screen shot for the same.

Adding TE-verified labels.
屏幕快照 2016-04-14 上午10.48.34.png
141 KB View Download

Comment 24 by grim...@gmail.com, Apr 15 2016 

I confimed the issue reported at #21 was fixed. Thanks!

Comment 25 by ekaramad@chromium.org, Apr 15 2016

Status: Fixed (was: Assigned)
Closing this bug as it is apparently fixed.

Comment 26 by shuchen@chromium.org, Apr 15 2016

Status: Assigned (was: Fixed)
The fix is not complete per #21. And I can repro it with Chinese Pinyin IME.

Comment 27 by shrike@chromium.org, Apr 15 2016 

shuchen＠ - is the behavior different than in M49? When I got the suggestions window to appear it was also far away from where I was typing.

Comment 28 by shuchen@chromium.org, Apr 15 2016 

This is a regression in M51. In M49/M50, even the suggestion window is not aligned with the cursor/composition, the text can still be inserted.
But now in M51/M52, the text cannot be inserted.

Comment 29 by ekaramad@chromium.org, Apr 15 2016 

Working on reverting the original CL along with the fixes the followed.
(original CL https://codereview.chromium.org/1652483002/).
Project Member

Comment 30 by bugdroid1@chromium.org, Apr 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c

commit 6bb171a404c2e9a951a1c8c980fc316da4b7fd7c
Author: ekaramad <ekaramad@chromium.org>
Date: Fri Apr 15 22:09:36 2016

Revert of Browser Side Text Input State Tracking for OOPIF (Manual).

The original patch (https://codereview.chromium.org/1652483002/) led to
many regressions. This CL is a manual revert of that patch, plus several
dependent CLs that landed subsequently.

Revert "Browser Side Text Input State Tracking for OOPIF."
This reverts commit 2bd4a2f0c0f114979d47f4498ea1bce9b091591e.

Revert "Disable WebViewTextInputStateInteractiveTest.TopLevelWebContentsTracksCorrectly on Win"
This reverts commit ce2d8a33e2f0b9c742a67ba47618eb9e9172d825.

Revert "Disable WebViewTextInputStateInteractiveTest.TopLevelWebContentsTracksCorrectly on Mac"
This reverts commit 83e4dfa6bc12f0fb1a5da73fc82f19776a158c75.

Revert "Initialize TextInputState::TextInputState::show_ime_if_needed in the constructor."
This reverts commit 0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f.

Revert "Add the missing text input state tracking code to RenderWidgetHostViewMac."
This reverts commit 46248c7ed4872cffc4ebb0b9da458678f7d7e7a3.

Revert "Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from Delegate"
This reverts commit 5292d041d34d49e8c3e851a0e21504a983e5be57.

BUG= 578168 ,  546645 ,  601570 ,  601738 ,  602144 ,  602488 , 602926,  602954 , 603209,  603676 , 603886
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1889313002

Cr-Commit-Position: refs/heads/master@{#387715}

[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/background.js
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/guest.html
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/manifest.json
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.html
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/DEPS
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/interstitial_page_impl.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mus.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mus.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/site_per_process_browsertest.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/web_contents/web_contents_impl.h
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/content/common/text_input_state.cc
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/content/common/text_input_state.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/common/view_messages.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/content_common.gypi
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/public/test/browser_test_utils.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/renderer/render_widget.cc
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/content/test/data/textinput/page_with_input.html
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/content/test/data/textinput/page_with_input_iframeX2_input.html
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/test/test_render_view_host.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/test/test_render_view_host.h

Comment 31 by shrike@chromium.org, Apr 16 2016

Labels: -TE-Verified-M51 -TE-Verified-51.0.2704.7
The reverted change was merged into M51 (branch: 2704), so that needs to be reverted as well.
Project Member

Comment 32 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46b778341feee9da0294c6138d860ad20dffca90

commit 46b778341feee9da0294c6138d860ad20dffca90
Author: ekaramad <ekaramad@chromium.org>
Date: Mon Apr 18 20:44:49 2016

Revert "Browser Side Text Input State Tracking for OOPIF."

The original patch (https://codereview.chromium.org/1652483002/) led to
many regressions. This CL is a manual revert of that patch, plus several
dependent CLs that landed subsequently.

Revert "Browser Side Text Input State Tracking for OOPIF."
This reverts commit 2bd4a2f0c0f114979d47f4498ea1bce9b091591e.

Revert "Initialize TextInputState::TextInputState::show_ime_if_needed in the constructor."
This reverts commit 0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f.

Revert "Add the missing text input state tracking code to RenderWidgetHostViewMac."
This reverts commit 73a3921eff94c55d259dac5d1536a6b4bc88345a.

BUG= 578168 ,  546645 ,  601424 ,  601570 ,  601738 ,  602144 ,  602488 , 602926,  602954 , 603209,  603676 , 603886
NOTRY=true
NOPRESUBMIT=true

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1898803002

Cr-Commit-Position: refs/branch-heads/2704@{#108}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/background.js
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/guest.html
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/manifest.json
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.html
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/DEPS
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/interstitial_page_impl.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mus.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mus.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/site_per_process_browsertest.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/web_contents/web_contents_impl.h
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/content/common/text_input_state.cc
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/content/common/text_input_state.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/common/view_messages.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/content_common.gypi
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/public/test/browser_test_utils.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/renderer/render_widget.cc
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/content/test/data/textinput/page_with_input.html
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/content/test/data/textinput/page_with_input_iframeX2_input.html
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/test/test_render_view_host.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/test/test_render_view_host.h

Comment 33 by ashej...@chromium.org, Apr 19 2016

Cc: ashej...@chromium.org
Labels: TE-Verified-M51 TE-Verified-51.0.2704.19
Retested the above issue on Mac 10.11.4 on chrome version '51.0.2704.19' and it is working as intended. Hence marking the same as TE-Verified-51.0.2704.19.

Attach is the print-screen for the same.

Thank you!
Retest-601738 at 下午3.54.35.png
45.5 KB View Download

Comment 34 by durga.behera@chromium.org, Apr 25 2016 

ekaramad@ : Could you please update the issue status if the above comment # 33 holds good.

Comment 35 by ekaramad@chromium.org, Apr 25 2016

Status: Fixed (was: Assigned)
Since the initial CL causing the regression is fixed, and according to #33 and local testing there he IME seems worked fine on Mac I am closing this bug.

The remaining issue is comment #21. Is it still reproducible? Should we track it in a different bug?
►

Sign in to add a comment