New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601737 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Security



Sign in to add a comment

content/ should destroy ImageDownloaderImpl() before shutting down Blink

Project Member Reported by tyoshino@chromium.org, Apr 8 2016

Issue description

Branched from  crbug.com/588566 

ImageDownloaderImpl() is using an AssociatedURLLoader(). So, before Blink is shutdown, ImageDownLoaderImpl() should cancel active loaders.

 

Comment 1 by kenrb@chromium.org, Apr 8 2016

Labels: Security_Severity-Low Security_Impact-Stable Restrict-View-SecurityTeam

Comment 2 by leon....@intel.com, Apr 9 2016

Cc: -leon....@intel.com
Owner: leon....@intel.com
Status: Started (was: Available)
Cc: haraken@chromium.org
Short-term fix has been landed: https://codereview.chromium.org/1862073002/
Long-term fix for ImageDownloaderImpl is ready at https://codereview.chromium.org/1873003002/.

I'd like to continue merging the short-term fix at  bug 588566  so that even if there's any other class doing similar they're also short-term-fixed.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0173cb77f8a5771bc9f27b570149436707626f7

commit d0173cb77f8a5771bc9f27b570149436707626f7
Author: leon.han <leon.han@intel.com>
Date: Mon Apr 11 05:41:32 2016

Ensure all AssociatedURLLoader be cancelled before shutting down Blink.

ImageDownloaderImpl is using AssociatedURLLoader, all active
AssociatedURLLoader must be cancelled before shutting down Blink.

BUG= 601737 

Review URL: https://codereview.chromium.org/1873003002

Cr-Commit-Position: refs/heads/master@{#386338}

[modify] https://crrev.com/d0173cb77f8a5771bc9f27b570149436707626f7/content/renderer/image_downloader/image_downloader_impl.cc
[modify] https://crrev.com/d0173cb77f8a5771bc9f27b570149436707626f7/content/renderer/image_downloader/image_downloader_impl.h

We might want to also merge r386338 for less crash.
Status: Fixed (was: Started)
Project Member

Comment 8 by ClusterFuzz, Apr 11 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 18 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Release-0-M52 M-52
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 28

Labels: -Pri-1 Pri-2

Sign in to add a comment