New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601734 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Either fix or remove the NTP order-persisting code

Project Member Reported by treib@chromium.org, Apr 8 2016

Issue description

As part of Popular Sites, we added code that tries to keep the order of NTP tiles constant. However, that turned out to cause problems (bug 585391), and the code will get disabled for now.
We need to figure out a way to fix and re-enable it, or properly remove the code.
 
Labels: -Pri-3 M-51 Pri-1
Adding M51 label as we need to fix this on the upcoming M51 branch.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ccdaa9f095e8b911529adcc1c51e47fc2dac102

commit 8ccdaa9f095e8b911529adcc1c51e47fc2dac102
Author: treib <treib@chromium.org>
Date: Fri Apr 08 10:26:07 2016

NTP: Fix "Undo" option of the "Item removed" snackbar

Turns out the order-persisting code broke this in some cases.
This is a quick fix which just disables that code, for merging to M50.
Mid-term, we'll figure out a proper fix or actually remove that code.

BUG=585391, 601734 

Review URL: https://codereview.chromium.org/1863393007

Cr-Commit-Position: refs/heads/master@{#386040}

[modify] https://crrev.com/8ccdaa9f095e8b911529adcc1c51e47fc2dac102/chrome/browser/android/ntp/most_visited_sites.cc

Comment 3 by treib@chromium.org, Apr 8 2016

Labels: -Pri-1 -M-51 M-52 Pri-2
The quick fix landed before the M51 branch point, so there's no immediate action required for M51. Removing the new-dead code can wait another release, no need to merge that back.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8aaa9179da4b8287e058b2c95ac8ae6790ad3e

commit 8a8aaa9179da4b8287e058b2c95ac8ae6790ad3e
Author: Marc Treib <treib@chromium.org>
Date: Mon Apr 11 08:18:41 2016

NTP: Fix "Undo" option of the "Item removed" snackbar

Turns out the order-persisting code broke this in some cases.
This is a quick fix which just disables that code, for merging to M50.
Mid-term, we'll figure out a proper fix or actually remove that code.

BUG=585391, 601734 

Review URL: https://codereview.chromium.org/1863393007

Cr-Commit-Position: refs/heads/master@{#386040}
(cherry picked from commit 8ccdaa9f095e8b911529adcc1c51e47fc2dac102)

Review URL: https://codereview.chromium.org/1875033002 .

Cr-Commit-Position: refs/branch-heads/2661@{#547}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/8a8aaa9179da4b8287e058b2c95ac8ae6790ad3e/chrome/browser/android/most_visited_sites.cc

Comment 5 by treib@chromium.org, Apr 11 2016

Labels: -merge-merged-2661
Removing the "merged" label, as that really applies to bug 585391 and is misleading here.
Project Member

Comment 6 by bugdroid1@chromium.org, May 18 2016

Project Member

Comment 7 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by treib@chromium.org, Jun 17 2016

Cc: sfiera@chromium.org
Labels: -Pri-2 Pri-3
Status: Started (was: Assigned)
This is mostly done now - one remaining thing: We still store the previous NTP suggestions in a pref, but the only use of that is for determining if there were enough personal suggestions, and thus we don't need popular sites.
We should get rid of the kNTPSuggestionsIsPersonal and kNTPSuggestionsURL prefs, and just replace them by a single bool (or maybe we can get by without any pref?)

Comment 10 by fi...@chromium.org, Jun 17 2016

Cc: treib@chromium.org
 Issue 620726  has been merged into this issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 14 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by treib@chromium.org, Jul 15 2016

Status: Fixed (was: Started)
https://codereview.chromium.org/2131863002/ / crrev.com/405193 should have been linked against this bug. With that, we can consider this done.

Sign in to add a comment