Either fix or remove the NTP order-persisting code |
||||||||
Issue descriptionAs part of Popular Sites, we added code that tries to keep the order of NTP tiles constant. However, that turned out to cause problems (bug 585391), and the code will get disabled for now. We need to figure out a way to fix and re-enable it, or properly remove the code.
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ccdaa9f095e8b911529adcc1c51e47fc2dac102 commit 8ccdaa9f095e8b911529adcc1c51e47fc2dac102 Author: treib <treib@chromium.org> Date: Fri Apr 08 10:26:07 2016 NTP: Fix "Undo" option of the "Item removed" snackbar Turns out the order-persisting code broke this in some cases. This is a quick fix which just disables that code, for merging to M50. Mid-term, we'll figure out a proper fix or actually remove that code. BUG=585391, 601734 Review URL: https://codereview.chromium.org/1863393007 Cr-Commit-Position: refs/heads/master@{#386040} [modify] https://crrev.com/8ccdaa9f095e8b911529adcc1c51e47fc2dac102/chrome/browser/android/ntp/most_visited_sites.cc
,
Apr 8 2016
The quick fix landed before the M51 branch point, so there's no immediate action required for M51. Removing the new-dead code can wait another release, no need to merge that back.
,
Apr 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a8aaa9179da4b8287e058b2c95ac8ae6790ad3e commit 8a8aaa9179da4b8287e058b2c95ac8ae6790ad3e Author: Marc Treib <treib@chromium.org> Date: Mon Apr 11 08:18:41 2016 NTP: Fix "Undo" option of the "Item removed" snackbar Turns out the order-persisting code broke this in some cases. This is a quick fix which just disables that code, for merging to M50. Mid-term, we'll figure out a proper fix or actually remove that code. BUG=585391, 601734 Review URL: https://codereview.chromium.org/1863393007 Cr-Commit-Position: refs/heads/master@{#386040} (cherry picked from commit 8ccdaa9f095e8b911529adcc1c51e47fc2dac102) Review URL: https://codereview.chromium.org/1875033002 . Cr-Commit-Position: refs/branch-heads/2661@{#547} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/8a8aaa9179da4b8287e058b2c95ac8ae6790ad3e/chrome/browser/android/most_visited_sites.cc
,
Apr 11 2016
Removing the "merged" label, as that really applies to bug 585391 and is misleading here.
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a59f543c995af94830d79a8ca3865d7fc19b7fa commit 5a59f543c995af94830d79a8ca3865d7fc19b7fa Author: treib <treib@chromium.org> Date: Wed May 18 12:17:29 2016 MostVisitedSites: Remove unused order-persisting code plus some related cleanup This is part 1 of N, there's more cleanup to be done here. BUG= 601734 Review-Url: https://codereview.chromium.org/1972923002 Cr-Commit-Position: refs/heads/master@{#394389} [modify] https://crrev.com/5a59f543c995af94830d79a8ca3865d7fc19b7fa/chrome/browser/android/ntp/most_visited_sites.cc [modify] https://crrev.com/5a59f543c995af94830d79a8ca3865d7fc19b7fa/chrome/browser/android/ntp/most_visited_sites.h [modify] https://crrev.com/5a59f543c995af94830d79a8ca3865d7fc19b7fa/chrome/browser/android/ntp/most_visited_sites_unittest.cc
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24efd8f2b60ebd3018af428b64135215cde97c16 commit 24efd8f2b60ebd3018af428b64135215cde97c16 Author: treib <treib@chromium.org> Date: Thu Jun 16 19:37:39 2016 MostVisitedSites cleanup: kill SuggestionsPtrVector BUG= 601734 Review-Url: https://codereview.chromium.org/2069263003 Cr-Commit-Position: refs/heads/master@{#400232} [modify] https://crrev.com/24efd8f2b60ebd3018af428b64135215cde97c16/components/ntp_tiles/most_visited_sites.cc [modify] https://crrev.com/24efd8f2b60ebd3018af428b64135215cde97c16/components/ntp_tiles/most_visited_sites.h [modify] https://crrev.com/24efd8f2b60ebd3018af428b64135215cde97c16/components/ntp_tiles/most_visited_sites_unittest.cc
,
Jun 17 2016
This is mostly done now - one remaining thing: We still store the previous NTP suggestions in a pref, but the only use of that is for determining if there were enough personal suggestions, and thus we don't need popular sites. We should get rid of the kNTPSuggestionsIsPersonal and kNTPSuggestionsURL prefs, and just replace them by a single bool (or maybe we can get by without any pref?)
,
Jun 17 2016
,
Jul 14 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 15 2016
https://codereview.chromium.org/2131863002/ / crrev.com/405193 should have been linked against this bug. With that, we can consider this done. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nepper@chromium.org
, Apr 8 2016