Issue metadata
Sign in to add a comment
|
Screenshot upload should retry on error |
||||||||||||||||||||||||
Issue descriptionIf there's an error uploading screenshots for monitoring purposes, we should retry a few times - it should be possible to do this just by updating kMaxRetries in upload_job_impl.cc and updating the tests.
,
Apr 11 2016
,
Apr 11 2016
,
Apr 11 2016
duping bugs on eachother seems bad - reopening this one since it was first.
,
Apr 12 2016
We also should wait 20 seconds between each retry rather than retrying immediately - that way we are resilient to transient network failures. It's OK to add this as a separate CL from enabling retries.
,
Apr 14 2016
,
Apr 29 2016
Friendly ping for an update.
,
Apr 29 2016
See CL at https://codereview.chromium.org/1875443003/, feedback is welcome.
,
May 17 2016
Thanks Márton. Any update on the CL? It seems there's no activity for a while. Today, Costco (one of our customer) reported that their screenshot commands are always failing. I believe fixing this issue would improve user experiences. Can you please prioritize this work item? Thanks.
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2751d2194788416ca1949e51b29ed09fd1704c47 commit 2751d2194788416ca1949e51b29ed09fd1704c47 Author: hunyadym <hunyadym@chromium.org> Date: Wed May 18 14:17:13 2016 Retry uploading in UploadJobImpl when error occurs UploadJobImpl retries uploading when errors (authorization, network or server error) occurs up to a maximum of 3 retries, with a delay between the attempts. BUG= 601730 Review-Url: https://codereview.chromium.org/1875443003 Cr-Commit-Position: refs/heads/master@{#394411} [modify] https://crrev.com/2751d2194788416ca1949e51b29ed09fd1704c47/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc [modify] https://crrev.com/2751d2194788416ca1949e51b29ed09fd1704c47/chrome/browser/chromeos/policy/system_log_uploader.cc [modify] https://crrev.com/2751d2194788416ca1949e51b29ed09fd1704c47/chrome/browser/chromeos/policy/upload_job_impl.cc [modify] https://crrev.com/2751d2194788416ca1949e51b29ed09fd1704c47/chrome/browser/chromeos/policy/upload_job_impl.h [modify] https://crrev.com/2751d2194788416ca1949e51b29ed09fd1704c47/chrome/browser/chromeos/policy/upload_job_unittest.cc
,
May 18 2016
,
Jul 28 2016
,
Jul 29 2016
,
Aug 2 2016
,
Aug 15 2016
Verified in M52-Stable, build 8350.69.0 Also verified in M53-Beta, build 8530.57.0 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by atwilson@chromium.org
, Apr 8 2016