gfx::ScopedActiveTexture and gfx::ScopedTextureBinder are incompatible |
|||||
Issue descriptiongfx::ScopedTextureBinder has an optimization where it restores the state from the ContextState, instead of querying the GL driver. This backfires when GL_ACTIVE_TEXTURE has changed, because gfx::ScopedTextureBinder will re-bind whatever texture the ContextState thinks was active, which will not be accurate, because it will not be updated gfx::ScopedActiveTexture. One fix for this is to have gfx::ScopedActiveTexture update ContextState. That seems a little bit tricky, and potentially a bad idea -- my understanding of StateRestorer is that it isn't supposed to modify ContextState. For the moment, in issue 599314, I'm proposing to just note this bug and use a scoped block runner to reset the state.
,
Jun 9 2017
ccameron@: I had submitted https://codereview.chromium.org/2762833003 to use ContextState restoration for ActiveTexture. Would this help?
,
Jun 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 22 2018
,
Jun 25 2018
Probably fixed by #2. If not, then this can be archived and just kept for future reference. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vmi...@chromium.org
, Apr 8 2017Status: Available (was: Untriaged)